From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 949D8A04C8; Fri, 18 Sep 2020 15:32:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C7151DA71; Fri, 18 Sep 2020 15:32:00 +0200 (CEST) Received: from qrelay104.mxroute.com (qrelay104.mxroute.com [172.82.139.104]) by dpdk.org (Postfix) with ESMTP id 75A961DA70 for ; Fri, 18 Sep 2020 15:31:58 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] 149.28.56.236.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by qrelay104.mxroute.com (ZoneMTA) with ESMTPA id 174a16a0d4c000b8c7.002 for ; Fri, 18 Sep 2020 13:31:56 +0000 X-Zone-Loop: 162c180c16a9352598010fa8e292032dc6e5ba32e4f9 X-Originating-IP: [149.28.56.236] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter004.mxroute.com (Postfix) with ESMTPS id C8CAE3EB09; Fri, 18 Sep 2020 13:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uwz23jf6wvpJvEbGErB9qhrH7Hwcw+kejOCy4OHM8aU=; b=qSnNu3j+jWlwbmICX8Ag+M5s6h J8Wv2fz13uXSejKwFnbLOUxsOejvpkn3F29TQSpUnfLO1JAnNJfeWq8xYFpT5YptKVI6fTD41mj3n 9m8SF6JrX1NAa5uWs9SqKPVhvH3CUEOSwzPcu+UxlMqgYlgpAZ3WAnEK6LLdYw3khKJNZgLY9c3/4 Iep0LZwuKOMYZ1tmhxtnGvp2gzJBXodaFcieTPs5G7SafuX12MGzHE/G3KCAJfxSneYS/OGOiT72G H27i3nStnxyOX9p3EnMXI87fkVQjvJnUYl9ymsbPO+c5h8H+hCBfs0ykDE/taEzSwgB/KbKdHq/NX x6LAA4Kw==; To: Olivier Matz , Dmitry Kozlyuk Cc: dev@dpdk.org, Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , "Kadam, Pallavi" , Neil Horman References: <20200620210511.13134-1-dmitry.kozliuk@gmail.com> <20200730210652.14568-1-dmitry.kozliuk@gmail.com> <20200730210652.14568-2-dmitry.kozliuk@gmail.com> <20200917133443.GR21395@platinum> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: <78db7385-0790-3abe-5be6-78944ab0c010@ashroe.eu> Date: Fri, 18 Sep 2020 14:31:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200917133443.GR21395@platinum> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v2 1/7] cmdline: make implementation opaque X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 17/09/2020 14:34, Olivier Matz wrote: > Hi Dmitry, > > On Fri, Jul 31, 2020 at 12:06:45AM +0300, Dmitry Kozlyuk wrote: >> struct cmdline exposes platform-specific members it contains, most >> notably struct termios that is only available on Unix. Make the >> structure opaque. >> >> Remove tests checking struct cmdline content as meaningless. >> >> Add cmdline_get_rdline() to access history buffer. >> The new function is currently used only in tests. >> >> Signed-off-by: Dmitry Kozlyuk > > First, please forgive me for the very late feedback. It is all the more > problematic because I think this patch introduces an ABI breakage, that > should have been announced. I think this is more a theoretical ABI breakage, than a real ABI breakage. As the consuming application is never likely to access the structure, As in most cases, I doubt it ever has any knowledge of the structure. My 2c, is that I think it is fine not consider this as ABI breakage. > > Making cmdline struct opaque clearly goes in the right direction, as > it will prevent future ABI breakage. > > In my opinion, we could accept the patch for 20.11, knowing it reduce > the risk of future ABI breakage, and that cmdline is not a core > component of DPDK. However it has to be discussed and accepted by other > people. > > Else, the patch would be delayed for 21.11. From what I see from the > other patches, it looks possible to keep cmdline struct public without > breaking the existing ABI by adding #ifdef CONFIG_RTE_EXEC_ENV_WINDOWS, > is it correct? > > One minor comment below: > >> --- a/app/test/test_cmdline_lib.c >> +++ b/app/test/test_cmdline_lib.c >> @@ -46,22 +46,29 @@ complete_buffer(__rte_unused struct rdline *rdl, >> static int >> test_cmdline_parse_fns(void) >> { >> - struct cmdline cl; >> + struct cmdline *cl; >> + cmdline_parse_ctx_t ctx; >> int i = 0; >> char dst[CMDLINE_TEST_BUFSIZE]; >> >> + cl = cmdline_new(&ctx, "prompt", -1, -1); >> + if (cl == NULL) { >> + printf("Error: cannot create cmdline to test parse fns!\n"); >> + return -1; >> + } >> + >> if (cmdline_parse(NULL, "buffer") >= 0) >> goto error; >> - if (cmdline_parse(&cl, NULL) >= 0) >> + if (cmdline_parse(cl, NULL) >= 0) >> goto error; >> >> if (cmdline_complete(NULL, "buffer", &i, dst, sizeof(dst)) >= 0) >> goto error; >> - if (cmdline_complete(&cl, NULL, &i, dst, sizeof(dst)) >= 0) >> + if (cmdline_complete(cl, NULL, &i, dst, sizeof(dst)) >= 0) >> goto error; >> - if (cmdline_complete(&cl, "buffer", NULL, dst, sizeof(dst)) >= 0) >> + if (cmdline_complete(cl, "buffer", NULL, dst, sizeof(dst)) >= 0) >> goto error; >> - if (cmdline_complete(&cl, "buffer", &i, NULL, sizeof(dst)) >= 0) >> + if (cmdline_complete(cl, "buffer", &i, NULL, sizeof(dst)) >= 0) >> goto error; >> >> return 0; >> @@ -166,11 +173,11 @@ static int >> test_cmdline_fns(void) >> { >> cmdline_parse_ctx_t ctx; >> - struct cmdline cl, *tmp; >> + struct cmdline *cl; >> >> memset(&ctx, 0, sizeof(ctx)); >> - tmp = cmdline_new(&ctx, "test", -1, -1); >> - if (tmp == NULL) >> + cl = cmdline_new(&ctx, "test", -1, -1); >> + if (cl == NULL) >> goto error; >> >> if (cmdline_new(NULL, "prompt", 0, 0) != NULL) >> @@ -179,7 +186,7 @@ test_cmdline_fns(void) >> goto error; >> if (cmdline_in(NULL, "buffer", CMDLINE_TEST_BUFSIZE) >= 0) >> goto error; >> - if (cmdline_in(&cl, NULL, CMDLINE_TEST_BUFSIZE) >= 0) >> + if (cmdline_in(cl, NULL, CMDLINE_TEST_BUFSIZE) >= 0) >> goto error; >> if (cmdline_write_char(NULL, 0) >= 0) >> goto error; >> @@ -188,31 +195,14 @@ test_cmdline_fns(void) >> cmdline_set_prompt(NULL, "prompt"); >> cmdline_free(NULL); >> cmdline_printf(NULL, "format"); >> - /* this should fail as stream handles are invalid */ >> - cmdline_printf(tmp, "format"); >> cmdline_interact(NULL); >> cmdline_quit(NULL); >> >> - /* check if void calls change anything when they should fail */ >> - cl = *tmp; >> - >> - cmdline_printf(&cl, NULL); >> - if (memcmp(&cl, tmp, sizeof(cl))) goto mismatch; >> - cmdline_set_prompt(&cl, NULL); >> - if (memcmp(&cl, tmp, sizeof(cl))) goto mismatch; >> - cmdline_in(&cl, NULL, CMDLINE_TEST_BUFSIZE); >> - if (memcmp(&cl, tmp, sizeof(cl))) goto mismatch; >> - >> - cmdline_free(tmp); >> - >> return 0; >> >> error: >> printf("Error: function accepted null parameter!\n"); >> return -1; >> -mismatch: >> - printf("Error: data changed!\n"); >> - return -1; > > cmdline_free(cl) is missing. > > before your patch, cmdline_free(tmp) was already missing in error case > by the way. > > > Thanks, > Olivier >