From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82]) by dpdk.org (Postfix) with ESMTP id C2D996CC8 for ; Thu, 17 May 2018 14:35:54 +0200 (CEST) To: Bruce Richardson Cc: dev@dpdk.org References: <152627436523.53156.4398253089110011263.stgit@localhost.localdomain> <152627457252.53156.7037125685610031955.stgit@localhost.localdomain> <20180517103658.GA16984@bricha3-MOBL.ger.corp.intel.com> From: Andy Green Message-ID: <78e21755-2ef2-8a72-18cd-40e23f0d342e@warmcat.com> Date: Thu, 17 May 2018 20:35:21 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 In-Reply-To: <20180517103658.GA16984@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 01/23] lib/librte_eal: import libbsd strlcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 12:35:54 -0000 On 05/17/2018 06:36 PM, Bruce Richardson wrote: > On Mon, May 14, 2018 at 01:09:32PM +0800, Andy Green wrote: >> Signed-off-by: Andy Green >> --- >> lib/librte_eal/common/eal_common_string_fns.c | 34 ++++++++++++++++++++++++ >> lib/librte_eal/common/include/rte_string_fns.h | 7 +---- >> 2 files changed, 36 insertions(+), 5 deletions(-) >> > > While I'm aware this was suggested by other reviewers, I really don't feel > that it is necessary to actually import the code. If libbsd is present on > the system, we will use it directly. If libbsd is not present, the snprintf > provides an acceptable fallback for strlcpy IMHO. Having the full function > without good justification seems excessive. Well, as you can probably guess, I don't really mind either way. This also implies another patch to export rte_strlcpy since it's no longer an inline in the headers this way. I removed these patches and rebuilt dpdk and then lagopus without it with the idea of pasting the compile error. But I can't reproduce the original problem... since then I rebased on current master dpdk, got updated to gcc 8.1 and added more patches on lagopus. So just drop this patch if you don't want the bsd lstrcpy. -Andy > /Bruce >