From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0DBBC1B19 for ; Fri, 12 Jan 2018 20:13:25 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jan 2018 11:13:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,350,1511856000"; d="scan'208";a="18758239" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by FMSMGA003.fm.intel.com with ESMTP; 12 Jan 2018 11:13:23 -0800 To: Tomasz Duszynski , dev@dpdk.org Cc: jck@semihalf.com, mw@semihalf.com, dima@marvell.com, nsamsono@marvell.com, Jianbo.liu@arm.com References: <1515684943-32506-1-git-send-email-tdu@semihalf.com> <1515684943-32506-3-git-send-email-tdu@semihalf.com> From: Ferruh Yigit Message-ID: <7902c50d-59b2-2f9f-510b-a9ec2000e98d@intel.com> Date: Fri, 12 Jan 2018 19:13:22 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1515684943-32506-3-git-send-email-tdu@semihalf.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/5] net/mrvl: fix hif objects allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 19:13:26 -0000 On 1/11/2018 3:35 PM, Tomasz Duszynski wrote: > From: Natalie Samsonov Commit title updated to [1] assuming hif is an abbreviation (btw, what is hif?) [1] net/mrvl: fix HIF objects allocation > > 1. Add checking for non-EAL threads. > > 2. Create hif objects on first use since sometimes on probe not all > lcores are initialized and can be added later. > In this case the hif objects for later cores were not created and > this caused system crash. > > Fixes: 0ddc9b8 ("net/mrvl: add net PMD skeleton") Fixes: 0ddc9b815b11 ("net/mrvl: add net PMD skeleton") Cc: stable@dpdk.org > > Signed-off-by: Natalie Samsonov <...>