From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68EF7A0C43; Tue, 28 Sep 2021 18:46:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF1FB410D7; Tue, 28 Sep 2021 18:46:41 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 74F6740E3C; Tue, 28 Sep 2021 18:46:40 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10121"; a="212004321" X-IronPort-AV: E=Sophos;i="5.85,329,1624345200"; d="scan'208";a="212004321" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2021 09:46:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,329,1624345200"; d="scan'208";a="706752559" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga006.fm.intel.com with ESMTP; 28 Sep 2021 09:46:38 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 28 Sep 2021 09:46:38 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 28 Sep 2021 09:46:38 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 28 Sep 2021 09:46:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NfEyqBTVOS8VDO2kV9slxDBTN15ymueErfWOQMHS1EZ2hrU7tRLBGq2aZJHOAIYQWmD0oZ7j6JI8a88Eg3G/rrRwXNuc29nfMb0xi3yswt8P7v08SoudLb8jdWZw+XRJz4z0M+42WKSf3mFxQNWIIZirUsHyFo2usuvH3RJJhmXXDXFhWbVcPJYHBz3aZF4CqLqgGR28YcioCkSMCvo3cnjRiEzHg3UQ5Q8N9TTrD+NMQ4M/K0QaFoeTyjR6q5f10664I0o2QUpcQ/jRc8nfilvj+qVit05sYUm+NyktGhcEfcUmsbUtNa4zoFnSdOw6pknfvsKyb5wU42FwZM8/CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3gQMutDB3481X3g3D0U0CryzddWl9jtmi0USIT9XUwU=; b=U3ruFbOWfqmKldxBFaZl+Fto3Q1p4Q5kzvPXc3OBSPyQAjwfCz24b/p+K1MTNZaAHx3c3kiCwtvBNqkzs+1NDHqLPVOlHrZfhELwzjuwrFJ4+Vs3LWisnSrpH7r8TufvvF9OGTwghTqedaNDGJ06pufVhYISUcB918zMAugKXApGp1rjZqcYDwHc3MCvkYqaqcwQPVIAlRYeuZU6pF/zm3ePykOlLIKQoicLAjL/HNS+g5BIF4Tmu/3aqSUSQhmDiSZcWqjVP6t+qJqiR/C5rFBptfDGmVUJ14vZX8z+Uu0ZV36yUE/jLAltBlYx6xTkkwwL85CX08HWJvoBKV+VFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3gQMutDB3481X3g3D0U0CryzddWl9jtmi0USIT9XUwU=; b=mibV9s3a1wDAG5r1dyVAH/zlEWcpGhDm9AvQ6cWkjfKXYpwV9AMUIuzEeaG2vmz8rkK5rcFNEzeGmtrCwwjiparORw2tZK6g4mYOKq8wRalC+azgI0DJLvGUkx7zSXGTDU4bQ5qku89yFRJ5DvItfkaWK24i+2luMMjI6ebGgJs= Authentication-Results: xilinx.com; dkim=none (message not signed) header.d=none;xilinx.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4887.namprd11.prod.outlook.com (2603:10b6:510:30::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Tue, 28 Sep 2021 16:46:36 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4544.021; Tue, 28 Sep 2021 16:46:36 +0000 To: Andrew Rybchenko , Thomas Monjalon , Kuba Kozak CC: , Olivier Matz , Ivan Ilchenko , , Andy Moreton References: <20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru> <20210928120533.834334-1-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy Message-ID: <79165048-11bf-e1fb-4e81-2aa45ea7c3ca@intel.com> Date: Tue, 28 Sep 2021 17:46:29 +0100 In-Reply-To: <20210928120533.834334-1-andrew.rybchenko@oktetlabs.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0232.eurprd04.prod.outlook.com (2603:10a6:10:2b1::27) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0232.eurprd04.prod.outlook.com (2603:10a6:10:2b1::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.13 via Frontend Transport; Tue, 28 Sep 2021 16:46:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 14cf386a-fca0-4549-87b7-08d9829f8945 X-MS-TrafficTypeDiagnostic: PH0PR11MB4887: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ri5phKzZnYsit1368AGSnTIh6cgTp3UA9ZazL+XznDfwmJpAsPD8SLx11+WEThIYTlia+k5xiYw1gzu6puaETfkuxESpq9qd3j4GILZsfMFrHCB2RLHkwlWwBgjgE9jzLOJIo8RSDUYdVcNdbbx2RkOE1ImHooO8T4RxcuqRkGCHNcj0D06NNpUdK5p3+XO3iMAlw2Go7ec1okbQgEGM/AYKGaMpD/epXHd0NA4GsPwUgZJHJ52P55H5eRiRr6BXBOQOscY4/FwJkKsTo8BlHnvh5hCQcj6iK8hjP5F1Gx6cTFo4aIP11eLePNgBXmaq2HzmYoIvJiYCVnvSUEmArDI5YaWjq9xCxmiTyQz3fi1C+eyARqombnv68mpO/yXB43aduEDI8B2eVazsKagEwnky6/AuI5NXd82Q2sMxpx2L98B9vQs1x27MRAXFnbPmMhSjjqt90/qpQoWtIx7SZolk6LfFCamiIohAtso8lx7dfRGuXUA0aALw5o221aZVfVgnTnetRURczZg8Jttomtfcyc1jnQPX/1wt8o4EA+6jJmBWUXRA/KxbLtLaBTseowesoKevQDyNSJN0brZUsV3EMScDZrvriWnvVUOhc1Tb1lvUaEe8h0X5JLdHFFgG2EGgjiaKj1LvvlpWXLKhWFtUVCkufT9eKVaoB2vdEMmyZfAS36uHOOCRtLsh9VQM10uj7gy/cgjlEmp5F2jN6Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(186003)(4326008)(316002)(36756003)(6636002)(8676002)(26005)(54906003)(110136005)(2906002)(53546011)(16576012)(31686004)(83380400001)(66946007)(5660300002)(44832011)(6666004)(31696002)(2616005)(956004)(6486002)(66556008)(508600001)(8936002)(66476007)(86362001)(38100700002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1pTbzlkdE5zRDduNndTWk9iK2FKUDFMRkpIS0NQOE5YZTV2MHJsa0Z1UVcr?= =?utf-8?B?Y3ZmNVJjbk5qaGhMM284c2pnMG90eGMzV01oQWFMM1c4VXJTVkR1bjRuYXAr?= =?utf-8?B?Q2NFdzBsRVR3UEdZazBXZEFiZm1hZXR0eWs2bDFuRFZYMkNiMHN4NlZJeHh4?= =?utf-8?B?WEdtZ3c4WE5sSGpQdmRLNnJBK00raDRvcEkyMWZYUi82NnJmTjJabWk3L0ls?= =?utf-8?B?b3U5TDJ6S2VCYy8wU0VzbXdua3hCTlhDUG5DaktpRlk2di9OZnAweDVzR2Yv?= =?utf-8?B?NVRDUXBpYUt1b1JOdFVaRXg0Z3cvWmsweURCQStwVUtZS1VDaTdhOUdEdXRR?= =?utf-8?B?ZVFTUWdULzdZcUN0QVBkN0FJWkNab25ManJiTmpaS0dEQUFXb01JU1ZiUVpi?= =?utf-8?B?am1maDNHM2FoUGFiVHlYWWJDNDFkZFNUNnF3eXFVZDM3OE10dzVFQUlCcVQ2?= =?utf-8?B?bHN6NW1rTVdqeU5VVGNJSnFEbXpZZ01DZHRIU0ZiNEYyUkVvRWJiRmhEeFR4?= =?utf-8?B?UGU5QzV4Qm5lTXZlNVNMSTR3WXZha29QcjZrQTB0RE5rOHRUZk9iOEhweTdD?= =?utf-8?B?b0NhUi80dVB0VXFPNHRMQUs4RCtJZkRUSVZzcmw0WElaemNHN0RSZ0JKNE1z?= =?utf-8?B?ZkdtaW85aU9YMHdrYVp3dGZHSGVIdkRkbjduK1Z5ZUpyRHFKYjhVOUlLTENF?= =?utf-8?B?UjFpbzhZcm80U2p1dDIxRjNScmllVStkUDdYaEttNWxwNjcvVHZXYkhPZURt?= =?utf-8?B?VzlJbGZvb0NteE1NMWd1anJFMXRpeC9oMDZ4Mmo0RXFtRDRkUmw3QTZVVlhk?= =?utf-8?B?N1hFbm1ZdWUrRHlTVVlXU016SnNPcFhkNytieUlZWGNpcjVKNnZmcFBWVTk5?= =?utf-8?B?UG4wU2xKajl0cklka0xjSlVJNXlJa09ZZEtjZktkVWtrbzZya1NyUElvUnlE?= =?utf-8?B?enZsZnU2WlM3NUFYRS8rcFNyT0NvaTdiZFd4T0llTXEzRUhHWWljTWVoVm1o?= =?utf-8?B?V3czZFRPclZuQ3JiYWdEanVnMWV1WThkYmVlbGtDcHZ3WXp2azNXRkVoencv?= =?utf-8?B?b0RCSFVuMnpBS2xHRjJ2bnFXaHlIeDFTdHYvU0c2ZU54YjNFOC9HS3k0VHo4?= =?utf-8?B?aUV4eEtTUHZ3MStJZWU5ZkdUS2RJYlBFK1RIMFFwT2Mza2lDMWFjMGZUeXhN?= =?utf-8?B?MGxwb0JMRU9EZzZsMTB3WUVCS2c0MWJzNWUxRlhhTzhOM21mTENwbEhzSzho?= =?utf-8?B?U0JnRjRxWWdGdDZqZjNrcjVDc29lNHM1Y01xL3FUMkhYNWdYWWYvdWdteUJV?= =?utf-8?B?WDBMRzNWODdFYnZTbzNCMHhaQkw5ZzI1WGE5TTZ5RSt0ZUpqU0J5MXNRcnRQ?= =?utf-8?B?RzZRUGpSdnFPMWIyZG9EdEIwR1VJbDYxQ2MxeEpLOHVuVWt0aG1NaTNCcEE2?= =?utf-8?B?em1NVTJ5YkZEYUhRWXlZemwrUDErUnFUdk5WZ1N5ZU5FY0pZOWxZd29nT0tB?= =?utf-8?B?dUhWQnI3cXIrR0FkdTJ4dFJ0ODZCSVFualI1RStNc2UvYU5sZGRaYm44QzdR?= =?utf-8?B?UGhjdFZ2STNNUTYwajNKb3RwTHpPY056ODhYRmtZNEFFb2FBWkh5UXAzWUt6?= =?utf-8?B?YldYYnpCdVVIemliQWorcGY3c080ZFBqamJUUWhUakprSDhjWis0Y3FXWUZG?= =?utf-8?B?bjEvbHAxWHBaalpKTEtwb2dkMlAvak5LZ0pDbHkySy9sQWI2bFJoZlcrM28r?= =?utf-8?Q?P22RBTZMOWY6b/gDtJXmd/b0wNNNqZjmDJgVaIF?= X-MS-Exchange-CrossTenant-Network-Message-Id: 14cf386a-fca0-4549-87b7-08d9829f8945 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2021 16:46:36.5535 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YW4mBkVXfhNiRuX8Tyo8BiM9QobE0v24V65u5U0My0s4rDTiXukOYWPhZx/W0ZGN3ugdLO+ZRfxTfznn4JYfnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4887 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5 1/2] ethdev: fix docs of functions getting xstats by IDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/28/2021 1:05 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Document valid combinations of input arguments in accordance with > current implementation in ethdev. > > Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") > Cc: stable@dpdk.org > > Signed-off-by: Ivan Ilchenko > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton Reviewed-by: Ferruh Yigit Only minor issue below. > @@ -2926,22 +2928,23 @@ rte_eth_xstats_get_names_by_id(uint16_t port_id, > * @param port_id > * The port identifier of the Ethernet device. > * @param ids > - * A pointer to an ids array passed by application. This tells which > - * statistics values function should retrieve. This parameter > - * can be set to NULL if size is 0. In this case function will retrieve > - * all available statistics. > + * IDs array given by app to retrieve specific statistics. May be NULL to > + * retrieve all available statistics or, if @p values is NULL as well, > + * just the number of available statistics. > * @param values > - * A pointer to a table to be filled with device statistics values. > + * Array to be filled in with requested device statistics. > + * Must not be NULL if ids are specified (not NULL). Minor issue, @p marker is missed before 'ids', comparing the 'rte_eth_xstats_get_names_by_id()' comment.