From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 8C64A2BA2 for ; Wed, 20 Jul 2016 22:15:31 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id o80so84496963wme.1 for ; Wed, 20 Jul 2016 13:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=YLfiFliCmifUs9pfbAOYdsEcnoiElGOeqajRn7IDui0=; b=WrjCccTAEW8axoyMEpfFbUEMCkzYDl1YQqEO35qd4BA0B8FGrG8L1LWHA5CToHGNDC P7E4ReqbC3zDWXQ5gocsX8cl5tFl4s9rV7s/v/cCLINlaPQJEaXjEG/FC9VOI5e1GGhf +vM/0pxiqCJOCAU0GZ/LFatmWwvp/aWVdzPAHGc6zTwr+95csXKBRH48clGW6D+s7heU BOdlxUYfaRwrwTJji9HaJNRHNb2hETLrcI3Zqo4afFXGkTtTvliuVnhRi2e0Wrr4S/Jq XpUBn7C0d9s6n4skbhSBP1N4fcbHiQJXen1Tuih9MhZIdh1jXK5+GGE6gTIsj64siXbg Tq8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=YLfiFliCmifUs9pfbAOYdsEcnoiElGOeqajRn7IDui0=; b=SAO5kXnOo04nX7qDD//t5UNs+zxbFov6XcbGRPoFB4/MpzsZJ1c0IGp5D8lndmGwLi Na2rO6XB4/sOphMgQzf6f0NpI5DPo/qJqkg4kkXe8N0rxUj7jaGq/sy2INmmKZqA9VoV q7Da+FbbCfzD9NzJoa+b9rDSBF12bfV/VdkFhVRGapziviGs1kvvK30ueRwpd9VKCqUw xJUqU4cMlo+fzwzHsHAeyxKgqwOF8L20DUBltsPkheu/1V5fbMWbnJq2dbuxZDS79oTn cQlQtZuEUok45Hw+S3YPPjzA33VUC2HtdgaLzdVl8qJmQivWThOa8Svietp62Z60HwYt R2Gg== X-Gm-Message-State: ALyK8tIM0Yzvh2u+9k6Y+pN6eDMAHxkVysh2c3266yt7vWkVII/MmPpe+c+GPX9xXrG5vF2q X-Received: by 10.194.145.103 with SMTP id st7mr3157155wjb.27.1469045730297; Wed, 20 Jul 2016 13:15:30 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id a2sm33139039wma.2.2016.07.20.13.15.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jul 2016 13:15:29 -0700 (PDT) From: Thomas Monjalon To: "Wiles, Keith" Cc: Neil Horman , Neil Horman , dev@dpdk.org, "Mcnamara, John" Date: Wed, 20 Jul 2016 22:15:28 +0200 Message-ID: <7923871.JAtBDztydg@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1469034588-1847-1-git-send-email-nhorman@tuxdriver.com> <20160720174849.GE28844@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] validate_abi: build faster by augmenting make with job count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2016 20:15:31 -0000 2016-07-20 19:47, Wiles, Keith: > On Jul 20, 2016, at 12:48 PM, Neil Horman wrote: > > On Wed, Jul 20, 2016 at 07:40:49PM +0200, Thomas Monjalon wrote: > >> 2016-07-20 13:09, Neil Horman: > >>> From: Neil Horman > >>> +if [ -z "$MAKE_JOBS" ] > >>> +then > >>> + # This counts the number of cpus on the system > >>> + MAKE_JOBS=`lscpu -p=cpu | grep -v "#" | wc -l` > >>> +fi > >> > >> Is lscpu common enough? > >> > > I'm not sure how to answer that. lscpu is part of the util-linux package, which > > is part of any base install. Theres a variant for BSD, but I'm not sure how > > common it is there. > > Neil > > > >> Another acceptable default would be just "-j" without any number. > >> It would make the number of jobs unlimited. > > I think the best is just use -j as it tries to use the correct number of jobs based on the number of cores, right? No Keith, -j alone use as much jobs as it can create, i.e. much more than the number of CPUs. I have no measure but I remember it is less efficient than giving a number based on available CPUs (with a multiply factor to avoid idling between jobs). For a default value, both approaches are fine.