From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 6C0ED4F91 for ; Tue, 9 Apr 2019 12:58:10 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id r4so20271943wrq.8 for ; Tue, 09 Apr 2019 03:58:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=NEUUcoHx7MOg11AW4UgKpkBEBWxcgXH9EGwA1vgVNT4=; b=iX2c/cBfFB0yv1n/1f7fwGDQQPVUaQ+ogkYG05IB0TizjM4896V20mxe7qY/emAWRR U6NtdJ2TEKmx6B1ARq+ZE+epHCbSbBpON85a6LP84Og7EQlc4XoBGrgx1NqtEfK/RDBE wf7udVmu0iq1JtImF0QV2NidxfDSfxFlzc1hdd5owsmFscX38BrdtPhoIF5311X7COnX EDIHkelHTylqJLb+bdeHoAHjaY5DVOToRI/Y2U6poWJPrc1CTtE6jx3FXkHRGiXyABov lGoj18R66TFhryhE8T7N5gU1vykD1ZpT7zmBmf91Ri2ygM80Y9lKVQEps6G5GrOWAkya l6uA== X-Gm-Message-State: APjAAAX/4hgqb+Iiy8BwZH7+ycxppbGBYM2uaCvJW9ZVkPGXfKBRKixK EjMktwgCUm2AN8HggxBS5/1Vu2VR X-Google-Smtp-Source: APXvYqw9hvFbLSt31yGu6S8AXQ3QeXG3diFSlbcJTLPE9rLcmb0iT7P464npqtAkyJ0JeOUGbxZEwQ== X-Received: by 2002:adf:e610:: with SMTP id p16mr22136008wrm.64.1554807490125; Tue, 09 Apr 2019 03:58:10 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:250:b6ff:feb7:bd60]) by smtp.gmail.com with ESMTPSA id x5sm24979920wru.12.2019.04.09.03.58.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 03:58:09 -0700 (PDT) Message-ID: <793e6f8b787bb5e51387d9b4dfa13a89378f5e02.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Cc: david.marchand@redhat.com Date: Tue, 09 Apr 2019 11:58:08 +0100 In-Reply-To: <20190409105539.61460-2-bruce.richardson@intel.com> References: <20190409105539.61460-1-bruce.richardson@intel.com> <20190409105539.61460-2-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/5] build: simplify subdirectory detection for EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 10:58:10 -0000 On Tue, 2019-04-09 at 11:55 +0100, Bruce Richardson wrote: > Within EAL we had a series of if statements for selecting the EAL > directory > to use. Now that the directory names match those of the OS's they are > for > we can instead just use a generated subdirectory name, shortening the > code. > To avoid strange errors, we still need to check for unsupported OS's, > but > do this check up-front in the config meson.build file. >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > Reviewed-by: David Marchand < > david.marchand@redhat.com > > > --- > config/meson.build | 7 +++++++ > lib/librte_eal/meson.build | 17 ++--------------- > 2 files changed, 9 insertions(+), 15 deletions(-) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1FECFA0096 for ; Tue, 9 Apr 2019 12:58:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DD2044F93; Tue, 9 Apr 2019 12:58:10 +0200 (CEST) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 6C0ED4F91 for ; Tue, 9 Apr 2019 12:58:10 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id r4so20271943wrq.8 for ; Tue, 09 Apr 2019 03:58:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=NEUUcoHx7MOg11AW4UgKpkBEBWxcgXH9EGwA1vgVNT4=; b=iX2c/cBfFB0yv1n/1f7fwGDQQPVUaQ+ogkYG05IB0TizjM4896V20mxe7qY/emAWRR U6NtdJ2TEKmx6B1ARq+ZE+epHCbSbBpON85a6LP84Og7EQlc4XoBGrgx1NqtEfK/RDBE wf7udVmu0iq1JtImF0QV2NidxfDSfxFlzc1hdd5owsmFscX38BrdtPhoIF5311X7COnX EDIHkelHTylqJLb+bdeHoAHjaY5DVOToRI/Y2U6poWJPrc1CTtE6jx3FXkHRGiXyABov lGoj18R66TFhryhE8T7N5gU1vykD1ZpT7zmBmf91Ri2ygM80Y9lKVQEps6G5GrOWAkya l6uA== X-Gm-Message-State: APjAAAX/4hgqb+Iiy8BwZH7+ycxppbGBYM2uaCvJW9ZVkPGXfKBRKixK EjMktwgCUm2AN8HggxBS5/1Vu2VR X-Google-Smtp-Source: APXvYqw9hvFbLSt31yGu6S8AXQ3QeXG3diFSlbcJTLPE9rLcmb0iT7P464npqtAkyJ0JeOUGbxZEwQ== X-Received: by 2002:adf:e610:: with SMTP id p16mr22136008wrm.64.1554807490125; Tue, 09 Apr 2019 03:58:10 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:250:b6ff:feb7:bd60]) by smtp.gmail.com with ESMTPSA id x5sm24979920wru.12.2019.04.09.03.58.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 03:58:09 -0700 (PDT) Message-ID: <793e6f8b787bb5e51387d9b4dfa13a89378f5e02.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Cc: david.marchand@redhat.com Date: Tue, 09 Apr 2019 11:58:08 +0100 In-Reply-To: <20190409105539.61460-2-bruce.richardson@intel.com> References: <20190409105539.61460-1-bruce.richardson@intel.com> <20190409105539.61460-2-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/5] build: simplify subdirectory detection for EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409105808.fjR3HkjyJ9xkwZ73sE917bH8eaB-28pRVArcSrQ2VXo@z> On Tue, 2019-04-09 at 11:55 +0100, Bruce Richardson wrote: > Within EAL we had a series of if statements for selecting the EAL > directory > to use. Now that the directory names match those of the OS's they are > for > we can instead just use a generated subdirectory name, shortening the > code. > To avoid strange errors, we still need to check for unsupported OS's, > but > do this check up-front in the config meson.build file. >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > Reviewed-by: David Marchand < > david.marchand@redhat.com > > > --- > config/meson.build | 7 +++++++ > lib/librte_eal/meson.build | 17 ++--------------- > 2 files changed, 9 insertions(+), 15 deletions(-) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi