DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: announce change in crypto raw data vector
@ 2021-08-05  8:05 Hemant Agrawal
  2021-08-05 13:49 ` Zhang, Roy Fan
  2021-08-05 13:55 ` [dpdk-dev] [PATCH v2] " Hemant Agrawal
  0 siblings, 2 replies; 10+ messages in thread
From: Hemant Agrawal @ 2021-08-05  8:05 UTC (permalink / raw)
  To: dev, gakhil
  Cc: anoobj, radu.nicolau, declan.doherty, matan, konstantin.ananyev,
	thomas, roy.fan.zhang, asomalap, ruifeng.wang, ajit.khaparde,
	pablo.de.lara.guarch, fiona.trahe, adwivedi, jianjay.zhou,
	Gagandeep Singh

The current crypto raw data vectors need to be extended to support
out of place processing. It is proposed to add additional desl_sgl
to provide details for destination sgl.
The same is also extended to support rte_security usecases, where
we need total data length to know how much additional memory space
is available in buffer other than data length so that driver/HW
can write expanded size data after encryption.

Signed-off-by: Gagandeep Singh <G.Singh@nxp.com>
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index f4a4d00db2..c19a306c93 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -193,3 +193,15 @@ Deprecation Notices
   reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and other
   information from the crypto/security operation. This field will be used to
   communicate events such as soft expiry with IPsec in lookaside mode.
+
+* cryptodev: The structure ``rte_crypto_sym_vec`` would be updated to add
+  ``dest_sgl`` to support out of place processing. This field will be null for
+  inplace processing. This change is targeted for DPDK 21.11
+
+* cryptodev: The structure ``rte_crypto_vec`` would be updated to add
+  ``tot_len`` to support total buffer length. This is required for security
+  cases like IPsec and PDCP encryption offload to know how much additional
+  memory space is available in buffer other than data length so that driver/HW
+  can write expanded size data after encryption. This change is targeted for
+  DPDK 21.11
+
-- 
2.17.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce change in crypto raw data vector
  2021-08-05  8:05 [dpdk-dev] [PATCH] doc: announce change in crypto raw data vector Hemant Agrawal
@ 2021-08-05 13:49 ` Zhang, Roy Fan
  2021-08-05 13:52   ` Hemant Agrawal
  2021-08-05 13:55 ` [dpdk-dev] [PATCH v2] " Hemant Agrawal
  1 sibling, 1 reply; 10+ messages in thread
From: Zhang, Roy Fan @ 2021-08-05 13:49 UTC (permalink / raw)
  To: Hemant Agrawal, dev, gakhil
  Cc: anoobj, Nicolau, Radu, Doherty, Declan, matan, Ananyev,
	Konstantin, thomas, asomalap, ruifeng.wang, ajit.khaparde,
	De Lara Guarch, Pablo, Trahe, Fiona, adwivedi, jianjay.zhou,
	Gagandeep Singh

Hi Hemant,

> -----Original Message-----
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> Sent: Thursday, August 5, 2021 9:06 AM
> To: dev@dpdk.org; gakhil@marvell.com
> Cc: anoobj@marvell.com; Nicolau, Radu <radu.nicolau@intel.com>; Doherty,
> Declan <declan.doherty@intel.com>; matan@nvidia.com; Ananyev,
> Konstantin <konstantin.ananyev@intel.com>; thomas@monjalon.net; Zhang,
> Roy Fan <roy.fan.zhang@intel.com>; asomalap@amd.com;
> ruifeng.wang@arm.com; ajit.khaparde@broadcom.com; De Lara Guarch,
> Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; adwivedi@marvell.com;
> jianjay.zhou@huawei.com; Gagandeep Singh <G.Singh@nxp.com>
> Subject: [PATCH] doc: announce change in crypto raw data vector
> 
> The current crypto raw data vectors need to be extended to support
> out of place processing. It is proposed to add additional desl_sgl
> to provide details for destination sgl.
> The same is also extended to support rte_security usecases, where
> we need total data length to know how much additional memory space
> is available in buffer other than data length so that driver/HW
> can write expanded size data after encryption.
> 
> Signed-off-by: Gagandeep Singh <G.Singh@nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index f4a4d00db2..c19a306c93 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -193,3 +193,15 @@ Deprecation Notices
>    reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and other
>    information from the crypto/security operation. This field will be used to
>    communicate events such as soft expiry with IPsec in lookaside mode.
> +
> +* cryptodev: The structure ``rte_crypto_sym_vec`` would be updated to
> add
> +  ``dest_sgl`` to support out of place processing. This field will be null for
> +  inplace processing. This change is targeted for DPDK 21.11
> +
> +* cryptodev: The structure ``rte_crypto_vec`` would be updated to add
> +  ``tot_len`` to support total buffer length. This is required for security
> +  cases like IPsec and PDCP encryption offload to know how much additional
> +  memory space is available in buffer other than data length so that
> driver/HW
> +  can write expanded size data after encryption. This change is targeted for
> +  DPDK 21.11
> +
> --
> 2.17.1

To add ``dest_sgl`` to ``rte_crypto_sym_vec`` I suppose it is better to rename ``sgl`` to ``src_sgl`` in this deprecating notice too?

Regards,
Fan

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce change in crypto raw data vector
  2021-08-05 13:49 ` Zhang, Roy Fan
@ 2021-08-05 13:52   ` Hemant Agrawal
  0 siblings, 0 replies; 10+ messages in thread
From: Hemant Agrawal @ 2021-08-05 13:52 UTC (permalink / raw)
  To: Zhang, Roy Fan, dev, gakhil
  Cc: anoobj, Nicolau, Radu, Doherty, Declan, matan, Ananyev,
	Konstantin, thomas, asomalap, ruifeng.wang, ajit.khaparde,
	De Lara Guarch, Pablo, Trahe, Fiona, adwivedi, jianjay.zhou,
	Gagandeep Singh

> > -----Original Message-----
> > From: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Sent: Thursday, August 5, 2021 9:06 AM
> > To: dev@dpdk.org; gakhil@marvell.com
> > Cc: anoobj@marvell.com; Nicolau, Radu <radu.nicolau@intel.com>;
> > Doherty, Declan <declan.doherty@intel.com>; matan@nvidia.com;
> Ananyev,
> > Konstantin <konstantin.ananyev@intel.com>; thomas@monjalon.net;
> Zhang,
> > Roy Fan <roy.fan.zhang@intel.com>; asomalap@amd.com;
> > ruifeng.wang@arm.com; ajit.khaparde@broadcom.com; De Lara Guarch,
> > Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> > <fiona.trahe@intel.com>; adwivedi@marvell.com;
> > jianjay.zhou@huawei.com; Gagandeep Singh <G.Singh@nxp.com>
> > Subject: [PATCH] doc: announce change in crypto raw data vector
> >
> > The current crypto raw data vectors need to be extended to support out
> > of place processing. It is proposed to add additional desl_sgl to
> > provide details for destination sgl.
> > The same is also extended to support rte_security usecases, where we
> > need total data length to know how much additional memory space is
> > available in buffer other than data length so that driver/HW can write
> > expanded size data after encryption.
> >
> > Signed-off-by: Gagandeep Singh <G.Singh@nxp.com>
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index f4a4d00db2..c19a306c93 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -193,3 +193,15 @@ Deprecation Notices
> >    reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and
> other
> >    information from the crypto/security operation. This field will be used to
> >    communicate events such as soft expiry with IPsec in lookaside mode.
> > +
> > +* cryptodev: The structure ``rte_crypto_sym_vec`` would be updated to
> > add
> > +  ``dest_sgl`` to support out of place processing. This field will be
> > + null for  inplace processing. This change is targeted for DPDK 21.11
> > +
> > +* cryptodev: The structure ``rte_crypto_vec`` would be updated to add
> > +  ``tot_len`` to support total buffer length. This is required for
> > +security
> > +  cases like IPsec and PDCP encryption offload to know how much
> > +additional
> > +  memory space is available in buffer other than data length so that
> > driver/HW
> > +  can write expanded size data after encryption. This change is
> > + targeted for  DPDK 21.11
> > +
> > --
> > 2.17.1
> 
> To add ``dest_sgl`` to ``rte_crypto_sym_vec`` I suppose it is better to rename
> ``sgl`` to ``src_sgl`` in this deprecating notice too?
[Hemant] I was just trying to minimize the changes. But it can be done. 

> 
> Regards,
> Fan

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-dev] [PATCH v2] doc: announce change in crypto raw data vector
  2021-08-05  8:05 [dpdk-dev] [PATCH] doc: announce change in crypto raw data vector Hemant Agrawal
  2021-08-05 13:49 ` Zhang, Roy Fan
@ 2021-08-05 13:55 ` Hemant Agrawal
  2021-08-05 14:04   ` [dpdk-dev] [EXT] " Akhil Goyal
  2021-08-06  6:35   ` [dpdk-dev] " Hemant Agrawal
  1 sibling, 2 replies; 10+ messages in thread
From: Hemant Agrawal @ 2021-08-05 13:55 UTC (permalink / raw)
  To: dev, gakhil
  Cc: anoobj, radu.nicolau, declan.doherty, matan, konstantin.ananyev,
	thomas, roy.fan.zhang, asomalap, ruifeng.wang, ajit.khaparde,
	pablo.de.lara.guarch, fiona.trahe, adwivedi, jianjay.zhou,
	Gagandeep Singh

The current crypto raw data vectors need to be extended to support
out of place processing. It is proposed to add additional desl_sgl
to provide details for destination sgl.
The same is also extended to support rte_security usecases, where
we need total data length to know how much additional memory space
is available in buffer other than data length so that driver/HW
can write expanded size data after encryption.

Signed-off-by: Gagandeep Singh <G.Singh@nxp.com>
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index f4a4d00db2..c19a306c93 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -193,3 +193,15 @@ Deprecation Notices
   reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and other
   information from the crypto/security operation. This field will be used to
   communicate events such as soft expiry with IPsec in lookaside mode.
+
+* cryptodev: The structure ``rte_crypto_sym_vec`` would be updated to add
+  ``dest_sgl`` to support out of place processing. This field will be null for
+  inplace processing. This change is targeted for DPDK 21.11
+
+* cryptodev: The structure ``rte_crypto_vec`` would be updated to add
+  ``tot_len`` to support total buffer length. This is required for security
+  cases like IPsec and PDCP encryption offload to know how much additional
+  memory space is available in buffer other than data length so that driver/HW
+  can write expanded size data after encryption. This change is targeted for
+  DPDK 21.11
+
-- 
2.17.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH v2] doc: announce change in crypto raw data vector
  2021-08-05 13:55 ` [dpdk-dev] [PATCH v2] " Hemant Agrawal
@ 2021-08-05 14:04   ` Akhil Goyal
  2021-08-07 15:17     ` Thomas Monjalon
  2021-08-06  6:35   ` [dpdk-dev] " Hemant Agrawal
  1 sibling, 1 reply; 10+ messages in thread
From: Akhil Goyal @ 2021-08-05 14:04 UTC (permalink / raw)
  To: Hemant Agrawal, dev
  Cc: Anoob Joseph, radu.nicolau, declan.doherty, matan,
	konstantin.ananyev, thomas, roy.fan.zhang, asomalap,
	ruifeng.wang, ajit.khaparde, pablo.de.lara.guarch, fiona.trahe,
	Ankur Dwivedi, jianjay.zhou, Gagandeep Singh

> The current crypto raw data vectors need to be extended to support
> out of place processing. It is proposed to add additional desl_sgl
> to provide details for destination sgl.
> The same is also extended to support rte_security usecases, where
> we need total data length to know how much additional memory space
> is available in buffer other than data length so that driver/HW
> can write expanded size data after encryption.
> 
> Signed-off-by: Gagandeep Singh <G.Singh@nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index f4a4d00db2..c19a306c93 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -193,3 +193,15 @@ Deprecation Notices
>    reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and other
>    information from the crypto/security operation. This field will be used to
>    communicate events such as soft expiry with IPsec in lookaside mode.
> +
> +* cryptodev: The structure ``rte_crypto_sym_vec`` would be updated to add
> +  ``dest_sgl`` to support out of place processing. This field will be null for
> +  inplace processing. This change is targeted for DPDK 21.11
> +
> +* cryptodev: The structure ``rte_crypto_vec`` would be updated to add
> +  ``tot_len`` to support total buffer length. This is required for security
> +  cases like IPsec and PDCP encryption offload to know how much additional
> +  memory space is available in buffer other than data length so that
> driver/HW
> +  can write expanded size data after encryption. This change is targeted for
> +  DPDK 21.11
> +
Acked-by: Akhil Goyal <gakhil@marvell.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: announce change in crypto raw data vector
  2021-08-05 13:55 ` [dpdk-dev] [PATCH v2] " Hemant Agrawal
  2021-08-05 14:04   ` [dpdk-dev] [EXT] " Akhil Goyal
@ 2021-08-06  6:35   ` Hemant Agrawal
  2021-08-06 10:04     ` Ananyev, Konstantin
  1 sibling, 1 reply; 10+ messages in thread
From: Hemant Agrawal @ 2021-08-06  6:35 UTC (permalink / raw)
  To: Hemant Agrawal, dev, gakhil
  Cc: anoobj, radu.nicolau, declan.doherty, matan, konstantin.ananyev,
	thomas, roy.fan.zhang, asomalap, ruifeng.wang, ajit.khaparde,
	pablo.de.lara.guarch, fiona.trahe, adwivedi, jianjay.zhou,
	Gagandeep Singh

ping for review.


On 8/5/2021 7:25 PM, Hemant Agrawal wrote:
> The current crypto raw data vectors need to be extended to support
> out of place processing. It is proposed to add additional desl_sgl
> to provide details for destination sgl.
> The same is also extended to support rte_security usecases, where
> we need total data length to know how much additional memory space
> is available in buffer other than data length so that driver/HW
> can write expanded size data after encryption.
>
> Signed-off-by: Gagandeep Singh <G.Singh@nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>   doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index f4a4d00db2..c19a306c93 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -193,3 +193,15 @@ Deprecation Notices
>     reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and other
>     information from the crypto/security operation. This field will be used to
>     communicate events such as soft expiry with IPsec in lookaside mode.
> +
> +* cryptodev: The structure ``rte_crypto_sym_vec`` would be updated to add
> +  ``dest_sgl`` to support out of place processing. This field will be null for
> +  inplace processing. This change is targeted for DPDK 21.11
> +
> +* cryptodev: The structure ``rte_crypto_vec`` would be updated to add
> +  ``tot_len`` to support total buffer length. This is required for security
> +  cases like IPsec and PDCP encryption offload to know how much additional
> +  memory space is available in buffer other than data length so that driver/HW
> +  can write expanded size data after encryption. This change is targeted for
> +  DPDK 21.11
> +

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: announce change in crypto raw data vector
  2021-08-06  6:35   ` [dpdk-dev] " Hemant Agrawal
@ 2021-08-06 10:04     ` Ananyev, Konstantin
  2021-08-06 10:25       ` Hemant Agrawal
  0 siblings, 1 reply; 10+ messages in thread
From: Ananyev, Konstantin @ 2021-08-06 10:04 UTC (permalink / raw)
  To: hemant.agrawal, dev, gakhil
  Cc: anoobj, Nicolau, Radu, Doherty, Declan, matan, thomas, Zhang,
	Roy Fan, asomalap, ruifeng.wang, ajit.khaparde, De Lara Guarch,
	Pablo, Trahe, Fiona, adwivedi, jianjay.zhou, Gagandeep Singh

Hi Hemant,

> > The current crypto raw data vectors need to be extended to support
> > out of place processing. It is proposed to add additional desl_sgl
> > to provide details for destination sgl.
> > The same is also extended to support rte_security usecases, where
> > we need total data length to know how much additional memory space
> > is available in buffer other than data length so that driver/HW
> > can write expanded size data after encryption.
> >
> > Signed-off-by: Gagandeep Singh <G.Singh@nxp.com>
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> >   doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index f4a4d00db2..c19a306c93 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -193,3 +193,15 @@ Deprecation Notices
> >     reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and other
> >     information from the crypto/security operation. This field will be used to
> >     communicate events such as soft expiry with IPsec in lookaside mode.
> > +
> > +* cryptodev: The structure ``rte_crypto_sym_vec`` would be updated to add
> > +  ``dest_sgl`` to support out of place processing. This field will be null for
> > +  inplace processing. This change is targeted for DPDK 21.11

Seems ok to me, just one question:
would layout (number of elems in SG, length of each elem)
for sgl and dest_sgl always be identical? 

> > +
> > +* cryptodev: The structure ``rte_crypto_vec`` would be updated to add
> > +  ``tot_len`` to support total buffer length. This is required for security
> > +  cases like IPsec and PDCP encryption offload to know how much additional
> > +  memory space is available in buffer other than data length so that driver/HW
> > +  can write expanded size data after encryption. This change is targeted for
> > +  DPDK 21.11
> > +

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: announce change in crypto raw data vector
  2021-08-06 10:04     ` Ananyev, Konstantin
@ 2021-08-06 10:25       ` Hemant Agrawal
  2021-08-06 10:38         ` Ananyev, Konstantin
  0 siblings, 1 reply; 10+ messages in thread
From: Hemant Agrawal @ 2021-08-06 10:25 UTC (permalink / raw)
  To: Ananyev, Konstantin, hemant.agrawal, dev, gakhil
  Cc: anoobj, Nicolau, Radu, Doherty, Declan, matan, thomas, Zhang,
	Roy Fan, asomalap, ruifeng.wang, ajit.khaparde, De Lara Guarch,
	Pablo, Trahe, Fiona, adwivedi, jianjay.zhou, Gagandeep Singh

Hi Konstantin

On 8/6/2021 3:34 PM, Ananyev, Konstantin wrote:
> Hi Hemant,
>
>>> The current crypto raw data vectors need to be extended to support
>>> out of place processing. It is proposed to add additional desl_sgl
>>> to provide details for destination sgl.
>>> The same is also extended to support rte_security usecases, where
>>> we need total data length to know how much additional memory space
>>> is available in buffer other than data length so that driver/HW
>>> can write expanded size data after encryption.
>>>
>>> Signed-off-by: Gagandeep Singh <G.Singh@nxp.com>
>>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>>> ---
>>>    doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++
>>>    1 file changed, 12 insertions(+)
>>>
>>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>>> index f4a4d00db2..c19a306c93 100644
>>> --- a/doc/guides/rel_notes/deprecation.rst
>>> +++ b/doc/guides/rel_notes/deprecation.rst
>>> @@ -193,3 +193,15 @@ Deprecation Notices
>>>      reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and other
>>>      information from the crypto/security operation. This field will be used to
>>>      communicate events such as soft expiry with IPsec in lookaside mode.
>>> +
>>> +* cryptodev: The structure ``rte_crypto_sym_vec`` would be updated to add
>>> +  ``dest_sgl`` to support out of place processing. This field will be null for
>>> +  inplace processing. This change is targeted for DPDK 21.11
> Seems ok to me, just one question:
> would layout (number of elems in SG, length of each elem)
> for sgl and dest_sgl always be identical?

No, there shall not be any such restriction. Both source and destination 
can be different buffer  with their own number of elem (if any) and 
length of each elem.

>>> +
>>> +* cryptodev: The structure ``rte_crypto_vec`` would be updated to add
>>> +  ``tot_len`` to support total buffer length. This is required for security
>>> +  cases like IPsec and PDCP encryption offload to know how much additional
>>> +  memory space is available in buffer other than data length so that driver/HW
>>> +  can write expanded size data after encryption. This change is targeted for
>>> +  DPDK 21.11
>>> +
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: announce change in crypto raw data vector
  2021-08-06 10:25       ` Hemant Agrawal
@ 2021-08-06 10:38         ` Ananyev, Konstantin
  0 siblings, 0 replies; 10+ messages in thread
From: Ananyev, Konstantin @ 2021-08-06 10:38 UTC (permalink / raw)
  To: hemant.agrawal, dev, gakhil
  Cc: anoobj, Nicolau, Radu, Doherty, Declan, matan, thomas, Zhang,
	Roy Fan, asomalap, ruifeng.wang, ajit.khaparde, De Lara Guarch,
	Pablo, Trahe, Fiona, adwivedi, jianjay.zhou, Gagandeep Singh



> >>> The current crypto raw data vectors need to be extended to support
> >>> out of place processing. It is proposed to add additional desl_sgl
> >>> to provide details for destination sgl.
> >>> The same is also extended to support rte_security usecases, where
> >>> we need total data length to know how much additional memory space
> >>> is available in buffer other than data length so that driver/HW
> >>> can write expanded size data after encryption.
> >>>
> >>> Signed-off-by: Gagandeep Singh <G.Singh@nxp.com>
> >>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> >>> ---
> >>>    doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++
> >>>    1 file changed, 12 insertions(+)
> >>>
> >>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> >>> index f4a4d00db2..c19a306c93 100644
> >>> --- a/doc/guides/rel_notes/deprecation.rst
> >>> +++ b/doc/guides/rel_notes/deprecation.rst
> >>> @@ -193,3 +193,15 @@ Deprecation Notices
> >>>      reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and other
> >>>      information from the crypto/security operation. This field will be used to
> >>>      communicate events such as soft expiry with IPsec in lookaside mode.
> >>> +
> >>> +* cryptodev: The structure ``rte_crypto_sym_vec`` would be updated to add
> >>> +  ``dest_sgl`` to support out of place processing. This field will be null for
> >>> +  inplace processing. This change is targeted for DPDK 21.11
> > Seems ok to me, just one question:
> > would layout (number of elems in SG, length of each elem)
> > for sgl and dest_sgl always be identical?
> 
> No, there shall not be any such restriction. Both source and destination
> can be different buffer  with their own number of elem (if any) and
> length of each elem.

Ok, thanks for clarification.

> 
> >>> +
> >>> +* cryptodev: The structure ``rte_crypto_vec`` would be updated to add
> >>> +  ``tot_len`` to support total buffer length. This is required for security
> >>> +  cases like IPsec and PDCP encryption offload to know how much additional
> >>> +  memory space is available in buffer other than data length so that driver/HW
> >>> +  can write expanded size data after encryption. This change is targeted for
> >>> +  DPDK 21.11
> >>> +
> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> >

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH v2] doc: announce change in crypto raw data vector
  2021-08-05 14:04   ` [dpdk-dev] [EXT] " Akhil Goyal
@ 2021-08-07 15:17     ` Thomas Monjalon
  0 siblings, 0 replies; 10+ messages in thread
From: Thomas Monjalon @ 2021-08-07 15:17 UTC (permalink / raw)
  To: Hemant Agrawal
  Cc: dev, Anoob Joseph, radu.nicolau, declan.doherty, matan,
	konstantin.ananyev, roy.fan.zhang, asomalap, ruifeng.wang,
	ajit.khaparde, pablo.de.lara.guarch, fiona.trahe, Ankur Dwivedi,
	jianjay.zhou, Gagandeep Singh, Akhil Goyal

05/08/2021 16:04, Akhil Goyal:
> > The current crypto raw data vectors need to be extended to support
> > out of place processing. It is proposed to add additional desl_sgl
> > to provide details for destination sgl.
> > The same is also extended to support rte_security usecases, where
> > we need total data length to know how much additional memory space
> > is available in buffer other than data length so that driver/HW
> > can write expanded size data after encryption.
> > 
> > Signed-off-by: Gagandeep Singh <G.Singh@nxp.com>
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> > +* cryptodev: The structure ``rte_crypto_sym_vec`` would be updated to add
> > +  ``dest_sgl`` to support out of place processing. This field will be null for
> > +  inplace processing. This change is targeted for DPDK 21.11
> > +
> > +* cryptodev: The structure ``rte_crypto_vec`` would be updated to add
> > +  ``tot_len`` to support total buffer length. This is required for security
> > +  cases like IPsec and PDCP encryption offload to know how much additional
> > +  memory space is available in buffer other than data length so that
> > driver/HW
> > +  can write expanded size data after encryption. This change is targeted for
> > +  DPDK 21.11
> > +
> Acked-by: Akhil Goyal <gakhil@marvell.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied, thanks.



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-08-07 15:17 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-05  8:05 [dpdk-dev] [PATCH] doc: announce change in crypto raw data vector Hemant Agrawal
2021-08-05 13:49 ` Zhang, Roy Fan
2021-08-05 13:52   ` Hemant Agrawal
2021-08-05 13:55 ` [dpdk-dev] [PATCH v2] " Hemant Agrawal
2021-08-05 14:04   ` [dpdk-dev] [EXT] " Akhil Goyal
2021-08-07 15:17     ` Thomas Monjalon
2021-08-06  6:35   ` [dpdk-dev] " Hemant Agrawal
2021-08-06 10:04     ` Ananyev, Konstantin
2021-08-06 10:25       ` Hemant Agrawal
2021-08-06 10:38         ` Ananyev, Konstantin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).