From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13F0AA04B6; Mon, 12 Oct 2020 11:57:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DFC781D6A6; Mon, 12 Oct 2020 11:57:29 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 314781D66C for ; Mon, 12 Oct 2020 11:57:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602496645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rHWgCkm4zMalTTySUv2HAdeWD8GgSBsROPmtUCHYHUU=; b=Ka+vKfBU7brN8OAazlOWZ2sCdMFo1n7K6K01lOo9BRvu6bC0JFVF9Vpuz/Xqz0XW2dgVTK GRIneM5qxk59uqHtKLaiGJuHLJzoy3t319yIz8B50ekBO7m/rnS6G18AZzM/gzsNKiR/Ki zr2DVmWiD12Kl2Fl96Zlf1Q8/k0m8gM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-80-SVaaW0DFMiS7q7tK25k_WQ-1; Mon, 12 Oct 2020 05:57:21 -0400 X-MC-Unique: SVaaW0DFMiS7q7tK25k_WQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A974A10066FB; Mon, 12 Oct 2020 09:57:20 +0000 (UTC) Received: from [10.36.110.17] (unknown [10.36.110.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 260585C225; Mon, 12 Oct 2020 09:57:18 +0000 (UTC) To: "Liu, Yong" , "Xia, Chenbo" , "Wang, Zhihong" Cc: "dev@dpdk.org" References: <20200819032414.51430-2-yong.liu@intel.com> <20201009081410.63944-1-yong.liu@intel.com> <7d902e14-1e4f-31d9-c7f6-7a57e00186ab@redhat.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <7955df3a-d113-bd37-fa6f-77adac8e62c9@redhat.com> Date: Mon, 12 Oct 2020 11:57:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 0/5] vhost add vectorized data path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Marvin, On 10/12/20 11:10 AM, Liu, Yong wrote: > > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Monday, October 12, 2020 4:22 PM >> To: Liu, Yong ; Xia, Chenbo ; >> Wang, Zhihong >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v3 0/5] vhost add vectorized data path >> >> Hi Marvin, >> >> On 10/9/20 10:14 AM, Marvin Liu wrote: >>> Packed ring format is imported since virtio spec 1.1. All descriptors >>> are compacted into one single ring when packed ring format is on. It is >>> straight forward that ring operations can be accelerated by utilizing >>> SIMD instructions. >>> >>> This patch set will introduce vectorized data path in vhost library. If >>> vectorized option is on, operations like descs check, descs writeback, >>> address translation will be accelerated by SIMD instructions. On skylake >>> server, it can bring 6% performance gain in loopback case and around 4% >>> performance gain in PvP case. >> >> IMHO, 4% gain on PVP is not a significant gain if we compare to the >> added complexity. Moreover, I guess this is 4% gain with testpmd-based >> PVP? If this is the case it may be even lower with OVS-DPDK PVP >> benchmark, I will try to do a benchmark this week. >> > > Maxime, > I have observed around 3% gain with OVS-DPDK in first version. But the number is not reliable as datapath has been changed. > I will try again after fixed OVS integration issue with latest dpdk. Thanks for the information. Also, wouldn't using AVX512 lower the CPU frequency? If so, could it have an impact on the workload running on the other CPUs? Thanks, Maxime >> Thanks, >> Maxime >> >>> Vhost application can choose whether using vectorized acceleration, just >>> like external buffer feature. If platform or ring format not support >>> vectorized function, vhost will fallback to use default batch function. >>> There will be no impact in current data path. >>> >>> v3: >>> * rename vectorized datapath file >>> * eliminate the impact when avx512 disabled >>> * dynamically allocate memory regions structure >>> * remove unlikely hint for in_order >>> >>> v2: >>> * add vIOMMU support >>> * add dequeue offloading >>> * rebase code >>> >>> Marvin Liu (5): >>> vhost: add vectorized data path >>> vhost: reuse packed ring functions >>> vhost: prepare memory regions addresses >>> vhost: add packed ring vectorized dequeue >>> vhost: add packed ring vectorized enqueue >>> >>> doc/guides/nics/vhost.rst | 5 + >>> doc/guides/prog_guide/vhost_lib.rst | 12 + >>> drivers/net/vhost/rte_eth_vhost.c | 17 +- >>> lib/librte_vhost/meson.build | 16 ++ >>> lib/librte_vhost/rte_vhost.h | 1 + >>> lib/librte_vhost/socket.c | 5 + >>> lib/librte_vhost/vhost.c | 11 + >>> lib/librte_vhost/vhost.h | 239 +++++++++++++++++++ >>> lib/librte_vhost/vhost_user.c | 26 +++ >>> lib/librte_vhost/virtio_net.c | 258 ++++----------------- >>> lib/librte_vhost/virtio_net_avx.c | 344 ++++++++++++++++++++++++++++ >>> 11 files changed, 718 insertions(+), 216 deletions(-) >>> create mode 100644 lib/librte_vhost/virtio_net_avx.c >>> >