From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 438E2A0093; Mon, 7 Mar 2022 23:30:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4A7841238; Mon, 7 Mar 2022 23:30:08 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 658244122E; Mon, 7 Mar 2022 23:30:07 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id BBC095C0348; Mon, 7 Mar 2022 17:30:06 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 07 Mar 2022 17:30:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=ly+iZz+dYMSbOv AxoyISCshFvwogomA6AGL+T5f7we4=; b=okfYoDinjZB8Sa8Psl08c5mlnC1o1F sGcBHraLH8bQfgeRLhsN3Ju8nSjlpVPH1KtiVuoeZtkOwM3ku2RaIpxXLedwewOY zYAz/QC9Yq75A2Raoudufq952G1buxxCvXvxWek0WBKbyl35a6Z2xjoEtEpMabQA QKJY7A865cm59zt/LfaBTIZ5seyGUaFYjxoqGfUBMVGkQKxyaPSp3PUfZIG6Cxlz Ngdz87FQirpcNaOdzUT/HDUgjEHcMneMQw2XVXHMLLCbEDx+guQt+X0Svg+bCWsW t3H9u7DtuAzW7ePWuHTpb33uQ3sfln4aRU8N2AmxqIrHEplqWVUODV+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ly+iZz+dYMSbOvAxoyISCshFvwogomA6AGL+T5f7w e4=; b=Upme77fd24xDopk/qhWLeK6mkGjnDNQEUz9Pfpya/gB2ampKcika7Hw56 y49zxbrqxIef8M/T19LmqpVJVnBRaVnsaSlJ8cjW+MQdulP3nU73UlxONmW1MfMq 8EPFIm9gbpf+17/cAt+0uPmAIH2E5Vb7RxfIj4+w2jJezML77zMvSx7CVxf6M6t+ Yw3YNr9bqc/yQwgAHoeJpBZrXNn2vcXCtqk/qmIcjGDIyditcObanorye9rEwSKm SNSEbcIeHkKk7epu1avG9cm88SAAW8QolQkzIgxCRq4o/Zprf3MlSWuLs7OblA8g vxa2g8tXMESFH8Oe811RFQPoVJyQg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddugedgudeiudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Mar 2022 17:30:05 -0500 (EST) From: Thomas Monjalon To: tianfei.zhang@intel.com, Wei Huang Cc: dev@dpdk.org, rosen.xu@intel.com, qi.z.zhang@intel.com, nipun.gupta@nxp.com, hemant.agrawal@nxp.com, stable@dpdk.org, ferruh.yigit@intel.com Subject: Re: [PATCH v1] raw/ifpga: fix monitor thread issues Date: Mon, 07 Mar 2022 23:30:04 +0100 Message-ID: <7966659.31tnzDBltd@thomas> In-Reply-To: <20220301084703.820509-1-wei.huang@intel.com> References: <20220301084703.820509-1-wei.huang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 01/03/2022 09:47, Wei Huang: > Monitor thread handles graceful shutdown according to the value of > specific sensors in device, two issues are found below. > 1. Thread is not created when card is probed. > 2. Thread is canceled without checking presence of other cards. > To fix them, thread is created in pci device probe function, a reference > count is checked before canceling the thread. > > Fixes: 9c006c45 ("raw/ifpga: scan PCIe BDF device tree") > Cc: stable@dpdk.org > > Signed-off-by: Wei Huang > Acked-by: Tianfei Zhang In general, it is better to have 2 separate patches for 2 different issues. Applied