From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0055.outbound.protection.outlook.com [104.47.41.55]) by dpdk.org (Postfix) with ESMTP id 8B7EF10BC4 for ; Wed, 21 Dec 2016 10:57:08 +0100 (CET) Received: from DM5PR03CA0005.namprd03.prod.outlook.com (10.175.104.15) by CY1PR0301MB0745.namprd03.prod.outlook.com (10.160.159.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Wed, 21 Dec 2016 09:57:07 +0000 Received: from BL2FFO11FD008.protection.gbl (2a01:111:f400:7c09::193) by DM5PR03CA0005.outlook.office365.com (2603:10b6:3:118::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14 via Frontend Transport; Wed, 21 Dec 2016 09:57:07 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; infradead.org; dkim=none (message not signed) header.d=none;infradead.org; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11FD008.mail.protection.outlook.com (10.173.161.4) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.789.10 via Frontend Transport; Wed, 21 Dec 2016 09:57:07 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id uBL9v3MX031406; Wed, 21 Dec 2016 02:57:04 -0700 To: Jan Blunck References: <1482232315-21626-1-git-send-email-jblunck@infradead.org> CC: , , Thomas Monjalon From: Shreyansh Jain Message-ID: <79676396-e867-2512-93c5-17fca4604ddf@nxp.com> Date: Wed, 21 Dec 2016 15:30:42 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1482232315-21626-1-git-send-email-jblunck@infradead.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131267878274596769; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(39400400002)(39850400002)(39410400002)(39840400002)(39450400003)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(199003)(377454003)(24454002)(189002)(77096006)(8936002)(92566002)(356003)(104016004)(69596002)(81166006)(81156014)(2950100002)(86362001)(65826007)(83506001)(6916009)(38730400001)(110136003)(97736004)(50466002)(47776003)(6666003)(189998001)(65806001)(65956001)(305945005)(76176999)(50986999)(8676002)(64126003)(68736007)(4326007)(229853002)(2906002)(31686004)(54356999)(626004)(85426001)(5660300001)(36756003)(4001350100001)(31696002)(230700001)(23746002)(105606002)(106466001)(33646002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB0745; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD008; 1:znF0XP4me/CMMnC5m7KF2quWBHQdh4Wv9OBrp9ClPgEj1SCoDfBr5/F+5oJ3RTg+ubwW7LJz7izomeyUnl1tvH3DREr422B86LRrrsDGmV7XqqsgVEK13BpuEAoeWGB+ZhENsa/0sJ3lx4aVyw/B3soztuX2dm89axPAdbzehG2/T8QsfcZgGoGzFLxB3Re6q7NanB8rJ6ilUp0BU4OYnPwlg37cPV9BrNTuN5Sopvfrz3iB6s98/kUpR8PvU066tTS4mchSz0LdlI5shbfoGM0Jl+S/EzNRxWyRr5zDrlq3ozuwLuKYNMvY1y+IBaOs1o9v7IL8vcZepw6N3j42l41krhYrenFAHeXeJwoIIhRCulJL6IG77cDLtORP7XOkUNJab0tyy1lHGjII4xF77MrH1ZxxPLJJo8mbwADsyZ366nKBsfJdaFERu/HW2U92GTePC+iO9JXQseRpJ88Q0DEJx4ci6rTjVJJ5F7Uih2RquTW2gMIOHCi3payKMXAP0Alp3UGd2UrI0LDNGPkLcsHLCLysi0Id2WwMUEespLvc54dGyYYLzkZIiiL5sB4y/FEfu9QbdOLsWJrAbL7YRzIJ3WWap/EgydjA+rerrsU= X-MS-Office365-Filtering-Correlation-Id: 8d7b62a6-8054-4638-9e40-08d42987b96e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:CY1PR0301MB0745; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0745; 3:noo+CHedrSKx8wH2uWj03lJrC/haLacMNTfLZPpoLrf4/SbKaSwF8/RWp205pS0O+ybSE52J+Ouw4o6zuhxCMV/7b9dNwaghvfSZ1kfLThs8pl4SMQ2ZCoYXc7NbEt0OYNB51G230oI42MWnnJDMm4MXC3IVT3pFKxg+yOv2E6H9v7CC+hEOim5EPtWfvuqDBWZ5RST9VB3Vw5OHg9AqALDBqnWjP/DWRnbmcyWD3VaKVg1wxoSPav03QQyIvgLMhawygODedpQMqQqcnDInpuacijaRyme6fUttNbtHDdT5LJV0sPAELuMG8AQIJFQgb/QiLir5nIka4A+XgsC+CceOlw3xeMsZnrZ6JYoSYaJoPfaMpS0ustqnak9Oci6M; 25:c/KESz9WdLovkczoQh3D6E6+FbuIY81NX0IrSqKL6JR9dGBBNuvR8EBsMNKvjOkClAXxVr+LIz1l2Xl1nbtB9n9Rb0/Wf96mZy7upgQuFXkiRQzCwoq51wNIbpWXwW9ZifHTmkQB0V0SpBN1iuF+ONsZsLX1Om12PHHa5L+O2rxXIMwTvBjKc/+3sReDyTqf5xvk2pp/VU67P+ZCY+rTgn/W2kJi7hs4HXImyqHVjgC6MO264Iq+Muv70JYnnG9oM+gN3Vehu4HxSxW6AlHEoKyzhpeChr0zSpIx2R/UrWfZ0S3usX+x84cAsZSOn8z3YpuXOCNdY0yal/3aZr9er407EQGl4Emlv1vK26XGEzsmSoeuK88tswRiGeaNl+S1XRPWHMuJFyVOpFFBu1pPxziU0SMAJuYBbTIMpJpQLBEkuhJH6AdNurYBJx5O3ivlAQCWXfdd0LeIv1baPXRUOg== X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0745; 31:tRbvf99GqKY3Pfua1DWe0yYJmRMMPEVdNK690Uq+Cu4cNYrCLIBVMABMeQTj0VYIMxyEa6HIYXyZELCDS8mXCjL6XFncFaoKpOlZtuBwT3CpvQ0xPhqXTIq1RQFU7e64DCxnBrE4uYTvgxXdB0IKAWc6Rly66ONjT1NTUYu79pcilbOd1Td2nKr7iQFwOZGMRvhN24fgQAd/WYmSLF+zXLXNoXCUgz274whZyX5TU+W0/X41MIpThGNwS05KvWyO4Jcj4Hsey1Jgqrzvggtm3Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(8121501046)(13018025)(5005006)(13015025)(13024025)(13023025)(13017025)(3002001)(10201501046)(6055026)(6096035)(20161123561025)(20161123563025)(20161123559025)(20161123556025)(20161123565025); SRVR:CY1PR0301MB0745; BCL:0; PCL:0; RULEID:(400006); SRVR:CY1PR0301MB0745; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0745; 4:NbVT43iD8X/652oVCXGzSxe7L8JA8KxWv6pPkVTQpE8UEvZHhVfbNbshCT9gHuZJ3oEJPh/VFAomuvviYf9XDP8W2IEBsW5OdKUGfFiGsT+ylJHk+n9234EVyyXNYfgK+sUm6AtUDFS5DFoYoSSiy6yzX/SVgnec58RBjQJI0eVyt2+l/DYCCynH/ec6B5M6h32h3o6XxV+uLfPGhn2WTfwefhWrmM1TDwprpmfQg1A6oJXfTPEl11xwiKeL01c8yCk5AYhwd+mGjFKN6OJripYO2ygI0LHUKuVioZk+iujh2iVWEr5KLqfSccJ5/sBVNhV0t+bjud3UZ8Z7EHxzCrAZ6SLOlvuhcpGgtQ1+aR3JBlWDW/Stwnrsv4oErgXeM+nYyLGFb43MEiZLrD5YufqeV+jXSjl3GtzhY/rdcgo0thCtSwkOZOPLJ7YAzcB8WNqaQG5Y0XsxUNCEl9WQI88NO+PLPmhXAiHjDl6tXPNrahfc/6bKfwYteRnnxulVI/2lWZhUaWv3S1Cxwxd3crlVRSUiiXm7iYKUnLP4rFSVUxvXwxtwDFgNnf2RhJQAXqBfsprog8nffF2/2ggJp/BINigWdxzHl7puLKTP968zwBTLX/7GwlePEq6nZRn1ffF42dM8EDw/iH96b1VMc2NgEX2V9WWBfFY0arU2ypdRkx8cY8bQOcQ+4hu3zfI6 X-Forefront-PRVS: 01630974C0 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY1PR0301MB0745; 23:DZlVp90MmVTivBL4o/CgweYw2xG5i7FgQKo?= =?Windows-1252?Q?XiMrBBmthDJ0SIGBX8xFTxkcl72aOmljOd4Ys0RUUft+WzqltG3nV1zn?= =?Windows-1252?Q?8JDOHB++mH5bzeAaVdlojgKfHGutQ5GRbPRua2LKFWwmDEQ91gxneZCI?= =?Windows-1252?Q?IqLJh7zCYsG5tYKleOcb8Ap0hQBAUUFWopICEqpTrUWUfBjcjhCIDfd9?= =?Windows-1252?Q?0UPO4OTxmqBvqWWaCCu7KuXUTAJYtdUg3GX++nK89YGm2domF0GaqWAX?= =?Windows-1252?Q?rO0kMA9h0n40kru+zM5K2ZiPQUo+x7aMEK4mShkHC7N+a0k4W2fxgyx5?= =?Windows-1252?Q?Jy3H9Iec+o9OqyPFkZUETpx/TxGth5a6HbjP8bIT3M+8j/FVyRiILdG6?= =?Windows-1252?Q?yCOr2MX0QMA/arymAxoG+buovCJFEvrvDJpAdS3dQk78+hDJBqAHooUU?= =?Windows-1252?Q?p59r0detkIeixrZyhcms5JpUopLi2MIP5dRwgpqySeD13eIlUCu+KPU9?= =?Windows-1252?Q?H7R1Az+73zsNaMgFWAxg3ebr48jVE8W6S0h/g+hAxSauWVTZekZGwrRj?= =?Windows-1252?Q?40HVuWGt7V1J/ovh6vTDw9M9ymG54uVdvKHl0R9lndf767/LkomoseH6?= =?Windows-1252?Q?ikC1dvMoSFJ4DQ7QTA5qdkwo8ytE9XmO0KWn3ftI4aMY/fHNIpDOKLgs?= =?Windows-1252?Q?ym2nxCXZBuPly7idtKsmrTCBu1PUHFlFU/fDhiokZ2v/lWgti/aJlamA?= =?Windows-1252?Q?gC6Ag8KS2+WBQbHgRxOEMl5w5N3EURJSeaPtwmtNtilXGk1vyi4BpUVd?= =?Windows-1252?Q?mOo9RLf7e3RtvJi3gWXun6zj/5e39SDrMOA1tTVKJlx5HVSJRNLDCYd7?= =?Windows-1252?Q?A+Ea/TqDYxQA0EiF/XRh/vDeuaBh6zCouJckYnZ/nuS9VDACsdjAS1ma?= =?Windows-1252?Q?wL5N5UW+lyUoeeeQpmxcDWIkzXzhaAn38AG74f0F2DiG84Plh/xLzyw/?= =?Windows-1252?Q?6/lM28KcBxpKWeCmCuKIDpdm8RpmnqsVn4FIgAHbG27+58a3X6t+cr8M?= =?Windows-1252?Q?FiwH4PGG5mvfwogyj9LKWsQVIrrLD7pYNVzcxFqOkOrYW1owwWdYMByR?= =?Windows-1252?Q?SFEcy0HcNuhjS8lDBNZu77GvExROdv26Pmins223tSacPqUvg5JRPcm5?= =?Windows-1252?Q?AVvH+Hf/EWWuw+vVW/R6y4YAAK9a6s0Jo/VkxRpR4WKmqgpvi0frwaRW?= =?Windows-1252?Q?6fwcR430G8OQxkBCt60z1Iqy5Ou4bT5RyvuLSx+RdmX6xlzVtuU2sObD?= =?Windows-1252?Q?6OjbCquwTa1vB5jhOXmkBUc9lC2KaDNTXM4Bxa24cPrrXWWBrSLCIvrz?= =?Windows-1252?Q?X01gwrQxAQBRdRjzis8+Ivnpa0bEQg/JJ4eGvg1oQbyOosFBFjT4W4Pf?= =?Windows-1252?Q?4eE7xccX2upwWd6mcaUdBz5S/6ntL+tPRw+qV6nkjhyjTNtK0ath8MIN?= =?Windows-1252?Q?gVJBMDMFQovooJnf+Ci3z26Y2W9+HvkSMvAZw5X/ybC7DZYYhRkwOxBi?= =?Windows-1252?Q?H6qHf0GesDZHUvs5K4X+K5tU3p4g4iu4U+3GRCGxCyu9vcjc/hjNuwNJ?= =?Windows-1252?Q?mWw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0745; 6:pFSaggg+ToDf5xYsWN/Spcm2+0TUVGpUc5WhbRBa9VOJmW0njV4KmyCRCLUxMbAoNZJ8nKzZV9ej7vcLSAWnEUQG6F3cKKcWGX9PwQyZ4fUTCMnjff1XpoeC5xIOOEEhXk5Kbcu95cLScTLVem1ZIbsEbQYaB5kQVmsUZkSW+9SVSKonTQ0n1cnU7qGhULzgQ5RIsbgZLrEb5hXAZBeshc7Tlq4gWFgnji27l3HIuldxUjCSfFYPpHxHd37DTjuKJtRUtaDI9XtYHDrLWkF+EMbFdLAdBBJuFBASZIyxI1jmuLZIO/w+copPUOKQ8iMolVrIu/ZxQUoSDAeQ7sbDXIu2H1a0EadCVhHS01BJZu3ecXklYbfQTC5el8/1fSRQz50lyLgR+nbxV8FOMP5KlRfdXNK5iNdGhtMFPS0+MwQ8bNTxGx6jQi5rezig2bFZ; 5:vrnwj/+L9+6F/dAJBRfolAqgHm3cpYnkF2Gjc9MROAGdB3pyy1poAqM2m7YzSoIxlWJH1mvLq5+t8EvLL0Ios2g73q7pYNF44hLgOeRvyPXej5RB69Q8VHQ+1GqnmnBbIIoUtGq6ucb678GDYi6kPaiD5MDaXIl8jClp04vAUUlYYZUY8GcpanqtwNnHTpau; 24:U2aGlXIcRj2bGf+hIEVgnafWZJwaEESGLPbXeGqF6ToiNEU26N152KxMYymmepIxgXyiLqDKNiUEKknzemj4Ho1CDB+UT3IElw/ePb44w1c= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0745; 7:rDgE92Ij4FaseJiiUes5VnKEfH1i6FJMve5XzjmYkGW8FFKtbtW3JClvCeRggnJie9mTyRtF1Ydq5n5322gthu9+QPVgynlu1Hic3zxShzLcU1Uo9f0gMtXgbSv63UIROJLPXefSgtPV8HZt5QyiDjWwGfHT3mkN+xPStnzVeFCpTI6XlzoB1IM014C+9gtwAcCruZKWTkRZr8cP6UlZveThquzCcapE8Mg84xZHOEw0VBP01ZU1zmIVsToNWhhV7BDWh8Zlrdu3waaDvuKSeA1ilGaCMWrj/wajHdxHg9+FSfzC4K3ShT62slnQznutWE1V4SX8j5gNMeA490OV18CnKnvxlHgLidJRAqhmPgQaugyI+v5hj063/f3ShMGwq6ckjSglmSGSxtpKhA2POjYZXNAsbUVAKqzBGbJmrbIMQ/niTliOXkgWzhO2LSavorqPPXMQDFvbLWFT9VaaOw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2016 09:57:07.2100 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB0745 Subject: Re: [dpdk-dev] [PATCH v3 0/9] Decouple ethdev from PCI device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2016 09:57:09 -0000 Hi Jan, On Tuesday 20 December 2016 04:41 PM, Jan Blunck wrote: > This is a repost of the series I sent in November. I've addressed Shreyansh's > review comments about the PCI device users I've missed. > > Jan Blunck (9): > eal: define container_of macro > ethdev: Helper to convert to struct rte_pci_device > drivers: Use ETH_DEV_PCI_DEV() helper > virtio: Don't fill dev_info->driver_name > virtio: Add vtpci_intr_handle() helper to get rte_intr_handle > virtio: Don't depend on struct rte_eth_dev's pci_dev > ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get() > ethdev: Decouple interrupt handling from PCI device > ethdev: Decouple struct rte_eth_dev from struct rte_pci_device > > app/test/virtual_pmd.c | 4 +- > drivers/net/bnx2x/bnx2x_ethdev.c | 13 +++--- > drivers/net/bnxt/bnxt_ethdev.c | 21 ++++++---- > drivers/net/bnxt/bnxt_ring.c | 11 ++--- > drivers/net/bonding/rte_eth_bond_args.c | 12 +++++- > drivers/net/cxgbe/cxgbe_ethdev.c | 4 +- > drivers/net/cxgbe/cxgbe_main.c | 4 +- > drivers/net/e1000/em_ethdev.c | 21 ++++++---- > drivers/net/e1000/igb_ethdev.c | 52 +++++++++++++---------- > drivers/net/e1000/igb_pf.c | 3 +- > drivers/net/ena/ena_ethdev.c | 4 +- > drivers/net/enic/enic_ethdev.c | 3 +- > drivers/net/fm10k/fm10k_ethdev.c | 56 +++++++++++++------------ > drivers/net/i40e/i40e_ethdev.c | 45 ++++++++++---------- > drivers/net/i40e/i40e_ethdev.h | 4 ++ > drivers/net/i40e/i40e_ethdev_vf.c | 39 ++++++++--------- > drivers/net/ixgbe/ixgbe_ethdev.c | 67 ++++++++++++++++++------------ > drivers/net/ixgbe/ixgbe_pf.c | 2 +- > drivers/net/mlx4/mlx4.c | 2 + > drivers/net/mlx5/mlx5_ethdev.c | 2 + > drivers/net/nfp/nfp_net.c | 17 ++++---- > drivers/net/qede/qede_ethdev.c | 18 ++++---- > drivers/net/szedata2/rte_eth_szedata2.c | 28 +++++++------ > drivers/net/szedata2/rte_eth_szedata2.h | 34 +++++++-------- > drivers/net/thunderx/nicvf_ethdev.c | 7 +++- > drivers/net/virtio/virtio_ethdev.c | 38 ++++++++--------- > drivers/net/virtio/virtio_pci.h | 6 +++ > drivers/net/virtio/virtio_user_ethdev.c | 1 - > drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 ++- > lib/librte_eal/common/include/rte_common.h | 20 +++++++++ > lib/librte_eal/common/include/rte_pci.h | 6 +++ > lib/librte_ether/rte_ethdev.c | 25 ++++++++--- > lib/librte_ether/rte_ethdev.h | 9 +++- > 33 files changed, 355 insertions(+), 229 deletions(-) > Besides the MLX* and bnx2x compile errors (responses in individual patch email), all other changes look fine to me. Either you can directly add my series ACK to v4 or, for ML record purpose, I will do that once you post v4 - whichever way you prefer. - Shreyansh