From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 1F0285F16 for ; Fri, 12 Apr 2019 11:17:50 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id r186so3843090wmf.1 for ; Fri, 12 Apr 2019 02:17:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=nf0Ihym3bF08ssaKIoLofV5VfhlTIiSOuMM1IQpBmfg=; b=hxo+AHbmKkom1SgvAGegzmKN9VB4mY82rQPsHqIr1XFlqrnJBNIqYnpvU73BjvBzNO DSkpYBIpp8w/0T+SyrCDJ6W59iC77u8f3/BENrrdRKT/LertDAenoXTqAGRILB6k+FKX 6iohRlz9L0LZ2EfAJELYM6p4ZXvVQDVGG9zLwn/lfve1Roga475Z3QRl/vIfzFZjnRvk JhTBCfazLQ+T9Y5rfOGW6Yw76uWSfBcz2u9zM1VIkgcpD1AiiKY296Hizn/Oq0dckHak S9W7cB8jyehHkQYas6mSpNwLZpL/N9AKpluWdJXak+hY+IGzZQyBvVzQD1wzZVBvhYbE SGfg== X-Gm-Message-State: APjAAAWV494ZVVAYAsPerO9CUblt3wii3oUp9hd9+h+Zx+YiVoirf/sP Q9uHXRCeKvloq8OcaPWll88= X-Google-Smtp-Source: APXvYqxFe0eLuqE5FjPZRcbLBMsXE1Mee2zB1nUoUtf5Y2iBIUh8xkXw/3E/2tzsUPKzvAU8U3XWAg== X-Received: by 2002:a1c:ef08:: with SMTP id n8mr10005662wmh.85.1555060669805; Fri, 12 Apr 2019 02:17:49 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id p6sm36193992wrt.4.2019.04.12.02.17.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Apr 2019 02:17:49 -0700 (PDT) Message-ID: <79696b240c8f8b965fedd58a1c15ed86c62cb8f7.camel@debian.org> From: Luca Boccassi To: Aaron Conole , dev@dpdk.org Cc: Bruce Richardson , Reshma Pattan , Agalya Babu RadhaKrishnan , David Marchand Date: Fri, 12 Apr 2019 10:17:48 +0100 In-Reply-To: <20190411195229.7841-4-aconole@redhat.com> References: <20190411195229.7841-1-aconole@redhat.com> <20190411195229.7841-4-aconole@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] app/test/meson: auto detect number of cores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2019 09:17:50 -0000 On Thu, 2019-04-11 at 15:52 -0400, Aaron Conole wrote: > The arguments being passed will cause failures on laptops that have, > for instance, 2 cores only. Most of the tests don't require more > than a single core. Some require multiple cores (but those tests > should be modified to 'SKIP' when the correct number of cores > aren't available). >=20 > The unit test results shouldn't be impacted by this change, but it > allows for a future enhancement to pass flags such as '--no-huge'. >=20 > Also include a fix to a reported issue with running on FreeBSD. >=20 > Signed-off-by: Aaron Conole < > aconole@redhat.com > > > --- > Conflicts with=20 > http://patches.dpdk.org/patch/50850/ >=20 >=20 > app/test/meson.build | 24 +++++++++++++++++++++--- > 1 file changed, 21 insertions(+), 3 deletions(-) >=20 With the provision that the changes suggested by Bruce and David are applied, Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 46DC8A0096 for ; Fri, 12 Apr 2019 11:17:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1AD385F17; Fri, 12 Apr 2019 11:17:51 +0200 (CEST) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 1F0285F16 for ; Fri, 12 Apr 2019 11:17:50 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id r186so3843090wmf.1 for ; Fri, 12 Apr 2019 02:17:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=nf0Ihym3bF08ssaKIoLofV5VfhlTIiSOuMM1IQpBmfg=; b=hxo+AHbmKkom1SgvAGegzmKN9VB4mY82rQPsHqIr1XFlqrnJBNIqYnpvU73BjvBzNO DSkpYBIpp8w/0T+SyrCDJ6W59iC77u8f3/BENrrdRKT/LertDAenoXTqAGRILB6k+FKX 6iohRlz9L0LZ2EfAJELYM6p4ZXvVQDVGG9zLwn/lfve1Roga475Z3QRl/vIfzFZjnRvk JhTBCfazLQ+T9Y5rfOGW6Yw76uWSfBcz2u9zM1VIkgcpD1AiiKY296Hizn/Oq0dckHak S9W7cB8jyehHkQYas6mSpNwLZpL/N9AKpluWdJXak+hY+IGzZQyBvVzQD1wzZVBvhYbE SGfg== X-Gm-Message-State: APjAAAWV494ZVVAYAsPerO9CUblt3wii3oUp9hd9+h+Zx+YiVoirf/sP Q9uHXRCeKvloq8OcaPWll88= X-Google-Smtp-Source: APXvYqxFe0eLuqE5FjPZRcbLBMsXE1Mee2zB1nUoUtf5Y2iBIUh8xkXw/3E/2tzsUPKzvAU8U3XWAg== X-Received: by 2002:a1c:ef08:: with SMTP id n8mr10005662wmh.85.1555060669805; Fri, 12 Apr 2019 02:17:49 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id p6sm36193992wrt.4.2019.04.12.02.17.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Apr 2019 02:17:49 -0700 (PDT) Message-ID: <79696b240c8f8b965fedd58a1c15ed86c62cb8f7.camel@debian.org> From: Luca Boccassi To: Aaron Conole , dev@dpdk.org Cc: Bruce Richardson , Reshma Pattan , Agalya Babu RadhaKrishnan , David Marchand Date: Fri, 12 Apr 2019 10:17:48 +0100 In-Reply-To: <20190411195229.7841-4-aconole@redhat.com> References: <20190411195229.7841-1-aconole@redhat.com> <20190411195229.7841-4-aconole@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] app/test/meson: auto detect number of cores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190412091748.VFTW9flvnU-9YzYpGvOMRWZqEuMsf9OjBxAGv1j96Ho@z> On Thu, 2019-04-11 at 15:52 -0400, Aaron Conole wrote: > The arguments being passed will cause failures on laptops that have, > for instance, 2 cores only. Most of the tests don't require more > than a single core. Some require multiple cores (but those tests > should be modified to 'SKIP' when the correct number of cores > aren't available). >=20 > The unit test results shouldn't be impacted by this change, but it > allows for a future enhancement to pass flags such as '--no-huge'. >=20 > Also include a fix to a reported issue with running on FreeBSD. >=20 > Signed-off-by: Aaron Conole < > aconole@redhat.com > > > --- > Conflicts with=20 > http://patches.dpdk.org/patch/50850/ >=20 >=20 > app/test/meson.build | 24 +++++++++++++++++++++--- > 1 file changed, 21 insertions(+), 3 deletions(-) >=20 With the provision that the changes suggested by Bruce and David are applied, Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi