From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3D9D6A04F5;
	Thu, 12 Dec 2019 11:32:29 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 8B5131BE8A;
	Thu, 12 Dec 2019 11:32:28 +0100 (CET)
Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3])
 by dpdk.org (Postfix) with ESMTP id 3A50C2BD3
 for <dev@dpdk.org>; Thu, 12 Dec 2019 11:32:27 +0100 (CET)
Received: from mail.lysator.liu.se (localhost [127.0.0.1])
 by mail.lysator.liu.se (Postfix) with ESMTP id BEA6040004
 for <dev@dpdk.org>; Thu, 12 Dec 2019 11:32:26 +0100 (CET)
Received: by mail.lysator.liu.se (Postfix, from userid 1004)
 id A99AA4000D; Thu, 12 Dec 2019 11:32:26 +0100 (CET)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 bernadotte.lysator.liu.se
X-Spam-Level: 
X-Spam-Status: No, score=-0.6 required=5.0 tests=ALL_TRUSTED,AWL
 autolearn=disabled version=3.4.2
X-Spam-Score: -0.6
Received: from [192.168.1.59] (host-95-205-12-42.mobileonline.telia.com
 [95.205.12.42])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.lysator.liu.se (Postfix) with ESMTPSA id B7A3540004;
 Thu, 12 Dec 2019 11:32:24 +0100 (CET)
To: "dev@dpdk.org" <dev@dpdk.org>
From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= <mattias.ronnblom@ericsson.com>
Cc: jerinjacobk@gmail.com, "Richardson, Bruce" <bruce.richardson@intel.com>
Message-ID: <796ea779-91d2-2aa1-b5ff-40f725f7d5f3@ericsson.com>
Date: Thu, 12 Dec 2019 11:32:23 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: ClamAV using ClamSMTP
Subject: [dpdk-dev] rte_event_dev_xstats_by_name_get issues
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi.

I'm looking at implementing rte_event_dev_xstats_by_name() for DSW, and 
I have some API-related questions.

Shouldn't rte_event_dev_xstats_by_name_get() return mode and queue/port 
id? Otherwise the caller needs to know if the name refers to a device- 
or port-level stat, and in case of the latter also the port or queue id. 
  That information is needed in subsequent rte_event_dev_xstats_get() call.

Also, the API states that the function may return "negative value: 
-EINVAL if stat not found, -ENOTSUP if not supported", which is somewhat 
misleading, since the return value is of an unsigned type.

Regards,
	Mattias