DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] examples/packet_ordering: fix return value of parse_portmask
@ 2020-06-05 13:41 Sarosh Arif
  2020-07-30 21:18 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Sarosh Arif @ 2020-06-05 13:41 UTC (permalink / raw)
  To: dev, reshma.pattan; +Cc: Sarosh Arif

Giving invalid or zero portmask as command line option to 
packet_ordering application will have an unexpected response.
The reason behind this is that parse_portmask's return value is
stored in a variable called portmask.The data type of portmask 
is unsigned int, hence returning -1 in case of zero or invalid
portmask causes an unexpected behaviour. 
If we return 0 instead of -1 this issue can be resolved.
The program already contains the functionality to print
"invalid portmask" and program usage if portmask is zero.

Fixes: 850f3733f840 ("examples/packet_ordering: new sample app")

Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
---
 examples/packet_ordering/main.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c
index edaf810d9..b5fc6c54b 100644
--- a/examples/packet_ordering/main.c
+++ b/examples/packet_ordering/main.c
@@ -143,10 +143,7 @@ parse_portmask(const char *portmask)
 	/* parse hexadecimal string */
 	pm = strtoul(portmask, &end, 16);
 	if ((portmask[0] == '\0') || (end == NULL) || (*end != '\0'))
-		return -1;
-
-	if (pm == 0)
-		return -1;
+		return 0;
 
 	return pm;
 }
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/packet_ordering: fix return value of parse_portmask
  2020-06-05 13:41 [dpdk-dev] [PATCH] examples/packet_ordering: fix return value of parse_portmask Sarosh Arif
@ 2020-07-30 21:18 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2020-07-30 21:18 UTC (permalink / raw)
  To: Sarosh Arif; +Cc: dev, reshma.pattan, bruce.richardson

05/06/2020 15:41, Sarosh Arif:
> Giving invalid or zero portmask as command line option to 
> packet_ordering application will have an unexpected response.
> The reason behind this is that parse_portmask's return value is
> stored in a variable called portmask.The data type of portmask 
> is unsigned int, hence returning -1 in case of zero or invalid
> portmask causes an unexpected behaviour. 
> If we return 0 instead of -1 this issue can be resolved.
> The program already contains the functionality to print
> "invalid portmask" and program usage if portmask is zero.
> 
> Fixes: 850f3733f840 ("examples/packet_ordering: new sample app")
> 
> Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>

Merged with same fix for other examples, thanks.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-05 13:41 [dpdk-dev] [PATCH] examples/packet_ordering: fix return value of parse_portmask Sarosh Arif
2020-07-30 21:18 ` Thomas Monjalon

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox