From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: Jan Blunck <jblunck@infradead.org>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH] drivers: make driver names consistent
Date: Tue, 18 Oct 2016 18:46:40 +0200 [thread overview]
Message-ID: <7993435.bReMuqSN60@xps13> (raw)
In-Reply-To: <20161018141837.GN16751@yliu-dev.sh.intel.com>
2016-10-18 22:18, Yuanhan Liu:
> On Tue, Oct 18, 2016 at 03:42:54PM +0200, Thomas Monjalon wrote:
> > 2016-10-18 21:06, Yuanhan Liu:
> > > On Tue, Oct 18, 2016 at 02:50:16PM +0200, Jan Blunck wrote:
> > > > >From my understanding this is a massive API breakage. This forces all
> > > > existing users of the virtual PMDs to change with zero benefit. Even
> > > > if that isn't enough it also makes it impossible to switch between
> > > > releases by recompiling.
> > > >
> > > > Can we please revert these changes and work on some aliasing support
> > > > for the PMDs to fix it long term?
> > >
> > > +1. Aliasing is also something I would suggest before making such renames.
> >
> > It is a brutal change, yes.
> > It was announced in 16.07 release notes though.
>
> Yes, but it still took me a while (by running git bisect) to figure out
> what went wrong: I wasn't aware of such note, that I was thinking maybe
> something is broken.
>
> Later I also got quite few same complains. It may also took them a while
> to know what's happened.
>
> Anyway, my point is, for this kind of change, we should have added the
> alias support firstly.
Yes.
> If that's been done, then the announcement is not
> needed at all?
The announcement would be needed to remove the aliases, later.
> > We can try to make this change more progressive by keeping old names
> > as aliases for some time.
> > Is there a volunteer to work on vdev names aliases,
> > with the target of integrating them in RC2 or RC3?
next prev parent reply other threads:[~2016-10-18 16:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 22:24 Pablo de Lara
2016-08-24 22:27 ` De Lara Guarch, Pablo
2016-08-24 22:37 ` Mcnamara, John
2016-09-16 9:58 ` Thomas Monjalon
2016-10-18 12:50 ` Jan Blunck
2016-10-18 13:06 ` Yuanhan Liu
2016-10-18 13:42 ` Thomas Monjalon
2016-10-18 14:18 ` Yuanhan Liu
2016-10-18 16:46 ` Thomas Monjalon [this message]
2016-10-19 10:05 ` Yuanhan Liu
2016-10-19 12:26 ` Thomas Monjalon
2016-10-18 15:26 ` Jan Blunck
2016-10-18 16:45 ` Thomas Monjalon
2016-10-19 13:32 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7993435.bReMuqSN60@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jblunck@infradead.org \
--cc=john.mcnamara@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).