From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0072.outbound.protection.outlook.com [104.47.34.72]) by dpdk.org (Postfix) with ESMTP id A086D8E7C for ; Thu, 8 Sep 2016 07:51:27 +0200 (CEST) Received: from BY2PR03CA073.namprd03.prod.outlook.com (10.141.249.46) by MWHPR03MB2448.namprd03.prod.outlook.com (10.169.200.142) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.609.9; Thu, 8 Sep 2016 05:51:26 +0000 Received: from BN1AFFO11FD015.protection.gbl (2a01:111:f400:7c10::182) by BY2PR03CA073.outlook.office365.com (2a01:111:e400:2c5d::46) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.609.9 via Frontend Transport; Thu, 8 Sep 2016 05:51:25 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD015.mail.protection.outlook.com (10.58.52.75) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.587.6 via Frontend Transport; Thu, 8 Sep 2016 05:51:25 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u885pLb8023805; Wed, 7 Sep 2016 22:51:22 -0700 To: Ferruh Yigit , References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1472219823-29486-1-git-send-email-shreyansh.jain@nxp.com> <1472219823-29486-23-git-send-email-shreyansh.jain@nxp.com> <57C467A1.8070606@intel.com> CC: , , , From: Shreyansh Jain Message-ID: <79d585f3-02df-1597-1f8f-7dcdf300d08e@nxp.com> Date: Thu, 8 Sep 2016 11:21:37 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <57C467A1.8070606@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131177874856458827; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(199003)(24454002)(189002)(377454003)(93886004)(87936001)(106466001)(230700001)(65806001)(65956001)(50466002)(64126003)(85426001)(31696002)(47776003)(77096005)(586003)(305945005)(105606002)(54356999)(76176999)(68736007)(86362001)(81166006)(8676002)(356003)(8936002)(2950100001)(97736004)(23746002)(36756003)(81156014)(8666005)(104016004)(4001350100001)(7846002)(5001770100001)(189998001)(50986999)(31686004)(11100500001)(83506001)(626004)(4326007)(33646002)(92566002)(2906002)(5660300001)(65826007)(19580395003)(19580405001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR03MB2448; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD015; 1:UCexDVRU4RkBSK0roLXPZC7oh6w9b2S82y1+M4yoIa7o30Yj9Mm7ITQtIJZLkCOv929GPYgPAd8lrmDXuCxhqflNi4kK1Sljn5vo41zUnRyNdneTJCzeE8+KKGSHWW8Oje7gX8wia/D/fMotV3dHdbqwE8NFKkglUcirDmWloNnyOCCefTJwfYcv8e55wH9/+kT8mMI49BuHrdu5wRzCXzCg6uP9LQUdOeE81NyhW3lAwBwRx38GBw9PvZDCcXjKVMdWLSqp5sKeWb++nwPcJG2YcphhxdbNCBJhqsyEPy+D8s3afnXh3lsV4rddRJ2eCW2oxWcq22K1Em2abyo9FaD67xa9HhBieZhlfzvEwYVaqPiCWKdVZsp6eTcOlTGRoeT2wgk22B3Nod6OWdVIsEWKXUQdnz27m+F8pglGBr+RRMOMHvL0r6k7YMoI2A4Cd00S9bC8MBLlJBevXJmd86W+s4Dfk2fzAxKs/nSQIZjvP80OxE4h519YTCiOSJzvBKEWV6QnYt0SeSeFfY7uXVijAZFZFw9eXJ2ytiGLdHvARyhVWJbasQ+eElgAF+sdUGFLabxebQsW8iF4qYAWRqtnYevpOeH9kDsOwE2T+2zdFTpkdLIKVexj0SH85q2756b85BKiMcr20iZsa6AiGQ== X-MS-Office365-Filtering-Correlation-Id: 1600a6b9-c20f-4ecb-ba4b-08d3d7ac2bac X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2448; 2:Z6ycSUDd5MVYsgP7zpOeM8fNWTU7xtpinBfLhI5I/r1Eg4gA+FzrfTInh5g8cdAOeREBgF1hnu7RdHWtvAvf1cMn2JDpPs4v7c2xFPowqX5AlwCMBMBCCnMiDoV6zrEms9onU1bWCugWPiRd/8NH4FyZ0jVUWzGyV2jJkS9FBctbjl7tW8Cmg7aU7rj2zdaQ; 3:hdWQSovR5428ba/OdA+MlzW4Jb1sFD+CVwF0axI9BQY5c1xhZjCdqDYMceRpqe8JsRSz/zlRRbfL32O8aDC9oek/Vs0DuFRcTbSMyz4Q2XmVuH+pdSTGTnK3gT6bVLTF8rpHpqH4inwWmBChMriw83HPJ0ET5uD0IF28f60U0YEoMVLAtJviZC6tUjKbtmTQYiKibe6QXyFRbCq/anrfywxaXczES1iozxvtXJvPyuQ= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR03MB2448; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2448; 25:y6mupgGbDlvVLL180izK5NdVgA6n16BI7PReK/abfvNSFcSlyxuCgjcArodUe1FXevdrdU8YPgh9DuCVLNtYvEpHPp6mvPESJXkzKuRalwiD2rVwOxO5yZh8sqi3oav/nwltl8iU9TDoIBlt8X7UBsJyOYFHghFLP+r1W9zPdTFUR+Op86WbpULds/gj2fOw9k/3Qjyg1uSbtpV3ZrrPUhwsfM35ag61QPh02b5hYE+o5MICXCapJ0ubP3J2ZQqOwtQcBMs4f6CdiYSlmSNVLbyu15PYfTHwyDqLi0gHedc8zSTAEGYcSxaCyrEb10S5M87cZmkqStOCrffY0hQvHs9E2PLGctK4YnADhvusGWI7cM65cAEWDvYpb6zoSfi3HhfMhJkI0Xs00ssX1uLwlyODak0r+aUgp4s9M+PpDggSCAJRZekWTdZBACqpzA3kjrI3LC65xRXDORsy4KhZrYXY71nIrdaNBCOF+h0l4uuofM5W6eZwqL0hgoGfgPqoG/TCQjWoAycOLz0GD33Oa936h70HZ3RQbQnUgwdEKoWIXsJHBRLNN0slwvxWajENKXn/ui5Fs8vD3wMtcpFGQ8DMf2WDWAUjZdsuyQlh8BIrGBy6ajn0O2Wss4KUxHxjyT67GrpwuXID+rBqKZ7L3WTwjUxzb+2YxnT/hQPf5FDeBBGRWqsgtpL1PUsz7l7EjfzGvhYTMo2Z3cs4UutDbw==; 31:IpDjjUaxdlNpEDOS29mXOGCTPst24H4aOBTC1ypNZDLPxMQKy0MbPWsZ52F64SSePKMQwFeHMvGgXNf2+Ncte0xZUf4wgonj0DF9p4DGfiskV6LfXJkqZNerbOhFODgzU7I0HDdjtoIRe7HoZgpfein34RLEVOotCQeLsBAtmhv2ZHWNXerYTLXBQGCsd2YUvDEL7l+EHHmbBqrZ1jlp5dxvAnr2QSW51yexKcDOvg8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13015025)(13017025)(13024025)(13018025)(13023025)(8121501046)(5005006)(3002001)(10201501046)(6055026); SRVR:MWHPR03MB2448; BCL:0; PCL:0; RULEID:(400006); SRVR:MWHPR03MB2448; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2448; 4:A+cIhEmob0MU7yoRraZvXMFe2cfQZlV+j+Vh1YuUYJrdtRbcQ8lyHx+9AHw6S0RLorjtAjaKji/GvrjII9XEHUt5fwh5eo/8lJUZx3GFPdMIx8na0UxIGTNrggaORbKpyzRgZz590nI7ME/AUFsnnK2jxwMj/z3r6pcBOXd2TjPQeRLXN+GmBUxP5A/PcEBS3WJ5dJsBwzEflWYl4IZMGnJ5t9x59t33/h4DECGpUOpEML9vWrHOWg7GiomXMLJGeqZzdwP5ySDyKOXBcOCaO1VCTeumZ0fMlt3/ARc3EINL519U5d2bWK7oismO/aJq+pwqEScYcefXh1iXFqsJhqg4cgSnleOpg083BH2Ki5ofJZTg+0+DTxWevCDc9cYFFC+1EcHwmOLdpNqosayh+PY9tmI5+b/TpInTtdHH+d5WdRGeOMWel/Ltw6KGvtV81rVk43YZyxUkq3ACadBe4NGVpcRgsnKfit80E98zSIWEx+h48hIO5ovgiBkigYeFtMF3lXSSiPpRNMaPmlxo1NL24OCzCcJIRJclWXBcMMI= X-Forefront-PRVS: 00594E8DBA X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; MWHPR03MB2448; 23:OB1ispDlz2OLT1pBYXxwniaF7T+C1XZ03N7MI?= =?Windows-1252?Q?HOf3Fg/uMDUuZFbh5aOMXmSvldPQCHQU1saPb+MU/HxwUfHhoN/Niiah?= =?Windows-1252?Q?XXa698TcuUAqWfqqEr3tv29OIneF6DndwGv1n2Xyc7HP43hI6Eum/C7m?= =?Windows-1252?Q?KyVibhvLPX0JzTGh9Go3gi4oP1aHyk6SA8RnLvU54Km+pcWItGfnRq6a?= =?Windows-1252?Q?An9Vg+YslpAyBgHftCPynfDxlzjvNNC+YEqFGIgKEyxR+Oi7OIzVAs5S?= =?Windows-1252?Q?8+2fdc0hR50iJ6mm+lqFx4i+wETZuCV3R+sRrU/5I6Ls6M8qJE/K3Sjh?= =?Windows-1252?Q?9HtYcFa6ao2r2bD+KINYZCus45hpO5P219RNlHEmG51z9NvBD9g5+T98?= =?Windows-1252?Q?bP5CFGniO8bXuR4c63EFS4JSwp6UDPvCDI7avUA4kS+NKfSVkm6LfPl+?= =?Windows-1252?Q?ui0bcg0AvQ1JYUIyaUiUe/qTLFi3nBRtpruO+WDkaem8xtyTDXwscVeY?= =?Windows-1252?Q?jam5T6Zpm+nzEEcSodywTHY/w8ggZZtloliffVeJJTKJNAtVw0s5RTwf?= =?Windows-1252?Q?Y+poKRrCnO0CDSMDw/Ju6kNy0x72K+kDLBADs78dNazAJ+WyEUkE1/UL?= =?Windows-1252?Q?uduNa8hB5DpETnkH7dEgTZPHUQ4IU/fK0Wx/QecLlJxeXXW+3k2rAnR0?= =?Windows-1252?Q?E6flvvvqVgER0V5wNGNctsYudVRTnGQWT/rllqnewJw3jgXud7GAxBlS?= =?Windows-1252?Q?oCmKwYJqSpLqiZKc/3EyxNzWjOKyFaj1mkJU/Yg2EJTIyS60zZ02eQ/3?= =?Windows-1252?Q?DWeoI68nwXhXLCIMEf4cYsta08XgiiwkljAY9kWrOIIJXMFJk2hNHoMa?= =?Windows-1252?Q?smfRbZ9mNQVSPhhIiBo7etjkrLVMx/1HVug/l227u7tE9N2cgyrx21YM?= =?Windows-1252?Q?kwYYeaFAkTbrBQTwhjNVwSRBr0mUyDLxRH/dFTZ2vctPvyqPv23g88yY?= =?Windows-1252?Q?O+x341cnIBfQ3+qbnkuEYes5uOzmkWD8+trjjYgglfhTs5Mkwv1pvqYv?= =?Windows-1252?Q?r9w36t0vdg6o/m5u8UZdD4DGyDiK6+Yqdc2eYxhvm03fmHwtbj52RvrM?= =?Windows-1252?Q?0JIe+wyw7w7J6ijAVZNCMZXYwvbTH5dGEl/1StZhRS01hrqPHlLp4QyM?= =?Windows-1252?Q?A8ZGS/PVaCSK2v8xjY7K1llQvd/nhSY/nnyhQACDvafA9xxgAeV9y2JH?= =?Windows-1252?Q?gzfn+o3RDk7LcBikeuF/g5UkIOVrv4GWQJRIakl78ftw/BewwofmkFw7?= =?Windows-1252?Q?V35JnSuFwDFkQLSqmAwhhUp2sc/6mFifFHWwr3aKmt3wdFsFg1lt9NgY?= =?Windows-1252?Q?UPMdVWMaIsa1lmp22VjHXPoRXfNLgVyf/N59Hhn3jAfQEswzA5D55AGJ?= =?Windows-1252?Q?xCdBiZI82Nhu5LEZmxwaYKuAotD4Nrv92iacoWd2BBOIa2ZyhK9+9NK4?= =?Windows-1252?Q?dsh1HG8cXbgxbxqdUlUALGOTg7FYt44tnifCerIHFwDG+q9mg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2448; 6:5MPWaNctg8FAUi2u6EW1UD/WssG+QuOmv1VEhhN30Fh5gPPwf8EZnIaBiqDNvs4nBX1EyQ+7czXCAXNe8vEILMhmURBr6Etg9nLMyuQq3elxhNyGSGSDFn3BR+/lmGF+zfDwwvH7gxpOSu0UGTOos2eNwJKraF4hzUkX2pm2QRSdQyQTW08p8ndZ4ScPw0kdC+BPL5pqBIpE23/Gx1KLiG94hhXJU+iRi88S+wSM6AsP/HFC6BRNBJLxAHN8WGnE4uaZOJczaLn5Nz75bbRwR9sJyqKpHJQjIRRLJmkGgzg=; 5:cOH6r3otcPi43LV9m4FNBtnDVg6xW2WyCPZ1ilUBZcwWC5EOYr6PQdSVXuaI5ZlT72LmRYW2zl8z6h595yhlN/WTYUzRkEx+LvnpiO0vIJEJJUCJJDwd/R0JxxZ6kx+mB1QxCrnrzvqIZZruXhLhuDlBeNvb3IvvrPFBLzHo6Y0=; 24:GqHrKHG8cmlPeLIHmTFLebMXRBT5qOMvI//62QyWUon7+u/+bcQo/ThbZZ1MTyfwHxmlNicDFV+8es6bKtDExs0UTIJfC/UOuuaAmJe3lCg=; 7:M4EdkKSQAmYHxCICmbwn3duWU704K+3S0RF72aDoZATnDBkJy7BZMDXvaMZT5mDJ8B62FMd1K1SCPQPWuX6xGHKKW4sA4V+P8WVguUhPEc4Bi36GWhT9DkHozWPVp0VYp2UOTVzbOK7QWi4K+A1JoYOHjvQ2y99gTbMQpT2WiNuclq/c8P/txa4UQXCBQWBB4DK7TFvv7u/K3UHuf28U5XVAvpoh4lllltCiRXXXs9Py/Vz/lcL40eGFARuVx2IV SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2016 05:51:25.4586 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2448 Subject: Re: [dpdk-dev] [PATCH v8 22/25] eal/pci: inherit rte_driver by rte_pci_driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 05:51:28 -0000 Hi Ferruh, On Monday 29 August 2016 10:19 PM, Ferruh Yigit wrote: > On 8/26/2016 2:57 PM, Shreyansh Jain wrote: >> Remove the 'name' member from rte_pci_driver and move to generic rte_driver. >> >> Most of the PMD drivers were initially using DRIVER_REGISTER_PCI(..) >> as well as assigning a name to eth_driver.pci_drv.name member. >> In this patch, only the original DRIVER_REGISTER_PCI(..) name has been >> populated into the rte_driver.name member - assignments through eth_driver >> has been removed. >> >> Signed-off-by: Jan Viktorin >> Signed-off-by: Shreyansh Jain >> --- >> app/test/test_pci.c | 10 +++++++--- >> app/test/virtual_pmd.c | 2 +- >> drivers/crypto/qat/qat_qp.c | 2 +- >> drivers/net/bnx2x/bnx2x_ethdev.c | 2 -- > > bnx2x_rxtx.c also needs to be updated: > > CC bnx2x_rxtx.o > ..../drivers/net/bnx2x/bnx2x_rxtx.c:22:25: error: no member named 'name' > in 'struct rte_pci_driver' > dev->driver->pci_drv.name, ring_name, > dev->data->port_id, queue_id); I have updated this in v9. Compilation is OK now. (I had missed compiling this before sending v8). > > .... > > > Also szedata2 driver seems missed: > > CC rte_eth_szedata2.o > ..../drivers/net/szedata2/rte_eth_szedata2.c:1575:4: error: field > designator 'name' does not refer to any field in type 'struct > rte_pci_driver' > .name = RTE_SZEDATA2_PCI_DRIVER_NAME, > ^ > > > Though I have updated the code here, I have not yet been able to compile this because of some dependencies. I am still to setup env for szedata2 compilation. -- - Shreyansh