From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Jianbo Liu <Jianbo.Liu@arm.com>
Cc: Guduri Prathyusha <gprathyusha@caviumnetworks.com>,
tomasz.kantecki@intel.com, guduriprathyusha@gmail.com,
dev@dpdk.org, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix NEON instructions
Date: Tue, 7 Nov 2017 00:05:00 -0800 [thread overview]
Message-ID: <79e54de9-f542-a624-e55f-e43ba7d8a019@intel.com> (raw)
In-Reply-To: <20171102103342.GA20462@jerin>
On 11/2/2017 3:33 AM, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Mon, 30 Oct 2017 15:36:15 +0800
>> From: Jianbo Liu <Jianbo.Liu@arm.com>
>> To: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
>> CC: tomasz.kantecki@intel.com, guduriprathyusha@gmail.com, dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix NEON instructions
>> User-Agent: Mutt/1.5.21 (2010-09-15)
>>
>> The 10/30/2017 13:01, Guduri Prathyusha wrote:
>>> To group consecutive packets with same destination port in bursts of 4
>>> neon intrinsic data types dp1 and dp2 are calculated such that if
>>> dst_port[]={a,b,c,d,e,f,g,h,i...} dp1 should contain: <a,b,c,d> and
>>> dp2 should contain: <b,c,d,e> in the first iteration. dp1 should
>>> be <e,f,g,h> and dp2 should be <f,g,h,i> in the next iteration.
>>>
>>> Whereas the existing code incorrectly calculates dp1 as <d,e,f,g> from
>>> second iteration.
>>>
>>> This patch fixes the incorrect ARM NEON instructions on dp1.
>>>
>>> Fixes: 569b290cdb36 ("examples/l3fwd: add NEON implementation")
>>>
>>> Signed-off-by: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
>>
>> Acked-by: Jianbo Liu <jianbo.liu@arm.com>
>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Applied to dpdk/master, thanks.
prev parent reply other threads:[~2017-11-07 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 7:31 Guduri Prathyusha
2017-10-30 7:36 ` Jianbo Liu
2017-11-02 10:33 ` Jerin Jacob
2017-11-07 8:05 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79e54de9-f542-a624-e55f-e43ba7d8a019@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Jianbo.Liu@arm.com \
--cc=dev@dpdk.org \
--cc=gprathyusha@caviumnetworks.com \
--cc=guduriprathyusha@gmail.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas@monjalon.net \
--cc=tomasz.kantecki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).