From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id CDE6F133F for ; Wed, 15 Mar 2017 22:37:13 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 15 Mar 2017 14:37:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,170,1486454400"; d="scan'208";a="77298721" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 15 Mar 2017 14:37:12 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 15 Mar 2017 14:37:12 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.172]) by fmsmsx118.amr.corp.intel.com ([169.254.1.242]) with mapi id 14.03.0248.002; Wed, 15 Mar 2017 14:37:12 -0700 From: "Wiles, Keith" To: Pascal Mazon CC: "Yigit, Ferruh" , "dev@dpdk.org" Thread-Topic: [PATCH v5 1/8] net/tap: remove wrong IFF_NOARP flags Thread-Index: AQHSnZuW0Rnb3vCWT0i4gAiwD2jRIqGW4r2A Date: Wed, 15 Mar 2017 21:37:11 +0000 Message-ID: <7ADA3811-0BDB-4AF7-A14C-014A6890E07F@intel.com> References: <1488904298-31395-1-git-send-email-pascal.mazon@6wind.com> <4a25b076051f9aa3f5bdb67bf953faad2c7c95c1.1489589167.git.pascal.mazon@6wind.com> In-Reply-To: <4a25b076051f9aa3f5bdb67bf953faad2c7c95c1.1489589167.git.pascal.mazon@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.25.146] Content-Type: text/plain; charset="us-ascii" Content-ID: <8509032AFC34BC458666C6328AC66052@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/8] net/tap: remove wrong IFF_NOARP flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Mar 2017 21:37:14 -0000 > On Mar 15, 2017, at 10:48 PM, Pascal Mazon wrote= : >=20 > There is no reason not to support ARP on a tap netdevice. > Focus on IFF_UP when a link status change is required. >=20 > Fixes: f457b472b1f2 ("net/tap: add link up and down operations") > Signed-off-by: Pascal Mazon > Reviewed-by: Ferruh Yigit Acked-by: Keith.Wiles@intel.com for the series. > --- > drivers/net/tap/rte_eth_tap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.= c > index a5cbb23e4cd2..fcf4a1dc3da1 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -375,7 +375,7 @@ tap_link_set_down(struct rte_eth_dev *dev) > struct pmd_internals *pmd =3D dev->data->dev_private; >=20 > dev->data->dev_link.link_status =3D ETH_LINK_DOWN; > - return tap_link_set_flags(pmd, IFF_UP | IFF_NOARP, 0); > + return tap_link_set_flags(pmd, IFF_UP, 0); > } >=20 > static int > @@ -384,7 +384,7 @@ tap_link_set_up(struct rte_eth_dev *dev) > struct pmd_internals *pmd =3D dev->data->dev_private; >=20 > dev->data->dev_link.link_status =3D ETH_LINK_UP; > - return tap_link_set_flags(pmd, IFF_UP | IFF_NOARP, 1); > + return tap_link_set_flags(pmd, IFF_UP, 1); > } >=20 > static int > --=20 > 2.8.0.rc0 >=20 Regards, Keith