From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3760DADA3 for ; Wed, 8 Jun 2016 13:40:37 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 08 Jun 2016 04:40:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,438,1459839600"; d="scan'208";a="971380989" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga001.jf.intel.com with ESMTP; 08 Jun 2016 04:40:35 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.96]) by irsmsx105.ger.corp.intel.com ([169.254.7.51]) with mapi id 14.03.0248.002; Wed, 8 Jun 2016 12:40:33 +0100 From: "Mrzyglod, DanielX T" To: Stephen Hemminger , "Kobylinski, MichalX" CC: "thomas.monjalon@6wind.com" , "dev@dpdk.org" , "david.marchand@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] mem: fix overflowed return value Thread-Index: AQHRnIhOb1DQCHgCkE2ggNjLkVxQvp+WHRUAgEmZedA= Date: Wed, 8 Jun 2016 11:40:33 +0000 Message-ID: <7ADD74816B4C8A45B56203CBA65FE5A637791649@IRSMSX107.ger.corp.intel.com> References: <1461321858-30339-1-git-send-email-michalx.kobylinski@intel.com> <20160422092434.00bc0c46@xeon-e3> In-Reply-To: <20160422092434.00bc0c46@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] mem: fix overflowed return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2016 11:40:37 -0000 >-----Original Message----- >From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger >Sent: Friday, April 22, 2016 6:25 PM >To: Kobylinski, MichalX >Cc: thomas.monjalon@6wind.com; dev@dpdk.org >Subject: Re: [dpdk-dev] [PATCH] mem: fix overflowed return value > >On Fri, 22 Apr 2016 12:44:18 +0200 >Michal Kobylinski wrote: > >> Fix issue reported by Coverity. >> >> Coverity ID 13255: Overflowed return value: The return value will be too >> small or even negative, likely resulting in unexpected behavior in a >> caller that uses the return value. In rte_mem_virt2phy: An integer >> overflow occurs, with the overflowed value used as the return value of >> the function >> >> Fixes: 3097de6e6bfb ("mem: get physical address of any pointer") >> >> Signed-off-by: Michal Kobylinski >> --- >> lib/librte_eal/linuxapp/eal/eal_memory.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c >b/lib/librte_eal/linuxapp/eal/eal_memory.c >> index 5b9132c..6ceca5b 100644 >> --- a/lib/librte_eal/linuxapp/eal/eal_memory.c >> +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c >> @@ -195,7 +195,7 @@ rte_mem_virt2phy(const void *virtaddr) >> * the pfn (page frame number) are bits 0-54 (see >> * pagemap.txt in linux Documentation) >> */ >> - physaddr =3D ((page & 0x7fffffffffffffULL) * page_size) >> + physaddr =3D (uint64_t)((page & 0x7fffffffffffffULL) * page_size) >> + ((unsigned long)virtaddr % page_size); >> close(fd); >> return physaddr; > >I am not trusting any of these Coverity patches you are sending. >It seems you think wraparound can be just fixed by casting, it can't >>From my point of view it's False Possitive there is no chance that page_siz= e will be bigger than long. Coverity Assume that page_size may be 18446744071562067968 but it can't. Only for glibc<2.1 we probably should change page_size =3D getpagesize(); = to page_size =3D sysconf(_SC_PAGESIZE);=20 May I change this Coverity to False Positive or I missed something ? What's= your opinion ?=20