From: "Hajkowski, MarcinX" <marcinx.hajkowski@intel.com>
To: "Krakowiak, LukaszX" <lukaszx.krakowiak@intel.com>,
"Hunt, David" <david.hunt@intel.com>
Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Krakowiak, LukaszX" <lukaszx.krakowiak@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/3] test: add UT for power turbo feature
Date: Fri, 7 Jun 2019 08:45:14 +0000 [thread overview]
Message-ID: <7AE8A440E9E11A43ABE083B4E74B60F94CE0C6@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <20190403103256.21856-4-lukaszx.krakowiak@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lukasz Krakowiak
> Sent: Wednesday, April 3, 2019 12:33 PM
> To: Hunt, David <david.hunt@intel.com>
> Cc: Burakov, Anatoly <anatoly.burakov@intel.com>; dev@dpdk.org;
> Krakowiak, LukaszX <lukaszx.krakowiak@intel.com>
> Subject: [dpdk-dev] [PATCH v2 3/3] test: add UT for power turbo feature
>
> Add UT check_power_turbo.
>
> Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
> ---
> app/test/test_power_cpufreq.c | 72
> +++++++++++++++++++++++++++++++++++
> 1 file changed, 72 insertions(+)
>
> diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c
> index d099f2f47..d203810da 100644
> --- a/app/test/test_power_cpufreq.c
> +++ b/app/test/test_power_cpufreq.c
> @@ -366,6 +366,59 @@ check_power_freq_min(void)
> return 0;
> }
>
> +/* Check rte_power_turbo() */
> +static int
> +check_power_turbo(void)
> +{
> + int ret;
> +
> + if (rte_power_turbo_status(TEST_POWER_LCORE_ID) == 0) {
> + printf("Turbo not available on lcore %u, skipping test\n",
> + TEST_POWER_LCORE_ID);
> + return 0;
> + }
> +
> + /* test with an invalid lcore id */
> + ret = rte_power_freq_enable_turbo(TEST_POWER_LCORE_INVALID);
> + if (ret >= 0) {
> + printf("Unexpectedly enable turbo successfully on lcore
> %u\n",
> + TEST_POWER_LCORE_INVALID);
> + return -1;
> + }
> + ret = rte_power_freq_enable_turbo(TEST_POWER_LCORE_ID);
> + if (ret < 0) {
> + printf("Fail to enable turbo on lcore %u\n",
> + TEST_POWER_LCORE_ID);
> + return -1;
> + }
> +
> + /* Check the current frequency */
> + ret = check_cur_freq(TEST_POWER_LCORE_ID, 0);
> + if (ret < 0)
> + return -1;
> +
> + /* test with an invalid lcore id */
> + ret = rte_power_freq_disable_turbo(TEST_POWER_LCORE_INVALID);
> + if (ret >= 0) {
> + printf("Unexpectedly disable turbo successfully on lcore
> %u\n",
> + TEST_POWER_LCORE_INVALID);
> + return -1;
> + }
> + ret = rte_power_freq_disable_turbo(TEST_POWER_LCORE_ID);
> + if (ret < 0) {
> + printf("Fail to disable turbo on lcore %u\n",
> + TEST_POWER_LCORE_ID);
> + return -1;
> + }
> +
> + /* Check the current frequency */
> + ret = check_cur_freq(TEST_POWER_LCORE_ID, 1);
> + if (ret < 0)
> + return -1;
> +
> + return 0;
> +}
> +
> static int
> test_power_cpufreq(void)
> {
> @@ -427,6 +480,21 @@ test_power_cpufreq(void)
> "been initialised\n");
> goto fail_all;
> }
> + if (rte_power_turbo_status == NULL) {
> + printf("rte_power_turbo_status should not be NULL,
> environment has not "
> + "been initialised\n");
> + goto fail_all;
> + }
> + if (rte_power_freq_enable_turbo == NULL) {
> + printf("rte_power_freq_enable_turbo should not be NULL,
> environment has not "
> + "been initialised\n");
> + goto fail_all;
> + }
> + if (rte_power_freq_disable_turbo == NULL) {
> + printf("rte_power_freq_disable_turbo should not be NULL,
> environment has not "
> + "been initialised\n");
> + goto fail_all;
> + }
>
> ret = rte_power_exit(TEST_POWER_LCORE_ID);
> if (ret < 0) {
> @@ -502,6 +570,10 @@ test_power_cpufreq(void)
> if (ret < 0)
> goto fail_all;
>
> + ret = check_power_turbo();
> + if (ret < 0)
> + goto fail_all;
> +
> ret = rte_power_exit(TEST_POWER_LCORE_ID);
> if (ret < 0) {
> printf("Cannot exit power management for lcore %u\n",
> --
> 2.19.2.windows.1
Tested-by: Marcin Hajkowski <marcinx.hajkowski@intel.com>
next prev parent reply other threads:[~2019-06-07 8:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 13:59 [dpdk-dev] [PATCH 0/3] test: improve test coverage for power library Lukasz Krakowiak
2019-03-07 13:59 ` [dpdk-dev] [PATCH 1/3] test: rename test_power_acpi_cpufreq.c -> app/test/test_power_cpufreq.c Lukasz Krakowiak
2019-03-27 15:05 ` Burakov, Anatoly
2019-03-27 15:05 ` Burakov, Anatoly
2019-03-07 13:59 ` [dpdk-dev] [PATCH 2/3] test: remove prefix _acpi from UT power function/test names Lukasz Krakowiak
2019-03-27 15:07 ` Burakov, Anatoly
2019-03-27 15:07 ` Burakov, Anatoly
2019-03-29 22:40 ` Thomas Monjalon
2019-03-29 22:40 ` Thomas Monjalon
2019-03-07 13:59 ` [dpdk-dev] [PATCH 3/3] test: add UT for power turbo feature Lukasz Krakowiak
2019-03-27 15:13 ` Burakov, Anatoly
2019-03-27 15:13 ` Burakov, Anatoly
2019-04-03 9:07 ` Krakowiak, LukaszX
2019-04-03 9:07 ` Krakowiak, LukaszX
2019-04-03 10:01 ` Burakov, Anatoly
2019-04-03 10:01 ` Burakov, Anatoly
2019-04-03 10:32 ` [dpdk-dev] [PATCH v2 0/3] test: improve test coverage for power library Lukasz Krakowiak
2019-04-03 10:32 ` Lukasz Krakowiak
2019-04-03 10:32 ` [dpdk-dev] [PATCH v2 1/3] test: rename test_power_acpi_cpufreq.c -> app/test/test_power_cpufreq.c Lukasz Krakowiak
2019-04-03 10:32 ` Lukasz Krakowiak
2019-04-03 10:32 ` [dpdk-dev] [PATCH v2 2/3] test: remove prefix _acpi from UT power function/test names Lukasz Krakowiak
2019-04-03 10:32 ` Lukasz Krakowiak
2019-04-15 15:14 ` Hunt, David
2019-04-15 15:14 ` Hunt, David
2019-04-15 15:32 ` Kevin Traynor
2019-04-15 15:32 ` Kevin Traynor
2019-04-03 10:32 ` [dpdk-dev] [PATCH v2 3/3] test: add UT for power turbo feature Lukasz Krakowiak
2019-04-03 10:32 ` Lukasz Krakowiak
2019-04-15 15:22 ` Hunt, David
2019-04-15 15:22 ` Hunt, David
2019-06-07 8:45 ` Hajkowski, MarcinX [this message]
2019-04-22 20:42 ` [dpdk-dev] [PATCH v2 0/3] test: improve test coverage for power library Thomas Monjalon
2019-04-22 20:42 ` Thomas Monjalon
2019-07-05 7:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7AE8A440E9E11A43ABE083B4E74B60F94CE0C6@IRSMSX104.ger.corp.intel.com \
--to=marcinx.hajkowski@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=lukaszx.krakowiak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).