From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1637AA09FF; Mon, 11 Jan 2021 17:16:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB026140F31; Mon, 11 Jan 2021 17:16:46 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id EA50D140F27 for ; Mon, 11 Jan 2021 17:16:45 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id j1so89849pld.3 for ; Mon, 11 Jan 2021 08:16:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=FQiIVNznWeoCRPawEUB1dz5BSdY3YbUlBOS008j6L+U=; b=V6RteT0YMlSXSeRgVtKTe4qP3OnHNkEFrXP/nzrh/DHOt+P76qRMRq85kCLBWQkfCV 9UWp4CYKpxR2Dy4xwp2aYBar/VuJhdRhXM7jhW6I1XVNoi282Wo7u/qE1eA/7IEtWLol RDTsOpx0ATjBoXT+AtGw7MUrkPWKlKHiG0n/3GAretszwGOSEu9KTrOM2/+nKFKaeBYj dzDGE+dgdvVzVktN0AWGB/tTiJvO7zyU3Us/dfAvByYnKEnxoHdSmP6C2E0wzTJIew88 npHi3dWucT8U4UZonVnXLjCk/Tpr5KHoPvnhsOCMw9wTaXcFx7JOLxFv5dMkmPUqC6DR gcdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=FQiIVNznWeoCRPawEUB1dz5BSdY3YbUlBOS008j6L+U=; b=i1nVTqcnBOqvjRhQJbKnuLtaBhV0QjQiUpriGZzUSKn1HrGUW2BJ2M6Vs3IBOgHQSF Z2N3eS8mbbZ8NIwKj9ReA/CO63T8Go4lZ/LxRo6Kg3s6ZW7GALKsDJSeoJdUMSj5rvP5 6N52ztr8nmp3eIq4d7rPTFjnU3yQX8ObzTjmGHygxE6KF+d5x1ysIj0tsbU6LpCE8knv QbgIz7rMZPnqD6Jmvm5geLgbuMRRCkd+S4FsLeFN4i8ykFe79l3587PRWsTaiueoWURq jy1sEyCOpAwd9F2e1J/Saixfbno7ylO0m8nQH87SSWbkwLh6yRfaVLp+ielwkiUghhAL 0QaA== X-Gm-Message-State: AOAM531S/Hyil/QgN52qX9v6wJ/DByLNn1KSjZ3s0YlsrzNl1LaCxdpl qC/s5RZDWNo9uzJX1OlmhLRxbQ== X-Google-Smtp-Source: ABdhPJwXTR7k20pfkGtIr2lMqNdPYxHevte4vBKvAtKGGTqGeqU6G4guPeR+YH3n2jsT8UNpSyzgjQ== X-Received: by 2002:a17:90a:5aa4:: with SMTP id n33mr29881pji.66.1610381805135; Mon, 11 Jan 2021 08:16:45 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:1129:cd4b:9e0e:30cb? ([2600:1700:6b0:fde0:1129:cd4b:9e0e:30cb]) by smtp.gmail.com with ESMTPSA id f29sm165781pgm.76.2021.01.11.08.16.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jan 2021 08:16:41 -0800 (PST) From: Andrew Boyer Message-Id: <7C5CEFBD-469F-4AFB-AE8A-0ACF207FB5F4@pensando.io> Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Date: Mon, 11 Jan 2021 11:16:38 -0500 In-Reply-To: <20210111100104.GA1046@bricha3-MOBL.ger.corp.intel.com> Cc: Thomas Monjalon , Honnappa Nagarahalli , =?utf-8?Q?Juraj_Linke=C5=A1?= , Ruifeng Wang , Phil Yang , "vcchunga@amazon.com" , Dharmik Thakkar , "jerinjacobk@gmail.com" , "hemant.agrawal@nxp.com" , "Ajit Khaparde (ajit.khaparde@broadcom.com)" , "ferruh.yigit@intel.com" , "dev@dpdk.org" , "bluca@debian.org" , "david.marchand@redhat.com" , "kevin.traynor@redhat.com" To: Bruce Richardson References: <1605874101-30893-1-git-send-email-juraj.linkes@pantheon.tech> <20210108173645.GD1823@bricha3-MOBL.ger.corp.intel.com> <26840311.mCdcc087Xs@thomas> <20210111100104.GA1046@bricha3-MOBL.ger.corp.intel.com> X-Mailer: Apple Mail (2.3608.120.23.2.4) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v14 00/12] Arm build options rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Jan 11, 2021, at 5:01 AM, Bruce Richardson = wrote: >=20 > On Mon, Jan 11, 2021 at 10:38:09AM +0100, Thomas Monjalon wrote: >> 08/01/2021 21:20, Honnappa Nagarahalli: >>>> On Mon, Jan 04, 2021 at 05:46:20PM -0500, Andrew Boyer wrote: >>>>>=20 >>>>> 1) Bruce - when the =E2=80=9C-Ddefault_library=3Dboth=E2=80=9D = flag is passed in, the build >>>> fails with this error. It=E2=80=99s been broken for a long time; = maybe this option isn=E2=80=99t >>>> supported and should be blocked earlier? >>>>>=20 >>>>> ../../dpdk/app/meson.build:48:3: ERROR: Tried to get unknown >>>> variable "both_rte_ethdev". >>>>>=20 >>>> Revisiting this point, since there are a number of possible = approaches we can >>>> take here, and I'd like feedback on them before we do anything. Of = these >>>> approaches, 2 are simple, and 1 is more complicated. >>>>=20 >>>> 1. We can just detect this as an invalid/unsupported setting and = error out >>>> earlier with a suitable errors message 2. Since we already support = in all cases >>>=20 >>> I would prefer option 1 here (detect and error out). IMO, the option = "both" does not seem to solve a compelling problem. I would prefer to = avoid the additional code and complications. Mostly, everyone would do = the development with either 'static' or 'shared' and test the other at = the end when the development is completed. >>=20 >> +1 for not supporting linking with both. >>=20 > Ok, thanks for the clear consensus. Will do patch to check and error = out > appropriately. >=20 > /Bruce It would be great if the error message for =E2=80=9Cboth=E2=80=9D = pointed out that both sets of libraries are built in the =E2=80=9Cshared=E2= =80=9D case. e.g. =E2=80=98Error: =E2=80=98both=E2=80=99 unsupported. =E2=80=98shared=E2=80=99= will build both static and shared libraries and dynamically-linked = binaries. =E2=80=98static=E2=80=99 will build only static libraries and = statically-linked binaries.=E2=80=99 -Andrew=