From: "Wiles, Keith" <keith.wiles@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mbuf:using sanity checks do not panic on null mbuf
Date: Mon, 8 Jan 2018 15:41:12 +0000 [thread overview]
Message-ID: <7C6B7ADB-6412-45F1-9BA0-84F1025FA473@intel.com> (raw)
In-Reply-To: <20180108073941.791cba4f@xeon-e3>
> On Jan 8, 2018, at 9:39 AM, Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> On Mon, 8 Jan 2018 09:34:23 -0600
> Keith Wiles <keith.wiles@intel.com> wrote:
>
>> + if (!m || !f) {
>> + fprintf(stderr, "MBUF and/or FILE pointer is NULL\n");
>> + return;
>> + }
>
> Calling with f of NULL is user error, let it still die in fprintf.
I thought about that too, but this routine is a debug routine does it really matter?
Regards,
Keith
next prev parent reply other threads:[~2018-01-08 15:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 15:34 Keith Wiles
2018-01-08 15:39 ` Stephen Hemminger
2018-01-08 15:41 ` Wiles, Keith [this message]
2018-01-09 4:39 ` Jerin Jacob
2018-01-09 14:29 ` [dpdk-dev] [PATCH v2] " Keith Wiles
2018-01-16 14:04 ` Olivier Matz
2018-01-16 14:19 ` Wiles, Keith
2018-01-29 9:39 ` [dpdk-dev] [PATCH v3] mbuf: fix freeing of NULL mbuf when debug enabled Olivier Matz
2018-01-29 15:58 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7C6B7ADB-6412-45F1-9BA0-84F1025FA473@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).