From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <matvejchikov@gmail.com>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id D436B9FE
 for <dev@dpdk.org>; Tue, 14 Nov 2017 21:51:01 +0100 (CET)
Received: by mail-wm0-f43.google.com with SMTP id z3so24751534wme.5
 for <dev@dpdk.org>; Tue, 14 Nov 2017 12:51:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:subject:from:in-reply-to:date:cc
 :content-transfer-encoding:message-id:references:to;
 bh=s26d32Ql9kcpz1EiFzC84wOwWjfoVjSpcdeSfjxdad0=;
 b=CG0DYUzXosoRf8Zgd1SRa10GOHkr/8VxKVmpD6VVpc+KISVcamcnSXP9s6VsXB069Z
 flTHRlY9QjZ+EYoX+gDr1y0rGrNUWw/QlUjC94NtJrZ4rr7l1Bn5QofvD6W6HFIVjg38
 HIcq+YNbt0VcVnsYXkLfVLQtr93q2BbSzyQv3Mhpes4sFJNHwfKADxhbj/+1IfPi4Pyh
 c231eTxt2RbVjc9ALBwqs0SezDFslm8eUAtPutE5uG3jSQV3AHH04WO+MhbaltAHDGQA
 ER4uYWco1pLG6AkmYM9CG7b4Hb1bWZnp7I12O+qmuDi//l7LSQSLtwVpsIUR9QYjs/ww
 0uMw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc
 :content-transfer-encoding:message-id:references:to;
 bh=s26d32Ql9kcpz1EiFzC84wOwWjfoVjSpcdeSfjxdad0=;
 b=LkkR6gCqxDD/ABb9hvPcfXAbJsQIbbOP5MnKzpVNytsUoZBnMRc//Q4dMj2j+h7Ku5
 ArBbPJv0g2prnycu4QzbfnX9pr3kA1lon2n2ayMUXLXfuUtEDrwQUHuzVuNr6kfdduqb
 5svgHBHfUhm2d/xZ7+uoDlxySBO6u1Xo9a0DBeAcaQjQ2SNzTVx0vKb4ZNzhQtycEGa0
 YlfDvGImESb44Cos0ipe3OtRr3sKQM2UqayT3zHbpEHxMGuLl7pKW7y31Elf7T5Os+Sc
 UdL4hBnZ4XzKir71czEvGE9C3U5KjUz21kmkoBodtNbuZ+OVZBvkxO9GBV5D8IS2LSPJ
 6UWQ==
X-Gm-Message-State: AJaThX7u7eM7UmPE5tkkJAg+zk+SpKkLZ7hbMVKQmiMHGSusaf40clzA
 4vPI7QB0n/FPrgiRqlQDfeVRrvbi
X-Google-Smtp-Source: AGs4zMbUgbiHf2BsTfWKlfV4Z09KFS8Ko4QVejQAfWFKkwBIudfWz8dCUdL40TR4FW2SVSdn9UOk5w==
X-Received: by 10.80.131.38 with SMTP id 35mr19083491edh.291.1510692661553;
 Tue, 14 Nov 2017 12:51:01 -0800 (PST)
Received: from [192.168.1.145] ([94.205.75.192])
 by smtp.gmail.com with ESMTPSA id r4sm18499984edd.4.2017.11.14.12.51.00
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 14 Nov 2017 12:51:01 -0800 (PST)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
From: Ilya Matveychikov <matvejchikov@gmail.com>
In-Reply-To: <c09a80d037c2438f9fb4dc5c012a4b4d@XCH-RTP-017.cisco.com>
Date: Wed, 15 Nov 2017 00:50:58 +0400
Cc: "dev@dpdk.org" <dev@dpdk.org>
Content-Transfer-Encoding: 7bit
Message-Id: <7CC49471-2114-4742-8C66-2CF286DE2CF2@gmail.com>
References: <3DBFD712-8DA6-4FDB-B139-66398039B4C0@gmail.com>
 <c09a80d037c2438f9fb4dc5c012a4b4d@XCH-RTP-017.cisco.com>
To: "Hanoch Haim (hhaim)" <hhaim@cisco.com>
X-Mailer: Apple Mail (2.3273)
Subject: Re: [dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(),
 remove useless variable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Nov 2017 20:51:02 -0000


> On Nov 15, 2017, at 12:32 AM, Hanoch Haim (hhaim) <hhaim@cisco.com> wrote:
> 
> I would add this too 
> 
> -  } else if (rte_atomic16_add_return(&m->refcnt_atomic, -1) == 0)
> 
> Should be :
> 
> + } else if (likely(rte_mbuf_refcnt_update(m, -1) == 0)) {
> 
> 
> Hanoh
> 

Why not to send the separate patch for the change?