From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Xu, HuilongX" <huilongx.xu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] about memzone name size issue
Date: Tue, 31 May 2016 13:17:32 +0000 [thread overview]
Message-ID: <7DDD04DD-C43A-4402-8C4E-704D204ABF8C@intel.com> (raw)
>Hi all,
>I find a issue on link_bonding unit test case.
>
>When I run model6 test case, will generate core dump error.
>I debug it, find the error code in function:
>rte_mempool_create_empty(const char *name, unsigned n, unsigned elt_size,
> unsigned cache_size, unsigned private_data_size,
> int socket_id, unsigned flags)
>{
> .......................
> ret = snprintf(mz_name, sizeof(mz_name), RTE_MEMPOOL_MZ_FORMAT, name);
> if (ret < 0 || ret >= (int)sizeof(mz_name)) {
> rte_errno = ENAMETOOLONG;
> goto exit_unlock;
> }
> .........................
>}
>The memzone name size only 32 bytes, but the mz_name in link_bonding is bigger 32 bytes. Could we set memzone name size to 64 bytes ?
>Thanks a lot
Having a name of 32 bytes is pretty big IMO, what would be a better reason for changing a internal structure as it will take two releases to make that change?
How big is the name string you are passing into the routine?
>
next reply other threads:[~2016-05-31 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 13:17 Wiles, Keith [this message]
2016-05-31 13:58 ` Iremonger, Bernard
2016-06-01 0:34 ` Xu, HuilongX
-- strict thread matches above, loose matches on Subject: below --
2016-05-31 9:07 Xu, HuilongX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7DDD04DD-C43A-4402-8C4E-704D204ABF8C@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=huilongx.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).