From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66149A0C55; Wed, 13 Oct 2021 18:50:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E368410E8; Wed, 13 Oct 2021 18:50:14 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id CDE6C410E7 for ; Wed, 13 Oct 2021 18:50:11 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="290967329" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="290967329" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 09:50:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="563169359" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by FMSMGA003.fm.intel.com with ESMTP; 13 Oct 2021 09:50:09 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 09:50:09 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 09:50:09 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 09:50:09 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 09:50:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mq8LsLDhezkBDoytMrc3TjJsOXyIH84dQusne3zrtntrD75iPhDXjsFyoimJCoqS/flWXzdY2Sy6nqRH3zVdiN7pDSjmKDIpLq6yZBNHAJN3inCCCFMfNPrC3PydCl584poFTRtBthpKy2tn7X/6D5iYYDlVvR66rtk2ukKzT70vHQKoigsRDNTsLizOUVbmRCFHchAm/WbFtCNaHTPRVAvYro/WTc7tkPDu8jGWICTInOeatS3s1ebb8kR59A0w+3fJbUcdUP/9Efspn6AcH3LBr+Y+0lZcpsnImsgtquXi86WWilBtsfmD5oTZFxxyLhoCbD8dY3qVdYsu2+PGag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s93aBy+C9jgDfBWhVq2Btq9Al4a+KalxB0njWM34nZc=; b=jB0R9wvMKi6uOoQ14O26MoXlUrHhblj1Hl9AwVG8ngdlYDF1jnQVSMKSXkiMUhUyGtxGJotCdfUDRqHL33hoL7vhJ0gesc6KiO0gJhzeyX9FIHa+wbMrvVKGLGogEcv3wQR1qo5q+jiPfDsq+m3mjX6hlT9RyYaA54gqWGJWyWLzBrJWIGj87is7bl1sMQ/fKyzJds7Ct06k7A3nPkuUDiTSNTEOUp8mKQuLZBImPBxkbw/nWfS6fCMczAAwDfBhPROYylOi9YPksnvtaHx05mkBGL4XXuRljPPXulbKnQ+mmTTu6XxYtXBG8QJJLvflyls1qNi1C+DR7m4LIOehuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s93aBy+C9jgDfBWhVq2Btq9Al4a+KalxB0njWM34nZc=; b=eUN56TKWySt6FIyg2DD1W6uAjRyEwqTiv0ERLGqCyFcwESXT4bshBu6fxR7J/oObanvZUtkBffI0VzrbGH1/kfk8+Yh4ZMjxAX4kKMzGjAstSG/C75moTRzmhNSRidMVCk0iMWXfA3cWhs0FeGitK93OvROvIuebrioW0Pnd3wM= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4823.namprd11.prod.outlook.com (2603:10b6:510:43::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14; Wed, 13 Oct 2021 16:50:08 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021 16:50:08 +0000 Message-ID: <7a132d0d-9172-e3b5-2d09-b201fd46e89e@intel.com> Date: Wed, 13 Oct 2021 17:50:00 +0100 Content-Language: en-US To: Andrew Rybchenko , Igor Romanov , Andy Moreton , Ivan Malov CC: , Raslan Darawsheh References: <20211013152027.2480175-1-ferruh.yigit@intel.com> <6cfcbf83-5b8c-cb6b-0414-410f473efd96@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <6cfcbf83-5b8c-cb6b-0414-410f473efd96@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0202CA0038.eurprd02.prod.outlook.com (2603:10a6:4:a5::24) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0202CA0038.eurprd02.prod.outlook.com (2603:10a6:4:a5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Wed, 13 Oct 2021 16:50:06 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 163870cf-285d-4e5b-774e-08d98e69837b X-MS-TrafficTypeDiagnostic: PH0PR11MB4823: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ya3DRSFExN2yoV9SqVrvn49l8RJVFSkZ3qqhuWHU58+Ohx69IfPv0UGzDmwJ1nJd47l9Sye6FtKKn092mrRiHRAypYTZOa8sHh4aP6BolbQbSHoMFw8nacG//eb43MlxWIT3RlsvCcjRhAxpwbkZtxXv9ul57nChvMSicMiWDT9S3jB70qKPwDeaHhTkNShk2f0kfbHbfp4tnM+1kGXxk2uGiGkutFjIdPyc3FNTMsRyw+Km7LkYzijhu8XJDhp5IRuXd54zKzGTzYvnbBGwniyejkuHovnP7LZDqEfVk0KHstYZmwcNwyAMp9IUpZMr70BQglZpteEE17PIh1xeX9sNMHwhnx2r5j02wafYM9IG/nnhcHaNOFH+CYzDzfq6Pb5qzV63U43tOsaTi7Bomm6qz5awri0OWjH4lIZ9rdDNkIwKvmtaHhRqhCKjkQF5uY4VFlSQ7/0L0IhvIsQ0DXKrpXEd4cMjVyWLSGr9uJkXugXh7GL7rMkCbKuVKkfiahxdgMoQAJuvaL8WVpd/WARN2iKdtf+cPXLlB8mYjHTDSVmY3UlNYP1nHCB7GPLuXfeHEvix7UDrKwgyixD3b3o9C+GdiN5JEEKDmu0kJrNwnN+Xpf4Fmmajfy/5D8wuYtImP2URFaj0lu/Fky1Eq7VCGj0QzFrjf45/H2CZj5yP90xc5TqP6yYRHA5gMIt/6m7HYW3iufjc80pdNKlC3A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(44832011)(4744005)(83380400001)(6666004)(956004)(2616005)(26005)(186003)(8936002)(66476007)(316002)(66946007)(5660300002)(16576012)(66556008)(110136005)(508600001)(2906002)(6486002)(4326008)(53546011)(82960400001)(86362001)(38100700002)(8676002)(31686004)(31696002)(36756003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEE3cUdBMUtKKzJiSkNSaGE2SThjUFZvYitMTzJCYy9jaHFCWU00Y1Vya2w1?= =?utf-8?B?djVWb0J4aE0wZE5vWGthV05YeFdWRmY2SmZJeGFMVGxsOGxGNm5URlNwRngw?= =?utf-8?B?SVk5STk3NGFhSHdUQW4vV2xOOE1USWpIeDg1ekhiZWhqNFg4TnArcGR1NEdR?= =?utf-8?B?OTlhb3RWeDl4RzlYeEVTY09Id0QxaXV2V1Vna3FFYW0vWUFxZnR1R01LUFYw?= =?utf-8?B?RkJJc1lmR2tJTWFZcUkyMEtkKzMvNHV0Y095Qzl4VVowM1ZwdzJUaCt3Vldv?= =?utf-8?B?WjlSNkR1RFI3cko5aExtc240ek11TUdjRHZST2h3YUtUdDEvNjBKV3l6SFZy?= =?utf-8?B?WlNnVTJkOVovUHJCSnp1UE95ckQrTlltYVFSTEsyWjcrSzE3SGJhQlJBUGE4?= =?utf-8?B?ZlJUaWpGZDhWZFZUNTZlRFlBOTBmcC9hbDEvbnlTNS81NGpCUllVSlJBR3dK?= =?utf-8?B?NThQSXVVMCtaV0U4RDBLVlhZdTlGc080aGtUakU0Nm5mWFQ4UDJvbkpyM1pk?= =?utf-8?B?eXA5NmY1WFZDNElZMzRFWjBteFVaZldYVGVGZWV3Slh3MEx6aE92TXEySmRu?= =?utf-8?B?QURzQkVNME1LZUJSaERuRzhnNFNVYUNhZjBaQ2JCZVNzNllEWFhrbmRDTVZL?= =?utf-8?B?aW05L2dXWkZpWUNCMk1SWUJOZE1Tcjk1UWNNY3o4OEZpSExpM1Q3SFJQZVBZ?= =?utf-8?B?ZWxGS1hvV3l0SjZSUEkrZ3htR1JFTHFsYmQxNGV0UndJZ1V2dlpYZmF4YVps?= =?utf-8?B?NW1ZWnpwaTZIRk4xeVhJRldvSys5bFJ4RHNDSzd0VC9aUTg4cktYM0VYNTVl?= =?utf-8?B?dzhGbGhudkViQ3hKQlBRT25vRVFHd0cxdTJOc0lYbUtua2ZJMlNPTmpGZ016?= =?utf-8?B?YzIvZGpxOGtXS1IvN3Bia2NwVitENUYvRkxhSE95QVRDZng2empJc0V6UmRp?= =?utf-8?B?YzRsc2VMcXNoZWpYaDlpeGN5WXFiVm9FaG1jdzR3dkpwVHp1amFEb3RpMHps?= =?utf-8?B?dmpDQ2p6a0hzZUQzUTFIU2JDQjVHVi94SDBUWEZuUWk5Vm9idEdJS0FpRW44?= =?utf-8?B?bVlxR0tqZjhraWJobExIM2drb3RzaW9EbjUrRjB6ZmNRbGFqaXVEWURsdUky?= =?utf-8?B?RDZmR05TMTRoOTU1Mk1RMjBxTEFyemVydTQ2azlwdDVLTDhlMGN5RVJsczcv?= =?utf-8?B?QWYrQVhjWEFoWlZPb2lMdy9wZ1RndHNUOGFENHZrTHdqVXh4V244d04zS2Vi?= =?utf-8?B?N21qOEFSODNxM0dEN29FZmhZSzh1R3hteTNjdkdNMHNBOVBrQkdkaVgyOHVT?= =?utf-8?B?d3dyL29FQ3d5d2ZWVUt5R1R3VFRJRC9Nb2ZubWFjSnpyRWViTXN3c2t1MFBn?= =?utf-8?B?c1MvZDgzeWFsTkowZFZkOHRuU1lwSGN2c2xmeWJsK1JaRjlqa1ZiaHZFZkNo?= =?utf-8?B?U2I5ODVoOGpmK0RsREVpNkRPYm5JdDZ3ZnV0dEhJZmo1U3U2TFB3b0FTZjBw?= =?utf-8?B?WkZtSEozdmlMenkvUEtKeHRzZDFVNXBmOHRTUzhzOHRLV3pRb0xPa0s1bkJV?= =?utf-8?B?eTFMQmw1N0xsNUJDZVZmSjFrZ1AyVk9kN1FqaU9xajZPejBSWEMwaVN3STlZ?= =?utf-8?B?ZkdhUnR0WUVzTC9CL0svL1RTb2VoMGZ3NG94eTkvekZncUZvUTlwL2hWZFht?= =?utf-8?B?VGJBemZMRVE2N1gxeHEzSmptMlAvNytJRHlXMDhqOUZ5UGFWaHVPK01ZL3VF?= =?utf-8?Q?h/wfaSMu2G1u+S51IZ5pKSZ2loSTabz+Qzrl+CH?= X-MS-Exchange-CrossTenant-Network-Message-Id: 163870cf-285d-4e5b-774e-08d98e69837b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 16:50:08.0741 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DsXQZBSFJVLU5/MewWUttMa/ik1ifx09y76lZ+4zOqNf38szqo+AvwKQrQQ3cOapRu1WGhJV0MSH1W7nNb7saQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4823 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/sfc: fix build when assert enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2021 5:35 PM, Andrew Rybchenko wrote: > On 10/13/21 6:20 PM, Ferruh Yigit wrote: >> When 'RTE_ENABLE_ASSERT' is enabled (meson -Dc_args=-DRTE_ENABLE_ASSERT) >> build fails: >> ../drivers/net/sfc/sfc_repr.c: In function ‘sfc_repr_start’: >> ../drivers/net/sfc/sfc_repr.c:251:20: >>      warning: implicit declaration of function ‘sfc_repr_lock_is_locked’; >>      did you mean ‘rte_spinlock_is_locked’? >>      [-Wimplicit-function-declaration] >>    251 |         SFC_ASSERT(sfc_repr_lock_is_locked(sr)); >>        |                    ^~~~~~~~~~~~~~~~~~~~~~~ >> >> Fixes: c85675423f01 ("net/sfc: implement port representor start and stop") >> >> Reported-by: Raslan Darawsheh >> Signed-off-by: Ferruh Yigit > > I'm sorry for the breakage. I've sent v2 which avoid usage of > conditional compilation in function body. I'd prefer to fix > the problem this way. Yes, it is a bit less straight-forward, > but still preferable. > ack, agreed that v2 looks better, I will test and squash it.