From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4335A3295 for ; Wed, 23 Oct 2019 12:19:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9CCE41BFCF; Wed, 23 Oct 2019 12:19:28 +0200 (CEST) Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by dpdk.org (Postfix) with ESMTP id C9D2E1BFA7 for ; Wed, 23 Oct 2019 12:19:26 +0200 (CEST) Received: by mail-lf1-f68.google.com with SMTP id g21so14488135lfh.4 for ; Wed, 23 Oct 2019 03:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+OxE+3gyxC9W2mR6u3AWmB7JAs41XIHNirMndfxgAY0=; b=MHB2yQZF5lEvYb2fRdV2kbXmIyb9V266VgJsf2z5Lb+tuDjyfxi8AIdo9Uzsl+cX/v BuIl2Fmn76PUTBkQ+9pvGS1IZBg7kaN6dT893oTVtxDXLR+DrRiDAYMqKZc/an36YMef xvg4CROwWcg1wtmepy494Zeyn2vBVM8d6+p83/pNwf1ZFBTj1lBVXHhXwdImNqTaU+RH 4VDRt1l3J1j7Bn4oqGyrHbS7ShPk5UXp1r2XoIgSP5QhNwhYeTOevs3cozzXy/nS9HQ4 oZI1s5dIAhaWcGDhksm+7uo7opZY6aHDq5NsuILO+3fHidxRtqt/+b99xYz6XBRZCfMg ++hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+OxE+3gyxC9W2mR6u3AWmB7JAs41XIHNirMndfxgAY0=; b=GcgqRe7h+rgVhR0F8Q7RWiB+VIP70xE0OLpk3rb9FnmGLkWiyyHFx5BAMKgblFbcwj uaOFQBpmfJgQ6kLAmuWIACiHaYuSxZbOSLvtoISYQzH1QWwIJtEVnGPJAalEPygwzVzj HcthUMgKDEV4EQ2iWxZE47f2cGYmCHcPCBWnZ5JS86jhmtl6mFlvdyV5zy3N60UmmkQS jKvAuzLArq79649ZV2c4uF0Z/Vq754NT0UXFTFzqI4GzJnVM4dKDOI3SgIMBBz4icSPY RQpNILZ474JjIUeYt96Vbq8vTHSXPEDlkzkB3s5JWlPZaG4ijfpptAyGWdE7deENRTXI QcDA== X-Gm-Message-State: APjAAAUQCXbesxIjCi0kVjUfPCAVIiY/sAtoiNa3Sqwr3AEgyEXX4Udq 4AvQ4WL/M07hWSztcWCrcX5QSg== X-Google-Smtp-Source: APXvYqyp6NiXS1AORQ/O1oJKYfJHRpkJVYOMgQgsyJrLtEpNp3i8DcXZSt/ghBDZe79McUVrG09vUw== X-Received: by 2002:ac2:5111:: with SMTP id q17mr13952440lfb.165.1571825966309; Wed, 23 Oct 2019 03:19:26 -0700 (PDT) Received: from [10.0.0.72] (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id e8sm6330838ljf.1.2019.10.23.03.19.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Oct 2019 03:19:25 -0700 (PDT) To: Bruce Richardson , dev@dpdk.org Cc: Neil Horman , bluca@debian.org, thomas@monjalon.net References: <20190927194932.22197-1-bruce.richardson@intel.com> <20191007154550.46655-1-bruce.richardson@intel.com> From: Andrzej Ostruszka Message-ID: <7a1d3f66-a99f-2eda-b6c0-990d82d39ae6@semihalf.com> Date: Wed, 23 Oct 2019 12:19:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191007154550.46655-1-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 0/2] Improve function versioning meson support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/7/19 5:45 PM, Bruce Richardson wrote: > Adding support for LTO has exposed some issues with how the functions > versioning was supported by meson, which was always set to build both > shared and static libraries. [...] > V3: following feedback, moved the define for make from the common_base > build config file to one of the global makefiles, as it's not user > tunable. > V2: added in file that missed a "git add" when doing V1 Reviewed-by: Andrzej Ostruszka