From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 262B441C43; Wed, 8 Feb 2023 21:10:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EA4F410EE; Wed, 8 Feb 2023 21:10:14 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2064.outbound.protection.outlook.com [40.107.95.64]) by mails.dpdk.org (Postfix) with ESMTP id A53A341151 for ; Wed, 8 Feb 2023 21:10:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bngFStZ92q87xwAN8anAYGuuWmTpSZuH5PkeFYGNauF98Oja5oAqfUNM4hhwlwG5POuEhJ12noQ/cPsXg4e/2Xq17P2ShYHvKvUA/CAR1SnFutO+aNn9qRrPNu3Yy6rfhhStcyIZeQZ2I6WLG3Ri6bJwlTzdewWlSHGzpC5XsEvNTS5pxJSCrMGM4krq2QQgvzkxMAsWvoU7AER/4fXEOE7gDhcSp9fCIvvEq/CqStv7X4uN6Cs/Ge02g5Uf1QPt955UZdRO61Z8zOrf5TjfsBTFcnHqGA8CJGdCmk41V0pcO+slRPGMThdT2RvsC5sjio4CRcnnPSWDkpbXS/f3qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vD4FAzLHrEZi/oxeR4PZgiurpnrYFSw45o8PJT15lys=; b=U+brtivEFzClEwvuFdCuG2AKYwrhXrBtYumpcUjKAj4cK8WBgeV87fbm8RdAyXyLOLD4KxxMgrg/Am25HvDS6qrqkLdYqS+ObeeJc1Jzpg1UvSWQL0y5pM9dCoQj0vcPI6s3+5sARbQuzcyMjHe71Y+UAv3bj/29kxi/1XvgOtey30FG6R/UDrekGjlkPo8SBQmxliZMUkz5bCw9admJNBgi2Tc6dn2tRzDMDFzIn1AtcT78aBic1Wpfc+1dD2kPRTYtFEgVoGfU7HM4JAs9c+7SrHi5/ma65ItsX4hQNzitIfUEltdD5c/SZFnOtL0hnGvilr+m8IquJuRYCxHmZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vD4FAzLHrEZi/oxeR4PZgiurpnrYFSw45o8PJT15lys=; b=xMSeIMVC8/dftnyEYoK9DRXY5B3uzmu8t5/cj1RAgoHKJsNxH1v3JtFw4y6FY6tcWeEABIFKuvmAs9crVKzH0+MRhBNU1grF1+eR9ouRPD/UCatcHdYO1Lscjrqjg0XofgpcLQD+NatIFMUkbMax6wul/rCU0t/GrBRu45qPekA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB6901.namprd12.prod.outlook.com (2603:10b6:a03:47e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.35; Wed, 8 Feb 2023 20:10:06 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%6]) with mapi id 15.20.6086.017; Wed, 8 Feb 2023 20:10:05 +0000 Message-ID: <7a24e933-88f2-674b-5636-fce3d49b7e1f@amd.com> Date: Wed, 8 Feb 2023 20:09:48 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v11 0/6] add trace points in ethdev library Content-Language: en-US To: Ankur Dwivedi , dev@dpdk.org Cc: thomas@monjalon.net, david.marchand@redhat.com, mdr@ashroe.eu, orika@nvidia.com, chas3@att.com, humin29@huawei.com, linville@tuxdriver.com, ciara.loftus@intel.com, qi.z.zhang@intel.com, mw@semihalf.com, mk@semihalf.com, shaibran@amazon.com, evgenys@amazon.com, igorch@amazon.com, chandu@amd.com, irusskikh@marvell.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, jerinj@marvell.com, mczekaj@marvell.com, sthotton@marvell.com, srinivasan@marvell.com, hkalra@marvell.com, rahul.lakkireddy@chelsio.com, johndale@cisco.com, hyonkim@cisco.com, liudongdong3@huawei.com, yisen.zhuang@huawei.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, simei.su@intel.com, wenjun1.wu@intel.com, qiming.yang@intel.com, Yuying.Zhang@intel.com, beilei.xing@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, junfeng.guo@intel.com, rosen.xu@intel.com, ndabilpuram@marvell.com, kirankumark@marvell.com, skori@marvell.com, skoteshwar@marvell.com, lironh@marvell.com, zr@semihalf.com, radhac@marvell.com, vburru@marvell.com, sedara@marvell.com, matan@nvidia.com, viacheslavo@nvidia.com, longli@microsoft.com, spinler@cesnet.cz, chaoyong.he@corigine.com, niklas.soderlund@corigine.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, g.singh@nxp.com, apeksha.gupta@nxp.com, sachin.saxena@nxp.com, aboyer@pensando.io, rmody@marvell.com, shshaikh@marvell.com, dsinghrawat@marvell.com, andrew.rybchenko@oktetlabs.ru, jiawenwu@trustnetic.com, jianwang@trustnetic.com, jbehrens@vmware.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com, steven.webster@windriver.com, matt.peters@windriver.com, bruce.richardson@intel.com, mtetsuyah@gmail.com, grive@u256.net, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, jgrajcia@cisco.com, mb@smartsharesystems.com References: <20230208132824.775985-1-adwivedi@marvell.com> <20230208171215.787063-1-adwivedi@marvell.com> From: Ferruh Yigit In-Reply-To: <20230208171215.787063-1-adwivedi@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P302CA0022.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c1::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB6901:EE_ X-MS-Office365-Filtering-Correlation-Id: dc249acc-3097-4c78-b53f-08db0a1077d0 X-LD-Processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PEhQQK/qkdIfywF3k8UQKBn1on2RbR8KUo1pmrYcHihOMtWdPo80bL29pzwMEkm0TCBmwuFf88kWv4MzqojYH2bvXTWyPjMsVQdLY659XZRwrahVaDCBbYaYr9UQykhXttSHnsxSyq+i9rOh4jbILYVxlqshw/GfkZWj+Vvmn6eLycYJreO5gsazioeWFQJIimJk+4ZUPBRaFSEwxAr5Nh8EYC0WB7bH+gz4ehDLywg5HFIxAeXJG7taRBAHUds/N+Qd9axDe8aEYjqqgIUA2FgL6gFO8b2uIs7vKTFpGs//byXofqI2ZvsfdSBCGbi8Nqpw+pPt5FrQUKZLMHqaFIEc+pmIHoWlxnRMgVcnenAElchZrRjcpHFBDYF3+kG2GXFUrBE4PjYeTejfuK0Q+CU149x0SiO+nRiCmyLwqXOFJryqz14AQLNAVPnVAZTO9Gh+zIrGCaX3bzv+cyg+1/nqZ0A4Cmz2LlOhNSk5kve8+PXUwEWw0U+LtruwPUU+wkJ254UNkLWEpif0NBzM0zEgkYa29IYPThl4TkUkEPrN0JTioGNUh2dlEgGD2rtgfmjfgWt9bbVoH9aA4Cjivt0svUn+uMAV8pfbkXw4dTH3Q5NSNTzJnRnmkIWR8b6L7pAmTl7Al+5hwfwZ063IU5EfbVKNuhfm9hOCL82qm/8pJUFLNaUZCq9yVMTRr5Tct3YWdyBgnj6O6DATT+sAkTZoy9m/GL7d4Toh2kpBn24= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(396003)(136003)(39860400002)(366004)(376002)(451199018)(7336002)(7406005)(6506007)(86362001)(5660300002)(7366002)(53546011)(7416002)(44832011)(66556008)(26005)(6512007)(31686004)(186003)(8936002)(6666004)(2906002)(66946007)(66476007)(4326008)(8676002)(38100700002)(41300700001)(316002)(2616005)(31696002)(478600001)(6486002)(36756003)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yzh5TktRcTcwakN0YnBrWTVTZHRyNjdJamQrYmtMdUVWZnJHbFU5eVMvenRz?= =?utf-8?B?ZDhkK1JWaE5iZEozZ0o0SHBxYU13cmdnK3JRaUd5Si9VNzlOZDdUVHJSUUVx?= =?utf-8?B?bDNIWDN3L2E5MWRFa20ra1gxSTgrRHpUeldvSDlrM3A0QkhFdWhNSGs4NW4r?= =?utf-8?B?d0xYalVJYjVsRDhqeE44UCtMSjhYcHJWSXBsN01DOVhXOXI3UDYrd1FHZlZV?= =?utf-8?B?ZjNoZzRqeVNvdkpSSEhpWGxxZEtrbk5FT0FQQVA1d05lWkZEdnJKRHJMYWRq?= =?utf-8?B?MDgvSUZLNXFRY0dUK1VtRUxzRndaUmV1NjdOdnBXR1NVRnh2VkVIWGtkUFpa?= =?utf-8?B?cXZqVHU1cFNhTkJLdjVRZmx3SkxIZU16cnRkUG05RWhSUDBVakdoWHNiVzlZ?= =?utf-8?B?bUZlbm9ERVorcHl1N2NOT3N0UVRuZEFlUDREQUZEQWpSWXRDTTZTQmhMckxW?= =?utf-8?B?NmxKUnR4Qjlrcmo2WWUwTllMSFpkL2dsTi82SHB1YURwNFpoNmxqcVdjL0xB?= =?utf-8?B?c2tXbFRTd2lXb1hKOHY0V1NaeDJxdGtjbHZpMmllWXB5ZnY4VTJwOXUvcWJV?= =?utf-8?B?dlYzT0lkYTQyQld1STVnbytJWWx2RnlkajZSNWdteGdqZU45ZjRETU5VdlFi?= =?utf-8?B?V01ybFN3K1NXc2p2MWZzSW1YUkh4Q2plTHVjazhEUXZjYUR0V0xMUWhSUVZT?= =?utf-8?B?QmVCN1RxME1WaDNzYmRIUkRjMVhyTnZUZ285T0tZcEczMXJIY21oWU1yRUpR?= =?utf-8?B?ZnFFOWtySWpBb3l1bWh5c3pCUytKdGxvejF1L2tsUERJSkFHZ0k2dWl6bjV1?= =?utf-8?B?cnZUeHF0ZVY5SThxUTFlNDEyRmpRL0MwV05KdWRJcnpRS2d5a1BNalp3ODIw?= =?utf-8?B?NXgzZUhFVXBqcjloVjlBWTdvZHR2Mm9zV0VFT1dveDVBSWx1L0ZxM3N5ejBB?= =?utf-8?B?YlBPM3pmOHZYb2FqTU13YnptUGxUbVB0VDZBSUhmSUN1a2hUMXVpNmZYWkRz?= =?utf-8?B?bkx2UlFGTHB5TktpQTRwRjZ4Qy92VlZnc3VURTRqSm11UGsvMkl1dTdXVUxQ?= =?utf-8?B?ZUYrVEZHU1M1TnRZOXNvY015cTV2dmVEeVZQQXVTemFYcVhzRWN2T1Z1RXMz?= =?utf-8?B?UjNqZTBVNEZiNE5sSUJsWUQ4WFNJRTNESlU5SmFoR2hSSEp3ZDZ4dXJvZnFl?= =?utf-8?B?UWtqWi80eTR2bk1XSjZHcHpyaHNtWmpaUDVSQ3pQOWZ5eGN2WXR5Z3ZkQTdY?= =?utf-8?B?VzRaZWR0MGRKcjlxeTUrcTFPVFpJL1BFUkpzUkxJQkttZzR1RkZ0TGZxUHF4?= =?utf-8?B?SlZZUmlhSWVVNlBqWnJvM0s5OHdNYnVWOHhDcENiN3IxdFU5UXcwcktyVkpy?= =?utf-8?B?WGJBWmJFWUhhelhkb2VKZ1lZYWQyVnRTVEx0UStXZ2pUempGNHBDV2RkaEFr?= =?utf-8?B?RHpZVW5kRXZ0WmpocE9yWnJrMG9iSVhHN3JncVhDb0orQ3NEMHk2Nm9idzhs?= =?utf-8?B?NGp3OXJXdjVIMUlrSjcwRkNlRWNMck0wQlA2SmtVNVBkNkFwZlB3WGxOcXZv?= =?utf-8?B?Ymt1ZmhxRlRtbER6WHR2MEZTaGVrUDVKaEhJR1pVVDN2T0FpUWt3bkk3ano1?= =?utf-8?B?eCtlN2lTeUlXR2NGMVMwMFQ5ZmZkSHFEOXlLa240VC8wK25sUDNPOGcyeFU5?= =?utf-8?B?eWJBYzZTbnZ3SFB3SjNKUm5Dbml2RXZwNjBaNFJlVlNPdVlHVUpnY2RuaVV0?= =?utf-8?B?WktXZkZDYXVHaHdVQnVWTWc3cllNODBqUVdkaklkM0VKUUJxalZzK2ZuUjBG?= =?utf-8?B?QWY1TXNrM1BIc2VxR29DNGhLb0VrQ0ZGSyt4R3RPQTNrUUVhb0dtNGpEYkt1?= =?utf-8?B?Ui9UaUNNcGNpTFI1YytBSFl6Zm0rS0lrK1dKbitDdmp5QkxFRTRPaWk1K2p1?= =?utf-8?B?eCtRWlZqcDNFOXpZWjdnUkpmRGJvZFVGcmtLdHQxdmFUSC9EVkNIQzRDcTBt?= =?utf-8?B?S1NabGo1bXBCUUJqSW8xSFRwVkwxNDZla3FyUVhxQnlpTi9IOVgxNUZXTVhH?= =?utf-8?B?SWpaYWVNUkFkbDkzT3lQVWZjalhUSnAxaTFoN3NSSXlqNENiOTFuV1FQVUhi?= =?utf-8?Q?RXhW9YZFt8P8IPmfJ5iV6Wb0x?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc249acc-3097-4c78-b53f-08db0a1077d0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 20:10:05.2427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v6BqgO68AgtiA/8EH6M7rxSgw4/rTxjJigG5cTuohXE97T9yq0jpYSVS3zrLezNF X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6901 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/8/2023 5:12 PM, Ankur Dwivedi wrote: > This series adds trace points for functions in the ethdev library. > The trace points are added in ethdev, flow, mtr and tm files. > > v11: > - Added rte_trace_point_emit_blob to capture mac address list in > rte_ethdev_trace_set_mc_addr_list tracepoint. > - Added ack by Ori in patch (4/6) ethdev: add trace points for flow. > > v10: > - Removed const in basic types in tracepoint. > - Removed capture of pointer value where some fields in structure are > captured. > - Resolved RHEL 7 failure: > ../lib/ethdev/rte_ethdev.c:3260:2: error: 'for' loop initial declarations > are only allowed in C99 mode > - In patch (3/6) removed next_port and last_port in > rte_ethdev_trace_callback_register. > - In patch (3/6) simplified the return logic in > rte_eth_dev_priority_flow_ctrl_set, > rte_eth_dev_priority_flow_ctrl_queue_info_get and > rte_eth_dev_priority_flow_ctrl_queue_configure. > - In patch (4/6, 5/6 and 6/6), removed capture of structure fields in > tracepoint where the structure pointer can be null. > > v9: > - Added __rte_eal_trace_generic_blob in lib/eal/version.map > file. > > v8: > - Resolved review comments on ethdev patch. > - The file rte_ethdev_trace.h and rte_ethdev_trace_fp_burst.h(added in > this patch series) is removed. The file ethdev_trace.h is added as an > internal header. It contains internal slow path and fastpath > tracepoints. The rte_ethdev_trace_fp.h contains public fastpath > tracepoints. > - In patch (2/6) removed extra call to rte_eth_trace_find_next with > RTE_MAX_ETHPORTS. > - In patch (2/6), added parent argument in rte_eth_trace_find_next_of(). > - In patches (2/6 and 4/6), provided appropriate data type to bit fields > in following tracepoints: > rte_eth_trace_rx_hairpin_queue_setup, > rte_eth_trace_tx_hairpin_queue_setup, rte_eth_trace_link_get_nowait, > rte_eth_trace_link_to_str, rte_eth_trace_link_get, > rte_flow_trace_pattern_template_create, > rte_flow_trace_actions_template_create and > rte_flow_trace_action_handle_create. > - Tracepoints moved from fastpath to slowpath in ethdev, mtr and tm. > - Moved few flow related tracepoints to fastpath as suggested in review > comments. > - Added const to the pointer parameters in tracepoints. > - The following tracepoints are moved to the end of the function to > capture return values: > rte_eth_trace_link_speed_to_str, rte_flow_trace_conv, > rte_mtr_trace_meter_policy_validate, rte_mtr_trace_meter_policy_add, > rte_mtr_trace_meter_policy_delete, rte_eth_find_next_sibling and > rte_eth_trace_speed_bitflag. > - Removed tracepoints from version.map file. > - Formatting changes. > > v7: > - Resolves build failure. > - Changes in rte_trace_point_emit_blob() function in rte_trace_point.h > and rte_trace_point_register.h. > > v6: > - Resolves compilation error with 32 bit build. > - Resolves a bug found in v5 in the trace autotest application where > the traces where not getting generated after the first blob test case. > The trace size needs to be known at trace point register, so a dynamic > length array cannot be implemented with current implementation. > So changing the metadata of blob to make the array as 64 bytes. The > length will denote the blob length(passed by the application). The > trailing unused fields will be set to zero if length is less than 64. > > For example, the following is the ctf metadata created to display > a mac addr array in rte_eth_trace_macaddr_get(): > struct { > ... > uint8_t len; > uint8_t mac_addr_addr_bytes[64]; > }; > - Minor changes in the subject of patches (2/6) and (3/6). > > v5: > - The rte_trace_point_emit_char_array function is renamed to > rte_trace_point_emit_blob. With this function an array of > any length upto 65535 bytes can be captured. > For example, the following is the ctf metadata created to display > a mac addr array in rte_eth_trace_macaddr_get(): > struct { > ... > uint16_t len; > uint8_t mac_addr_addr_bytes[len]; > }; > - Added additional test cases for rte_eal_trace_generic_blob > test case. > - Capturing of return value of a function is added to tracepoint > for flow, mtr and tm patches. > - In ehdev patch (1/6), removed extra line. Also added rx_pkts and > tx_pkts pointer in trace point. > > v4: > - Adds tracepoint function to emit char array. Also adds the > test case. > - Resolved review comments on "ethdev: add trace point" patch. > This patch is divided into 2 patches to minimize per patch > size. > - From the earlier version (v3), few tracepoints in ethdev, > flow, mtr, tm are made as fast path tracepoints. For the > tracepoint which i was unsure, i have made it as fastpath. > All the fast path tracepoints can be found in > rte_ethdev_trace_fp.h and rte_ethdev_trace_fp_burst.h. > All the slow path tracepoints can be found in rte_ethdev_trace.h. > - Capturing of return value is added to tracepoint in ethdev. > For flow, mtr and tm these changes are still yet to bde done. > Will do it in the next versions. > - Moved the trace functions from INTERNAL to EXPERIMENTAL in > version.map. > > v3: > - Moved the trace functions from EXPERIMENTAL to INTERNAL in > version.map. > - Moved trace functions call to the end, in ethdev and flow trace. > - Added code to print the input value of features in > rte_eth_trace_rx_metadata_negotiate(). > - Added code to capture return value in flow trace. > > Ankur Dwivedi (6): > eal: trace: add trace point emit for blob > ethdev: add trace points for ethdev (part one) > ethdev: add trace points for ethdev (part two) > ethdev: add trace points for flow > ethdev: add trace points for mtr > ethdev: add trace points for tm For series, Acked-by: Ferruh Yigit Series applied to dpdk-next-net/main, thanks.