From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18791A034D; Thu, 27 Jan 2022 11:40:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D362042785; Thu, 27 Jan 2022 11:40:56 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 0A57A42792 for ; Thu, 27 Jan 2022 11:40:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643280055; x=1674816055; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=La6kcZC9cdDPsiP0UO4QrOiDZuFq7xziyd0epS5lMnQ=; b=h0d2frUUUAgVFjnBwBfglleEDvISgqQM0TnFuZ0LkEas2lijtdDJ3QKu GTyw0a1Uu4uLj86KLzaRveFID3Gc0d/zKBf3Dp5k0yMWDzmTsWPG1Kpru Com29piwgEf8fwwqQBYrN9pBSZYgo9DZJo2p3pkIPtKPODYhOHzpyQgN3 klSSesquuS5hM7bBLSaQcxmciSRUC/u/xAtjQyJLWigSpYm7xkav36GDN J0jWjIaRN/fi0nuerf7R4D+1Xx1v3n5ONbXT2lZNhY8TypjahpOVEYC4A 86tDMrK8HD/4IMIutco/fNVXWwyFI6Nghw4GnnmdBu/bKr/mvDrlSmhDq w==; X-IronPort-AV: E=McAfee;i="6200,9189,10239"; a="310127625" X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="310127625" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2022 02:40:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="767462136" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 27 Jan 2022 02:40:52 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 27 Jan 2022 02:40:52 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 27 Jan 2022 02:40:51 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 27 Jan 2022 02:40:51 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 27 Jan 2022 02:40:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZRIhQDFwDUTTsgtY7Vb61zRw691KdZR6o+Y1Sy5hXx/wREFft1sdo7TDsANQgvpTVTmPxGEkrPFrc0Rlo2XdoFKwj3t5c6NGQJ62TfwywK/yP+otMwO2fklfK5LgME5U0zhFXFjLNgcMriP62QaYjI+zySdAGCY6Y0T/0whSjCV+j2AqfAiTkDa/N1TcE7Dzsjlljn4jOIqr9wlXAd9mq3klyL+f5WmP6Ao905Z5GHjdHRVuKzm9lCtGUuq2l8Ao8YprGEKsgka/DvBL/dXRV663vAL54qKyWJPuZSTLKidrA6Mnjjc0g7VMZyiP54BMcoCvwjU3hH4jPYmkFUsdPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hPu/ob20nJVcyJ2g9S8DjJxiym8kXnMq51O23NvMXvA=; b=bstukWmIYrsHGOuqU6JAvlalPZ50iHvEmZdBDSCiPhilOKzovYsiSdmaQRrMoGSbHNtYtxplgBwT/cQALsM0IQphEcaSPJYRlLt/iKG1Fb1JABgdycAkYCiMAun4o5WAhUg4fNK47A1d89SS90Z9PAeXKTIuOAlwm4a/A+zFssVFXux6BTXmpiv4VrtzEZXtDs64PufY/JcopVxDB8zlgsBxId5f+GDF3Gk/GroCD2bk2KAoXCrfaLMIvVIJ+7CsAwkHgzV2iWA0iW6lRx5ojPEn89BaZJSsXFIF0Qgi/t5PgNzA6P0T7fCX0fzKbkDHhRROtUyAOPoIoBtAE2Kk+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MWHPR11MB1422.namprd11.prod.outlook.com (2603:10b6:300:25::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.14; Thu, 27 Jan 2022 10:40:48 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4930.017; Thu, 27 Jan 2022 10:40:48 +0000 Message-ID: <7a34c391-008c-d1a7-a554-2ef414eb9f74@intel.com> Date: Thu, 27 Jan 2022 10:40:32 +0000 Content-Language: en-US To: Sunil Kumar Kori , Jerin Jacob Kollanukkaran , "dev@dpdk.org" , Xiaoyun Li , Aman Singh , Yuying Zhang CC: "thomas@monjalon.net" , "ajit.khaparde@broadcom.com" , "aboyer@pensando.io" , "andrew.rybchenko@oktetlabs.ru" , "beilei.xing@intel.com" , "bruce.richardson@intel.com" , "chas3@att.com" , "chenbo.xia@intel.com" , "ciara.loftus@intel.com" , Devendra Singh Rawat , "ed.czeck@atomicrules.com" , "evgenys@amazon.com" , "grive@u256.net" , "g.singh@nxp.com" , "zhouguoyang@huawei.com" , "haiyue.wang@intel.com" , Harman Kalra , "heinrich.kuhn@corigine.com" , "hemant.agrawal@nxp.com" , "hyonkim@cisco.com" , "igorch@amazon.com" , Igor Russkikh , "jgrajcia@cisco.com" , "jasvinder.singh@intel.com" , "jianwang@trustnetic.com" , "jiawenwu@trustnetic.com" , "jingjing.wu@intel.com" , "johndale@cisco.com" , "john.miller@atomicrules.com" , "linville@tuxdriver.com" , "keith.wiles@intel.com" , Kiran Kumar Kokkilagadda , "oulijun@huawei.com" , Liron Himi , "longli@microsoft.com" , "mw@semihalf.com" , "spinler@cesnet.cz" , "matan@nvidia.com" , "matt.peters@windriver.com" , "maxime.coquelin@redhat.com" , "mk@semihalf.com" , "humin29@huawei.com" , Pradeep Kumar Nalla , Nithin Kumar Dabilpuram , "qiming.yang@intel.com" , "qi.z.zhang@intel.com" , Radha Chintakuntla , "rahul.lakkireddy@chelsio.com" , Rasesh Mody , "rosen.xu@intel.com" , "sachin.saxena@oss.nxp.com" , "Satha Koteswara Rao Kottidi" , Shahed Shaikh , "shaibran@amazon.com" , "shepard.siegel@atomicrules.com" , "asomalap@amd.com" , "somnath.kotur@broadcom.com" , "sthemmin@microsoft.com" , "steven.webster@windriver.com" , "mtetsuyah@gmail.com" , Veerasenareddy Burru , "viacheslavo@nvidia.com" , "xiao.w.wang@intel.com" , "cloud.wangxiaoyun@huawei.com" , "yisen.zhuang@huawei.com" , "yongwang@vmware.com" , "xuanziyang2@huawei.com" References: <20220109105851.734687-1-skori@marvell.com> <20220113102718.3167282-1-jerinj@marvell.com> <20220113102718.3167282-2-jerinj@marvell.com> <839ce0f4-3170-8f2d-c05b-46cf6a99553f@intel.com> From: Ferruh Yigit Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add queue based pfc CLI options X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0801CA0044.eurprd08.prod.outlook.com (2603:10a6:4:2b::12) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5d0a82d1-0b9c-40f6-295b-08d9e1817b0d X-MS-TrafficTypeDiagnostic: MWHPR11MB1422:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F6bEdzdALAVnnFAyo+Z7AfuKP1buyDfIBiEzuv5hoSvEP2Nuj6nH1UCanVFrjEPOcjLouvEZzvMvd6V57CpIAwz/dG4dqZjNRhEtNINQei/wjTqR8RPLEcpovJuzpX/0q1MotXckWp6Ima0hmEuNY3QaHEpcKm0wZs5kycFTWOn9MjTjPM1wKG8J8NECev8CZL+M5K+yJmeesWVKM0sC/IFehZoVyP5lKTaWUFEjcXn58qhuR0L3tjJBrLxlhFH3od9QNxD0ama+w8S0onTKHQCc8UW+qeRltktFtdnvxTU+7g+x8yShaOgo+tmUAGExj7zzitEhOs45cfSVTnLPZCyKHFz86f3JzrDm6vCMTQE0UhoxUd7NIDOMNl2mJtS/9kMO1lGg5ePgwbuAmfq7WJNTlqT7uPxTWMw3OYEMCRZtOovG+quBzvoXsmz800h6O6EXDu/J15JYIDcZGYRavUhSGBw5DDEXDqCe/ibYGxT5SxdlAs5R6iz2A+K8PKxRmVSYFXCPjea+vpG48Lkuu4LvVDyu6xMjpU0d8fGgTCnOKSVChq0hHb/uaYQxuXCS9dzsQgrE+l92eo5eKo8ZgThFMWn/UPSCW6C3pV+ehYkNWh1c7octkJ2M783MgEqoFwA+P5BigpmVlDs0668KEjyul1QuBzKGak50lr2aM4R35hvBlIjaTALhKe34vLYeiJ8DABtXUtklnGQM5XNUAw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(86362001)(7416002)(4326008)(7406005)(6486002)(186003)(6636002)(31686004)(110136005)(31696002)(8676002)(83380400001)(82960400001)(8936002)(6666004)(26005)(316002)(5660300002)(38100700002)(53546011)(7366002)(6506007)(36756003)(66556008)(66476007)(66946007)(45080400002)(2906002)(44832011)(6512007)(2616005)(54906003)(508600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFNFc3pkdGt1eGhBN2pOaitOZEZsZWNGZm9nSm00RExUTG13cUJvY1hsK0cx?= =?utf-8?B?UXdpTnlEVy90ZDVEVGlUeEJnMjRJbUl3MzZqOTNsN0NKUVB5bHA2S21kaVhu?= =?utf-8?B?R2QwaytIK0lHZjhLZ3F0K0JUM1JIZE5DVDV6RkpKRHRDNHZLRlZkRkNRd1p0?= =?utf-8?B?VzN3K2xhUjh3c2I0Si85REZVdTRLcGNQbjhNZXRhaHc5cmZLRlo2Wi9KQnFW?= =?utf-8?B?cmZLcWt5VmI5YnI5SS83cklVS1E0WDY5ODNsM3MvZXcwRGR2ZUlheEt4SFV6?= =?utf-8?B?TWl2eVlZNENsWEE0QkgyYWpnMklTQ0ZwYlZPMlZnN2QwSU9sMm5QWkM0RE5V?= =?utf-8?B?VE5jd2t5OVBwT0xET3o3QUhXaEVlYWtVM3pLY0k0M1IvSWszNWFBL0kydDN0?= =?utf-8?B?OU5BcWNuU1NJeHZTa29aRTMvajlPdzhPa3RDRmszRUN0RnFINi9EODZwUTI1?= =?utf-8?B?V2h5NUNSY0orMHA0WDU1dFNHeFVWSEVBSVByRitPTm5kQjZNOTdPUVJ3TFJj?= =?utf-8?B?TkFLUWljUy9weFhEeW1Zdm1DaXVXNmNtbk4wd3NkNjVsdG5OQjlCbGUzcXM4?= =?utf-8?B?b2QzK0dYK2Y0Y2d3V2VxckphU010U1JsZ2U5dUFXYU9ucTNXVGRrNHNYazZw?= =?utf-8?B?TVF0TVRoSFppcG9VbzB5c0ZwRVFXNzUxQ0lUenVYdUxOU2Q2WDRxZUQ2dGZH?= =?utf-8?B?cWw5UU1hR0RKckNFNmJyelJHWUVNQUFibjJhL0RPQ05ORnJKM0tjRTZucjhP?= =?utf-8?B?aUxRWWtxZHZEK0RLWTQ2UjVUNXFxS2tSWUI1d3JzT1dmK3pDVzNEeHBqRGJT?= =?utf-8?B?RUpRbWpvSFB5QTB5U1pyMjVhVGR0cVJHRkI1NUY1VkxWc1ZUd2hEckhOdHBZ?= =?utf-8?B?eXZOMXF1Ti9EMTNXOCt4dFBQVVNISC85M3RJK1AvZk9DOGNnU3dycGpGTXc2?= =?utf-8?B?NmhReDJxdXRYTEtaWTNMbFd3Y0ZPY2V0L0tKanVOVGlEYmZXbzRMNzg5cEpQ?= =?utf-8?B?NStkWEcrL2o1WEZkckZwLzI1aUhjZ2dJYTBTMWZRYmdUZWswUFVOWkkvblBv?= =?utf-8?B?enl5TFNFNmtPN0pCTkIxa1NaKzR0V2dPdFVYV0hEb0NPRXljS044K2Q5V0lC?= =?utf-8?B?eDF4ejE1bjBFUXA4cGVCK3BNRVZic3NQUUZlWkp1UGg3MUw0RFY0cUxXb3Ra?= =?utf-8?B?OGdSUW1oc0hYWFdrb2I5WVdPVHNyVVk2ZmhKbVgrUmFsWlpHekpVVVFBYm1k?= =?utf-8?B?b082VjJDV3RFUzhEeTBLOVlwT1dmMUJSWGR2VkZlTzZGUnNBQmZGM2ZhdVQ2?= =?utf-8?B?UVQ3L2xFVTNmbUszcTVCQmE4bzBycmpPcTJHU2pUb282L1d1SjdXaVRSOC80?= =?utf-8?B?UC8wVVh4Tk1vaStzYjFyUFNDV2JvdVdOVjRnbXAzdVRBaGYwVEVqRVo4eEsr?= =?utf-8?B?L0xhc0RjbWVCUlAyVDRyTkdaVmNZYno3c1lJZ0pNamNRLzJVR3VyU05PZ3dl?= =?utf-8?B?NU9EL1NpajRnY2RaTVdqL3JIeWpyWU5XSDFld2t0K083aEZEci80eGFJWWJY?= =?utf-8?B?ZUhOOHJaV2R1aGNPNHJZT0dhNXBvM2lzcDNyS3RHOHJ1MGZJM091b2RuMVFv?= =?utf-8?B?SlRPMlFxUlRzVzVweFh4d0xnQTBvTjR4c05ySDd1MlJJTWFTT2t2LzRBVnU0?= =?utf-8?B?OERpeHB0V0c3N3RhQ2k3K1REUDRpcGRTd1U5VnphcDk0M2NtYStGaUZ1RE9B?= =?utf-8?B?eldjVEpJQWJscnhYQ0hsc0VvUVBJT1U4SEJybG52OUxvbmJ4ZnM2bHFRamZH?= =?utf-8?B?R2VxbVp1THBQbndYWjNGYXlkT1lHZ20wckxEZ1FMcXQwOG5nYmZIdzhrcWFE?= =?utf-8?B?Wk1penhNS0tkRUFyU1pzaWVJUjFvUFV3NGxqc0MzN3BiTmZjdU5uVWRjN1N0?= =?utf-8?B?S2VHTTI5ZUhKb2EzVzd5dTVWWlBZMktZT0lKMGdrWmxja0kyQUJIUjBpd0o3?= =?utf-8?B?UVNvNEMwVW03aTlZQ1A5SFU3MVJuQzQvT0x1ai9QTW1vSTlFSE0yd0tZcjZt?= =?utf-8?B?bmloZUxUTTVrNE41a0U4QjEzcGFsVi9Fa09EWGkzZjQ4QmljV0xiVkhjMk9E?= =?utf-8?B?dFRnUmxhcWVWandLajgxNmV6UjZaT0l3UlNGOThhd0pXYnlRSC9DeHNGS0ZC?= =?utf-8?Q?ZqqwkPnGpAZqVtnXEbP31jg=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5d0a82d1-0b9c-40f6-295b-08d9e1817b0d X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2022 10:40:48.6906 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uk/DU+iKInJjXIezbD6effuDZUQd8HPfNNCmUU7veQxcDgmNWpSYLlRxKjC/PzNsqLU4/G3pkuxeWOTeOjq+LQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1422 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/27/2022 7:13 AM, Sunil Kumar Kori wrote: > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Tuesday, January 25, 2022 11:07 PM >> To: Jerin Jacob Kollanukkaran ; dev@dpdk.org; Xiaoyun >> Li ; Aman Singh ; Yuying >> Zhang >> Cc: thomas@monjalon.net; ajit.khaparde@broadcom.com; >> aboyer@pensando.io; andrew.rybchenko@oktetlabs.ru; >> beilei.xing@intel.com; bruce.richardson@intel.com; chas3@att.com; >> chenbo.xia@intel.com; ciara.loftus@intel.com; Devendra Singh Rawat >> ; ed.czeck@atomicrules.com; >> evgenys@amazon.com; grive@u256.net; g.singh@nxp.com; >> zhouguoyang@huawei.com; haiyue.wang@intel.com; Harman Kalra >> ; heinrich.kuhn@corigine.com; >> hemant.agrawal@nxp.com; hyonkim@cisco.com; igorch@amazon.com; Igor >> Russkikh ; jgrajcia@cisco.com; >> jasvinder.singh@intel.com; jianwang@trustnetic.com; >> jiawenwu@trustnetic.com; jingjing.wu@intel.com; johndale@cisco.com; >> john.miller@atomicrules.com; linville@tuxdriver.com; keith.wiles@intel.com; >> Kiran Kumar Kokkilagadda ; >> oulijun@huawei.com; Liron Himi ; >> longli@microsoft.com; mw@semihalf.com; spinler@cesnet.cz; >> matan@nvidia.com; matt.peters@windriver.com; >> maxime.coquelin@redhat.com; mk@semihalf.com; humin29@huawei.com; >> Pradeep Kumar Nalla ; Nithin Kumar Dabilpuram >> ; qiming.yang@intel.com; qi.z.zhang@intel.com; >> Radha Chintakuntla ; rahul.lakkireddy@chelsio.com; >> Rasesh Mody ; rosen.xu@intel.com; >> sachin.saxena@oss.nxp.com; Satha Koteswara Rao Kottidi >> ; Shahed Shaikh ; >> shaibran@amazon.com; shepard.siegel@atomicrules.com; >> asomalap@amd.com; somnath.kotur@broadcom.com; >> sthemmin@microsoft.com; steven.webster@windriver.com; Sunil Kumar Kori >> ; mtetsuyah@gmail.com; Veerasenareddy Burru >> ; viacheslavo@nvidia.com; xiao.w.wang@intel.com; >> cloud.wangxiaoyun@huawei.com; yisen.zhuang@huawei.com; >> yongwang@vmware.com; xuanziyang2@huawei.com >> Subject: [EXT] Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add queue based >> pfc CLI options >> >> External Email >> >> ---------------------------------------------------------------------- >> On 1/13/2022 10:27 AM, jerinj@marvell.com wrote: >>> From: Sunil Kumar Kori >>> >>> Patch adds command line options to configure queue based priority flow >>> control. >>> >>> - Syntax command is given as below: >>> >>> set pfc_queue_ctrl rx \ >>> tx >>> >> >> Isn't the order of the paramters odd, it is mixing Rx/Tx config, what about >> ordering Rx and Tx paramters? >> > It's been kept like this to portray config for rx_pause and tx_pause separately i.e. mode and corresponding config. > What do you mean 'separately'? You need to provide all arguments anyway, right? I was thinking first have the Rx arguments, later Tx, like: rx tx Am I missing something, is there a benefit of what you did in this patch? >>> - Example command to configure queue based priority flow control >>> on rx and tx side for port 0, Rx queue 0, Tx queue 0 with pause >>> time 2047 >>> >>> testpmd> set pfc_queue_ctrl 0 rx on 0 0 tx on 0 0 2047 >>> >>> Signed-off-by: Sunil Kumar Kori >> >> <...>