DPDK patches and discussions
 help / color / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Yong Wang <yongwang@vmware.com>,
	Eduard Serra Miralles <eserra@vmware.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v6] net/vmxnet3: Added mtu_set() function to allow setting MTU.
Date: Wed, 1 Apr 2020 17:07:26 +0100
Message-ID: <7a3afb2d-f2f8-8788-11b9-04c921826699@intel.com> (raw)
In-Reply-To: <64523A3C-DEBB-4920-A936-47E8BD9CB594@vmware.com>

On 3/31/2020 6:31 PM, Yong Wang wrote:
> 
> -----Original Message-----
> From: Eduard Serra Miralles <eserra@vmware.com>
> Date: Wednesday, March 25, 2020 at 12:19 PM
> To: "dev@dpdk.org" <dev@dpdk.org>
> Cc: Yong Wang <yongwang@vmware.com>
> Subject: [PATCH v6] net/vmxnet3: Added mtu_set() function to allow setting MTU.
> 
>     (Picked up from @Charles Myers patch
>     https://patchwork.dpdk.org/patch/57771/)

Thanks for resurrecting the patch.

>     
>     When the mtu_set() function is not implemented, rte_eth_dev_set_mtu()
>     fails with -ENOTSUP and mtu is not stored in the mtu field in the
>     rte_eth_dev_data.  This causes the mtu in Vmxnet3_MiscConf which is
>     shared with hypervisor to always be set to 1500.
>     
>     This may cause issues receiving jumbo frames on Enhanced Data Path
>     N-VDS.
>     
>     Signed-off-by: Eduard Serra <eserra@vmware.com>
>     Acked-by: Yong Wang <yongwang@vmware.com>
>     ---
> 
> Acked-by: Yong Wang <yongwang@vmware.com>
> 

Applied to dpdk-next-net/master, thanks.

      reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-17  4:53 [dpdk-dev] [PATCH] " Myers, Charles
2019-08-20  4:06 ` [dpdk-dev] [PATCH v2] " Myers, Charles
2019-08-20 15:12   ` Stephen Hemminger
2019-09-03 20:10   ` Yong Wang
2019-08-21  2:16 ` [dpdk-dev] [PATCH v3] " Myers, Charles
2019-08-21  4:43   ` Stephen Hemminger
2019-08-21  5:19     ` Myers, Charles
2019-09-13 18:47   ` Ferruh Yigit
2019-09-13 18:59     ` Ferruh Yigit
2020-03-25 18:43   ` [dpdk-dev] [PATCH v4] " Eduard Serra
2020-03-25 18:46     ` [dpdk-dev] [PATCH v5] " Eduard Serra
2020-03-25 19:18       ` [dpdk-dev] [PATCH v6] " Eduard Serra
2020-03-31 17:31         ` Yong Wang
2020-04-01 16:07           ` Ferruh Yigit [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a3afb2d-f2f8-8788-11b9-04c921826699@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=eserra@vmware.com \
    --cc=yongwang@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox