From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 397A14334A;
	Fri, 17 Nov 2023 01:50:58 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 01A4340275;
	Fri, 17 Nov 2023 01:50:58 +0100 (CET)
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12on2079.outbound.protection.outlook.com [40.107.243.79])
 by mails.dpdk.org (Postfix) with ESMTP id 127E240271;
 Fri, 17 Nov 2023 01:50:56 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JfscpR9sV37fC2eU5invjlJXpBB4mcg5HN3FLIf3m7HTjRNPmT0uW8mYkfb/BbSdj4AunGxNWBTvJaz7rKanwxTppxZ8l70F/j5l7ygyAmaO1Yn6M6K8KZwbFLSvOrj7isyJyxxMKcPFqhzEudjPQAGSLMtF+xGOZfj25ECi6bA42VbddYVpJoP3mz9lYZ7r+vu918u71jPIbyOorwyqwROYXwARFG4MQQhQYokVvzfICzm9tkmFY4y5OsRa3kLiOtjGNbvJFoRNxw52FiUzv1OUhd1egqXznqzf+J2jm8I5kn4juRWG0jyuxigdnHhRPki8ddAd/bA0Wzx5OwgcTg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UKap3D4xtFsTNiXHn6pwNHq/yklbwb3Bq3tCoFrBXTY=;
 b=Uvews3QCOU95BxKQLeFeP2r+03x5aIwCUX7Rqok9GHOOSwf5oqQ/6I2/OXwPvD+wzWMIiMmqiqvbD1eQS5DjvkV6XdiQj3rpEqzVNyyfLgnCv/ASvTVZCju4w7x2GfuvQ6dBGhx8bmmwcj4tVomr/H932U1kCyo+5qNEG5ibT/B+QppkS4pPuNCqanoJeTAioT+mtUluz12Or84BE7Tf/KcwhdIRC7eDZic80gATpsOZoyKehFg+Fg+ZbObPjNqfbV820TsmB2ZezbpKgK5MdVGIk9ZkgX8YRywQNFBdphpg/6Woa6DiDHnKFC2Gn756FpDLZojkZoHEw7OQWH/9aA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; 
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UKap3D4xtFsTNiXHn6pwNHq/yklbwb3Bq3tCoFrBXTY=;
 b=KPWLKHhyj61LR64uTKtMqJVlAw2lrhXIe6fHggFxompMDuDkg2PE3sZ22F+HTUdfYJhQqHxKQxpOUr5co0fGUHv2We2xBl4LEf99nK51XYQUTrFRZCtCFmp72IOZT5h87gwqK2LurZUtvN49CJR+cg6M1FU2hALJTC7U7k2+C+Y=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11)
 by IA0PR12MB8694.namprd12.prod.outlook.com (2603:10b6:208:488::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.23; Fri, 17 Nov
 2023 00:50:51 +0000
Received: from CH2PR12MB4294.namprd12.prod.outlook.com
 ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com
 ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7002.022; Fri, 17 Nov 2023
 00:50:51 +0000
Message-ID: <7a41467c-c863-4ea1-bf7c-9206bf56aa34@amd.com>
Date: Fri, 17 Nov 2023 00:50:16 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] app/test-pmd: fix L4 checksum with padding data
Content-Language: en-US
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Kaiwen Deng <kaiwenx.deng@intel.com>, dev@dpdk.org, stable@dpdk.org,
 qiming.yang@intel.com, yidingx.zhou@intel.com,
 Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang
 <yuying.zhang@intel.com>, Olivier Matz <olivier.matz@6wind.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>
References: <20230804082849.533059-1-kaiwenx.deng@intel.com>
 <892f0567-e1ee-4283-9726-5db1dd92c2cb@amd.com>
 <20231116145817.78eb0954@hermes.local>
From: Ferruh Yigit <ferruh.yigit@amd.com>
Autocrypt: addr=ferruh.yigit@amd.com; keydata=
 xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9
 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J
 eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg
 B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9
 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ
 N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ
 vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S
 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum
 CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA
 XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln
 aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID
 AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK
 Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3
 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU
 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs
 cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD
 VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg
 Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc
 GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV
 gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW
 VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD
 DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG
 CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe
 WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi
 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl
 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv
 VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA
 fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr
 ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC
 IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk
 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak
 oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq
 b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ
 Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX
 W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW
 honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA
 g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn
 GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ
 NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs
 SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe
 cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH
 dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk=
In-Reply-To: <20231116145817.78eb0954@hermes.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0106.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a8::7) To CH2PR12MB4294.namprd12.prod.outlook.com
 (2603:10b6:610:a9::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA0PR12MB8694:EE_
X-MS-Office365-Filtering-Correlation-Id: 64c17cc8-2cb7-4e0c-18d1-08dbe7073f00
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: rPuQb7T/RqSVBRy1IfL0aA8EtCTX+Lm/i7w707THNlpsDs/Tc/KqZtUtzWhhsM14QKP46JAcaYhJrN3RNZqhClFToLxz7aLk1kDaGQqxXt3kewlr9QiXee/bv+TuCHgmCwrLH45jRldTbUMMNZ4VoHbaEWqtv8a6YVRQ9IPtG1MTbwzmSwcuYLwGHbIvyWtARSc+gIDpQ7wEW9lfD3MpqW3rarIZQaHjzgvUH0V9oEGbVPOWLCnrJ2XIX2hSKXJjzJu7txSANYamYiS4G7wjFgFyv9sHecbVhdiWQBC3aw8WlLyzriEdEbYys0BJBnJElhXz2G7z8Kk5M1rnZqX+auVGJnBDmruJ11z2G/AQ2qL2FJOySHd0RFyp/MvLhjjaePd1dXuFbYQH/2ZD4vXufA+WrHA/46+szmrp9bu7B4iyist+1J4x6WqQfyUjkMNlo+RserUvmBbhDbputki+pc5/6qZZXs83obAdrMjkaPs0BWURHa9u61GRM3S3GqbC2sHMIjbJF8ClfmdisTTaRY584nvH5lENlt4U9loW8FS1ba6UqGljQxXCUoZqyyGu2zfgdUivz/y77+DVU+h4uUPbmqztuURSWUnEUUlCmFyRSHokZ4+toXcsjt5If2tDk9a/lQsyijDMG7EvPbfimQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230031)(396003)(39860400002)(346002)(366004)(376002)(136003)(230922051799003)(1800799009)(186009)(64100799003)(451199024)(6666004)(83380400001)(478600001)(6512007)(6486002)(2616005)(41300700001)(53546011)(6506007)(31686004)(26005)(38100700002)(54906003)(86362001)(66556008)(66946007)(6916009)(316002)(66476007)(36756003)(4326008)(2906002)(31696002)(5660300002)(7416002)(8676002)(8936002)(44832011)(45980500001)(43740500002);
 DIR:OUT; SFP:1101; 
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2t4REVOSytqZW9yenlSSGNQaEg2b1BoTU1hanZaUk9Bc3NqMGd2T0Fhenc1?=
 =?utf-8?B?R2FxSkc4OFdxRGx4eGRabmU0YldKRFdwdERieDRGUTBpRnpOMVBORlBUTkw4?=
 =?utf-8?B?ZG9iWUhLUE9uRGl6ZTR4V3I2ZlZaMHF0clpzZ1dtakMya1E3a2F4VjErcGZV?=
 =?utf-8?B?cTdEeHNzeVBETkM5SjdsMDUxWDJRTWJJMDJNOUdtZ1FSQlhnY1JJanlYbjFC?=
 =?utf-8?B?bjg0S3p4cUd1c3VtRkFXWlRmeDAwUUpYb1JmUUVmS1BwQ3FURnQ3WENsY0I4?=
 =?utf-8?B?M3NuZGdBYkdGMkZERGg3Y1pnSGFydGhhWWlHdFArSEtVVm1UekljaXhHOXh4?=
 =?utf-8?B?VmNZQ1ozNE9Za1pPNy8wYkZOb0VUUEJ3Q1R0TzdvdXNKUWNOU3htUDcrZFFx?=
 =?utf-8?B?RUVTaTloTG93d0pFV0FuSWs5Q004dENaNDN1NFphUnNMQ09hdENlZVlKRm4y?=
 =?utf-8?B?bFQvWWsxYTFqb1B0ZlJYdk1pZ0NKQUpFdXVneW1HdnEvYUljU0tEMFh4MUpK?=
 =?utf-8?B?VEpYL3h2Z1QxZWd6YWxoZWl1Z3BhbDh3b3d5YlRBNHI3VkN2a0NFSjhRcWxj?=
 =?utf-8?B?ZUN5NDMyaTRjMFdkbHdKUmt3bzFXT1k1L2YwK0dSWVlnS0htT3lTc0xhWTFV?=
 =?utf-8?B?UWZUdmREWmtiUDV4Wm5ibTZSb3NKZTNYUlA1M0VGSEt1ZjNiYlBYa0F4SjBy?=
 =?utf-8?B?eWsvYSsydDFQem9yWEhTLzQxS2NhY21vOG9JWHFlZUdGeWVzSXAreWtOTzZI?=
 =?utf-8?B?U2h6Z3hvM0ZGeHlZTFgrRHBLb01UandpSUtmVkd6SUx4QkIrY2NRVnNHeDRB?=
 =?utf-8?B?dkFPMlFuUHV0YndhUGRBbEwrbFhZUVhOVkovTzRUakk1UmpuWWZ5a25Dbk5j?=
 =?utf-8?B?aGszOG1ZUFlqeHhPTFBMTHFiTTkzTHpMaktQclU1aDBMRldoeGxqUTlJVmdh?=
 =?utf-8?B?dXNSbDBuUW50TzVEMDBQZE0yUlJ5OSs1QXJCeFp6c0IxQkpBTGYrMFlUSWM4?=
 =?utf-8?B?UUtTV1dpYStlL24vSXE2S1R0S0FiYjhMUkxXNXdFOE1PbStCMnZ0dXVCTlpO?=
 =?utf-8?B?cWFWNGtQWE41UVVjdFRDMnJqZDRvMVQ5SUxYWWh4K2dYc3NreUE2ME9tWVRW?=
 =?utf-8?B?ZTVML3ptZEU4L3o2cTZ5SGxVamJsZE03ampjazl2OU84VzBBV1p3bFllQWgx?=
 =?utf-8?B?MHg1U2IvSDI2cGt5SVFCQjZWc0pYdXg0ZmNYeFZKMHh1T0V5M3FNQWVQMEVl?=
 =?utf-8?B?ck04OTlsaUY3U1ErZDJzVkZGemNQU3g0bVlhUU1uV2NjeU5BYnNPUHo0R3Fj?=
 =?utf-8?B?S2dNTjJFVmh1MFZ0Q3RzQjg2ZDdsaDdCS3d0TnhkYjdRbVlza3ZnTnloYjdG?=
 =?utf-8?B?bjNYckFxU0tadnpmQ3kwaEFRbTZWWmxkUmMvUGJEQ0JWcEg5cGIwUG55Mm5K?=
 =?utf-8?B?dGV4Q1NET0toWjczU3hpR3BxNUI5a3RndGRkd3hzQlRlZldSa1VYcENaQ1RT?=
 =?utf-8?B?cUJTSFEvdjdBYzViOWlrczR0NnpKR3NzeEtRSTMvTFZ5R091VnBoOFNvNkdW?=
 =?utf-8?B?UVRMVGF6N0ZqdUZReGNadm9uTEVjNTdQb2JLRHl0SVhKeGVFV3N3T1ErWERF?=
 =?utf-8?B?cGJhYUlFcUZmWXh4SmJRMkRySzJiRVhLWHVRS2JNTGJiOStKcDRyWDE2R1BR?=
 =?utf-8?B?ZXQ5NkN3T3dCTmZ0TEsrcmhvMDczK1RJc3Npd1N1SjEvdW9ESmxuT3czVUtE?=
 =?utf-8?B?Z1NDUmtsbnEvYUJkTXhJankxVGhuTUpDWko1VGFxSGtNTXo2YnE3ak5iVGZU?=
 =?utf-8?B?cyt0V1Q1YU1NVHBjeTdlWDlTZHZkS2FJbjBrWkEwWS9QVS9PMmF1MjFObTg0?=
 =?utf-8?B?WGoyZmwwaXJUd01SMndmRDFZcUdjNHBvUzNlUG9SSGY4U05Mald5RGhNcVJm?=
 =?utf-8?B?RVdqN0pxTmlmTnE5bUFGeFlwVmhtNXRaNEdYQzFyQnNKN3kwT3pWL3FFdlAx?=
 =?utf-8?B?RmU4eWZtTGxEdllaRFg0NWhoNjlDWERpc3BrTW9xNkV0T0tLb2dKZm1WYXU0?=
 =?utf-8?B?cVM5UUxGN2lpUEcwaUIvUEVYY1JKcmFrZ0hRWElycWprZFBpdGNCbUwrdGZw?=
 =?utf-8?Q?ofnY=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64c17cc8-2cb7-4e0c-18d1-08dbe7073f00
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 00:50:51.5679 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MLbEYUx646io0jeavE/4XiCR/ESr35lWIi3Z8Y6E0B392ed8FoVtFEn/diDz6D5e
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8694
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 11/16/2023 10:58 PM, Stephen Hemminger wrote:
> On Thu, 2 Nov 2023 19:20:07 +0000
> Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> 
>> On 8/4/2023 9:28 AM, Kaiwen Deng wrote:
>>> IEEE 802 packets may have a minimum size limit. The data fields
>>> should be padded when necessary. In some cases, the padding data
>>> is not zero. Testpmd does not trim these IP packets to the true
>>> length of the frame, so errors will occur when calculating TCP
>>> or UDP checksum.
>>>   
>>
>> Hi Kaiwen,
>>
>> I am trying to understand the problem, what is the testcase that has
>> checksum error?
>>
>> Are the received mbuf data_len & pkt_len wrong? Instead of trying to fix
>> the mbuf during forwarding, can we fix where packet generated?
> 
> The root cause is that get_udptcp_cksum_mbuf is using m->pkt_len
> which maybe larger than the actual data. The real issue is there and
> in rte_ip.h checksum code. The correct fix would be to use l3_len instead.
> 

I see, you are right.

In 'rte_ipv4_udptcp_cksum_mbuf()',
as payload length "mbuf->pkt_len - l4_off" is used, which includes
padding and if padding is not zero it will end up producing wrong checksum.


I agree using 'l3_len' instead is correct fix.

But this requires ABI/API change,
plus do we have any reason to keep the padding, discarding it as this
patch does is also simpler alternative.


Other alternative can be to zero the padding bytes. I guess standard
doesn't enforce them to be zero, but we can do this to remove its impact
on checksum calculation.


@Kaiwen, did you able to test this with HW offload, what is the behavior
of the HW, does is remove padding bytes?


> It also looks like test-pmd is not validating the IP header.
> Both parse_ipv4() and parse_ipv6() should check if packet was truncated.
> Same for both UDP and TCP lengths.
>