From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E656741C97; Tue, 14 Feb 2023 19:14:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4200142F88; Tue, 14 Feb 2023 19:14:44 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2041.outbound.protection.outlook.com [40.107.96.41]) by mails.dpdk.org (Postfix) with ESMTP id 3AFF040EE4; Tue, 14 Feb 2023 19:14:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OmUNey89bLapMyS6btf3XJTchGJosNzmRCEeZmfcoOlTLuy1M0mW2hzHxh7ze07sciLGV7kv4V020mClbKS7nBNCFZRjKVItOgjY3tCy9sZb9HW9DPsxYqKJ2lrSMKLAPNAXn6P23NKcflVMNVpcIP/HT2yYMdmRkHzxZMYvVOi0KovvoYjlTOmrtEYKZ3sO8Bl+mXd8Mg++6XHMwTeYLZKKnxPVzBD5qavmwW4J/vXsFFTQUEeDsm8NEzldB3K0VtJb0PVO4h0KEiJAbjXg7UZF1uHmqSPaLSXEhF2QNlS2XZouf8tp9gaq6m6N1/LQq+Go/NRTALoz/BVG4WefqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/nigRJDJaT9oyRKM8N+m4bgSJfF71zoMr5TBbWvcbJw=; b=KkOM9pY/hY//nqvKiKCVMTSL2+ovoyPwQiQQM5gnAlcN/NxxDXIpa1oPKqwJFfcJZIrzaGztUhEX5BP2u0O7XgXuY1ZMd5TJQbucZkLEPC/iPycZiGYsdfD5Quqh415WwmNHYcTz5271pe8pwY2PK9f6CBQccKAithD0Sq9S+to9jD+OSTqPf8w8hfSMqKbXYOy9oR2ozFU/fIOJ7M0+wEb0UzFxmTFlcmqWpeh+cMzZdjyy2QUeZ3xQrEcLuZ29PzPps/Xa7h/hWnB5pj+jWEtbeiDk4TuxSc/32lP76J41HtEwSM6iZ3ZP3dlcPGUfB02gEHJSMQraQzLm5CBLWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/nigRJDJaT9oyRKM8N+m4bgSJfF71zoMr5TBbWvcbJw=; b=s6VzTA4uF4O2hWFk567yXBsraTznUMym8apyTemDicq3d1mF1bN36OeULm82+aReQk/RNC6CAa5fpHhLq18uEESyqeRmkksN2F13jeRrX4iy1IvK+BTgxiAiX8T3kXNEgJug1uJczhTUoH2Gmyg4Bs/sNrOJUmy+K14B0PhKiW8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BN9PR12MB5083.namprd12.prod.outlook.com (2603:10b6:408:134::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Tue, 14 Feb 2023 18:14:41 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%8]) with mapi id 15.20.6086.026; Tue, 14 Feb 2023 18:14:41 +0000 Message-ID: <7a6d18ce-45d7-1aa8-21b1-852db9978bd1@amd.com> Date: Tue, 14 Feb 2023 18:14:35 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: Aman Singh , Yuying Zhang , Robin Jarry , stable@dpdk.org, Tomasz Kulasek , Konstantin Ananyev References: <20230124104742.1265439-1-david.marchand@redhat.com> <20230124104742.1265439-3-david.marchand@redhat.com> From: Ferruh Yigit Subject: Re: [PATCH 2/6] app/testpmd: don't send unprepared packets In-Reply-To: <20230124104742.1265439-3-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0025.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BN9PR12MB5083:EE_ X-MS-Office365-Filtering-Correlation-Id: fe740c37-512c-4d27-13aa-08db0eb7577a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dAzSn0YP4/nOH+Dj5nh9s0EA/u1C0HszXq2MYa2KHkvLt2jiYESstKgxKrlYX5yBsd+7JUEe/zvw4tdiznUVeo9mSSjRkC5PrbPv1HdpJMYiEw8ua+oQH4jvAOsvlIF0Yg+xqyVAh+P1+MNV9ahmDIxMZrify6BcS6wSkQ+KhlXGEkaXpMW45VqaCeEMd85VAyWb3bQf09bVWRrwINxKlq3tnwmCNHUHzX+DYHLHVoWWazN+4sJ3t2FkMUH0wlFgFUtTLwOjE6QV3EKYp84V8omO7s2x+KPea+zwKTMgXz+pKkn5Zk9C9fXgCO7AMDjkNPoqn+NgkQZQbyAuBUTHZKD/3kxD9WfTGfD5DbP9uYqCHfpR9QVc6oU7xGrRRc1yttOAAmEbYWG79kKP1TVHCWYpgH6hLeMhWbODHEa7vqALj6fXR865lGfJqLsWtHTgMUDSz3goYxoiXZReCGL/BhjWfxELVBGHmP/xL8U5iSpUPdcDycT+O6ngdYLX0Ysc/woE++yLH3Io4CQ/ds2C54L1hypjkyoFXYs8P8qyPEGyo6uGhtmBaGJxu+lWLpRelfIfXpMKpHmPVCGpvlqqXMYFK3Ks0C24XxOCb+k/ITQYNvSUom0R6xZmdIQ0U64hFlP9Ynjdk4UcByDR1W6VXATdRN2yS50P5QPsYpBfa4GJ89rKQ0qqLLu6HrYDdyJ+cic4xRtgF0CJy9L93/DgNj5l5BrbvakoG25FDJqCZiQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(396003)(366004)(136003)(39860400002)(376002)(451199018)(53546011)(8936002)(6666004)(316002)(186003)(6506007)(26005)(6512007)(2906002)(5660300002)(4744005)(478600001)(44832011)(36756003)(54906003)(83380400001)(86362001)(6486002)(31696002)(31686004)(66556008)(41300700001)(66476007)(4326008)(8676002)(66946007)(2616005)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTFIMUVSRUpnbkxSTWtkTGR4S0ZSa3hmUmtPNGpaMHplU3VoM3NIRWhkUUZT?= =?utf-8?B?Y1NncXNUdGZVK2xXQ005K2dCb2IzMDY5OVJNaytQcDlVVmkwZXhNVVg0V1dX?= =?utf-8?B?d1g4QXQzRjRQamFySGZKUFNXVzlsaGd5QmcwblozZzUxWklwZDdHSTBDWXVS?= =?utf-8?B?UVU3S01PNmVhMEtWK1dyNEdLUHBwQ2N5emMwVGtXUXZ4TGxVRHdEOTg1Q3J5?= =?utf-8?B?TTNadm04TlROOXpQSWVnZWRVZXMvWHVYd1VYanlGd2lxSmw3bmMyL0N6SDhG?= =?utf-8?B?VncwcGZ2SklnT0F6NXk0RDcyUUlSUHA2Y3RqUE1ScjA4NHVYS1FRT1FRU0VM?= =?utf-8?B?eDdiNDduSjExMXA3MkM5bk92MjkzSGpTbDd1Y096YmFtVWV5RmVYMS8wMWx4?= =?utf-8?B?cWVsdjMvZjNTTE9EVUE4S05Cc3U4N3BnY1krQnNqRlphV0swb2hYNXpWRDc5?= =?utf-8?B?dGp2WVdLUEl1aGV4ZVZ6NXY2Z0VTTzl1V3NDVCs3YnBSY2RDOFBDcUdUaGdo?= =?utf-8?B?ZzA3dVh6NzN4ZERTSWVqOFQwZjNSa3dBK1lldmNadHd0ZS9vNjhyWUdJbGoy?= =?utf-8?B?eHJHcUpJYXViRXJ0bzdLN2NlMFlWWlQ4ZnRXVExZSU4rV0ZtQm9OZW4yZnYv?= =?utf-8?B?RjIzc3NNODJUcDRvcmtaN1lIZ0YySERYc0I0MFV3M1JaQTlhMWdxYitKU2xk?= =?utf-8?B?SXp0Yk5BYVNlRkFVellWczY2RW5xU3BJQWpreHJ4SjRZMVhUL3A3WHUxc2sr?= =?utf-8?B?djA2akQ4MTlBNGFyS09OQ1drRmxneGQ0a2RQWnl2YkNDMS9hK3lCQUpUTWhE?= =?utf-8?B?UlArUkpSSUVlbXRYUDZxMlppVW91RzVQRnNIOGVJZFcrYTJCbG5KNGVoZlNp?= =?utf-8?B?blhYQVE1V1pOV1gxS1pnS3hTTk0vSGlQbitGSUpUZ01kZnZ2RTFmN2JkdkhZ?= =?utf-8?B?akRrd0xnd2ZWdDRMMTJVazFWcmhmV1NmdWMwT0VDTjdRa0lKZmFKaWx3eUFF?= =?utf-8?B?azhBN1lFb3c3eWdiaGtyNGdoQUNmTDNMMDArQnJGelN0eGxIRHByeTV0UXJO?= =?utf-8?B?eFNCMjZad3k4QU55OEZ6T2VuSjdwdlNadkhBYWY1L3hZcTFrVklpT1ZWVkUr?= =?utf-8?B?Qi9ObjlaRDdYZHBvWFVIRGVySE9TRHNGaE5wR2VhbGkwR3lzWk1CR0Iwd09T?= =?utf-8?B?amVjL3FHeEVCQ3J3eU9CQjZROUN2VXFKUEFsUEEzT0ZwbCtqdTNSMGFqUU12?= =?utf-8?B?dmdMQzFFTTlHNFV6aWlhTXpKSmwvUzVPRmhOdGpmNjBsVC83UTh6QzJMZGF4?= =?utf-8?B?RmQ5UVdMYlkvcVN6WlhqcUF5Y1Z3RytjZ3FqMjQzQXJxSm1YaHMwVHdTSVVq?= =?utf-8?B?NjgxczBDSzJwa0hHQXhtc2N2OTdlT2R0alNpMGprSUlVcXRZYldqb3ZQRHZm?= =?utf-8?B?V2xTdm5YbDQ2Q3dtTnRQR1Uva1Z0MnZwRllJZUgyMUFiZmprMHVaVkl3Q00w?= =?utf-8?B?MDZLR0Nxc2dTVmFZeUx2cWJ5cnRQWXNBZ1E3WnpTL3kwdXUxc0lNQzNVS2xi?= =?utf-8?B?MDcwMktwekpKeXNVNUordnV5R3lWNitxeUZwRzhVcGdGWjBva0lhUnNrekNB?= =?utf-8?B?RzlFT00yNmpnM2FPYVJTblV4TEFCREdpS212KytqUlNCUHhUcS91M256T0pL?= =?utf-8?B?cStHSFgvRmlWTmErb2xGNjFrWjIwSG10QmRJTU0yRHZxbThsSFQzVmljaHBF?= =?utf-8?B?OEFMVW1TdUlrc0dTRXcwSllSay9jVTAyVGdFcVQ3bzNrMFNYK2RqcjdnYmlr?= =?utf-8?B?QTJUUy8rVFcwRkcrZWkrN0w2NTVRLzZvcWs4Zi92V0xLSHMrS04xTXFxTFZ1?= =?utf-8?B?RzA5YWtDZUQya3c4VGVuVjgxU3dIUjNNTzNYTnRudG03ZVRtTk5TbUlFR2Jm?= =?utf-8?B?WlRGU3JlQWVLcFBJUDBFU05DckhTVFpVS0JtTm5rV2QrNU10dnQ0K1NhZE11?= =?utf-8?B?TzN1eXlEQmp0dU9WMGJTeG4rK1RtZkkyUXZHYnlQVldSdUZyM3JPWjFxZEZB?= =?utf-8?B?K3dZd1JWd2lkZWdLbUxOdkVSZTR2OFAzZS9ENmJMMTNqMHZIZlZ1WGovc0FF?= =?utf-8?Q?7J+hcmQnkM5neLJ7ml0C0hzhD?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe740c37-512c-4d27-13aa-08db0eb7577a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 18:14:41.5135 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BNy5xfCZwlidDg3EiYfH/QQu0AVjWTQyAWNXkEVmdUgdCu+CudnXV5TiDSaVj/5P X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5083 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/24/2023 10:47 AM, David Marchand wrote: > "unprepared" packets could get to the wire in the retry loop. > > Split packets freeing in two stages: one for preparation failure, and > one for transmission failure. > Adjust dropped counter update accordingly. > > Fixes: 6b520d54ebfe ("app/testpmd: use Tx preparation in checksum engine") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit