From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B2B8A0350; Sat, 6 Jun 2020 03:07:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A09C1D51B; Sat, 6 Jun 2020 03:07:15 +0200 (CEST) Received: from huawei.com (szxga04-in.huawei.com [45.249.212.190]) by dpdk.org (Postfix) with ESMTP id EF7801D50A for ; Sat, 6 Jun 2020 03:07:13 +0200 (CEST) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 449DA1A83C8EBD6648AD for ; Sat, 6 Jun 2020 09:07:12 +0800 (CST) Received: from [10.69.31.206] (10.69.31.206) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Sat, 6 Jun 2020 09:06:48 +0800 To: Ferruh Yigit References: <1591176721-46875-1-git-send-email-xavier.huwei@huawei.com> <1591176721-46875-5-git-send-email-xavier.huwei@huawei.com> <6badf2a5-043d-5e60-d724-3a8f8602e507@intel.com> <9cc185c1-bcb6-4052-7148-9856943d38a7@huawei.com> CC: , From: "Wei Hu (Xavier)" Message-ID: <7a7a358e-bf3d-d7e0-a197-f2a53f9d08a3@huawei.com> Date: Sat, 6 Jun 2020 09:06:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.31.206] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v 4/4] net/hns3: add checking tso segsz when sending TSO packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2020/6/5 17:44, Ferruh Yigit wrote: > On 6/5/2020 9:50 AM, Wei Hu (Xavier) wrote: >> >> On 2020/6/5 0:56, Ferruh Yigit wrote: >>> On 6/3/2020 10:32 AM, Wei Hu (Xavier) wrote: >>>> From: Hongbo Zheng >>>> >>>> Base on hns3 network engine, when the rte_eth_tx_burst API is called >>>> by Upper Level Process, if PKT_TX_TCP_SEG flag is set and tso_segsz >>>> is 0 in the input parameter structure rte_mbuf, hns3 PMD driver will >>>> process this packet as an non-TSO packet, otherwise hardware will enter >>>> an abnormal state. >>> What is ULP (Upper Level Process)? >>> >>> And OK to have this fix but why 'tso_segsz' is zero when 'PKT_TX_TCP_SEG' is >>> set, shouldn't this needs to fixed in app level? >> ULP is our own test application. > OK. Is it open source? We have do some modification on the basis of the current DPDK test program, as our own internal test program. But it is not perfect enough, so there is not open source. Thanks, Xavier >> The process is added to the driver to ensure If the upper application >> called the API >> in the wrong way, it will still not cause serious abnormalities in >> network engine. >> >> Thanks, Xavier >>>> Fixes: 6dca716c9e1d ("net/hns3: support TSO") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Hongbo Zheng >>>> Signed-off-by: Wei Hu (Xavier) >>> <...> >>> >>> >