From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0D2845C9D; Wed, 6 Nov 2024 19:02:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A193E42E68; Wed, 6 Nov 2024 19:02:39 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id F11EB402C3 for ; Wed, 6 Nov 2024 19:02:37 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3A3D0497; Wed, 6 Nov 2024 10:03:07 -0800 (PST) Received: from [10.1.30.24] (JR4XG4HTQC.cambridge.arm.com [10.1.30.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B52E63F66E; Wed, 6 Nov 2024 10:02:36 -0800 (PST) Message-ID: <7a894bc0-aa70-421a-9d44-1d3eae32cca6@arm.com> Date: Wed, 6 Nov 2024 18:02:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/8] dts: refactor build and node info classes Content-Language: en-GB To: Nicholas Pratte Cc: dev@dpdk.org, Paul Szczepanek , Patrick Robb References: <20240822163941.1390326-1-luca.vizzarro@arm.com> <20241028174949.3283701-1-luca.vizzarro@arm.com> <20241028174949.3283701-4-luca.vizzarro@arm.com> From: Luca Vizzarro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 31/10/2024 20:16, Nicholas Pratte wrote: > On Mon, Oct 28, 2024 at 1:51 PM Luca Vizzarro wrote: >> >> The DPDKBuildInfo and NodeInfo classes, representing information >> gathered in runtime, were erroneously placed in the configuration >> package. This moves them in more appropriate modules. >> >> NodeInfo, specifically, ia moved to os_session instead of node mostly > > Small typo here, change 'ia' to 'is'. Once again, great catch! >> as a consequence of circular dependencies. And given os_session is the >> top-most module to reference it, it appears to be the most suitable >> place outside of node. > > As I said, this makes sense to me, but I wonder if it might make sense > to change 'NodeInfo' to 'OSSessionInfo' or something like that. I'd > imagine that if any attributes were to be tacked on in the future they > would probably be os related, but maybe there would be system > information, and in this case "OSSessionInfo" might be a good middle > ground. There are existing changes that I've done where arch is > discovered during runtime, and this could probably be placed in this > 'NodeInfo' class as well when I get around to revising it. My only > concern is whether or not having "NodeConfiguration" and "NodeInfo" > classes floating around might make the framework more confusing to > read. You make an excellent point, I didn't think of it too much. This is a great suggestion, will apply it.