From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82146A0545; Mon, 20 Jun 2022 21:04:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73AC84069C; Mon, 20 Jun 2022 21:04:16 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2073.outbound.protection.outlook.com [40.107.220.73]) by mails.dpdk.org (Postfix) with ESMTP id CB4AC40151 for ; Mon, 20 Jun 2022 21:04:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y7QJLmJaI60t6+e/KwtEQjev7DKs2UtkB3zFgRq+goKM8sRJciekancU2EmPRhN4542xfZWuQeucV3Ihm1xikXODZAZcSU+uAJ6CNUQRhXOsWoVGnoBNMNEvBwkbBv2HMGHIs5ER171NGFG5cYHKf3Nk7xMUmcfl4Q12yquVetmSR+ydYW6QvFMIEWW78vWoTiBetJKF39EvksnEz0gybU3aYEac7SW3fNoPE/xbJ9ftZW94KaeHPEnhr7uKXdH6PqTGLrbp233AMTgzhbkAhcXQGyJOO/dDof8NL7X4eURvNHHVze7dkh2xh9b0G/mAPnYLERXFL4hOSRlZmyItWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VTr0up+tzuhCCBddtTRc+BMiuuRV1d4LeBGSiuzJqck=; b=ALOzjLvJD4TCuM05AdPiIUWi6eACOW1bSWmNZP+dHYovW9ss4NUuOLUl54n7AL4ud+vKy5uWCBoYS8wkNBjt36m1jp+U0JdsngNfKO4RCM7TIzsXB30wPtF+YG83GV2tV3uCaRPYRr/8HKJdkE4nwLuYp7eU+YP+mWMioLVIokSVKbhfNTGutBhNu130p07ZbFKqoqvOp99BXOl6uPYmf0UNslLHVQfe5GFYVxiFRtk38sgGwfPmMNaO+cInW6oJSQLlkRccLN3tgINJexDc7FFV/M2wO/U3ulcymTnuKUTJ76hwZCeQmKvEbkdNn3AwHluypXDgspugi7lqUQmX2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=intel.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VTr0up+tzuhCCBddtTRc+BMiuuRV1d4LeBGSiuzJqck=; b=sUvkMAKxHB8vD+MHp3vRvoMhfe/DQMv0SmWpihYO5ivmthYYPEBui6caCP+HuELWs0hh9CwTdwyJLroDTg+2sS7pFQIKpnfpaXxGdsoY5PYUbmueO3PEp96x4ChUdv2FTpeSxwaHvQhu/UzGpKSVnusDBIH196reoU4yFx8gwCM= Received: from SN7PR04CA0239.namprd04.prod.outlook.com (2603:10b6:806:127::34) by DM6PR02MB3932.namprd02.prod.outlook.com (2603:10b6:5:a6::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.19; Mon, 20 Jun 2022 19:04:12 +0000 Received: from SN1NAM02FT0028.eop-nam02.prod.protection.outlook.com (2603:10b6:806:127:cafe::48) by SN7PR04CA0239.outlook.office365.com (2603:10b6:806:127::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14 via Frontend Transport; Mon, 20 Jun 2022 19:04:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0028.mail.protection.outlook.com (10.97.4.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5353.14 via Frontend Transport; Mon, 20 Jun 2022 19:04:12 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Mon, 20 Jun 2022 20:04:10 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Mon, 20 Jun 2022 20:04:10 +0100 Envelope-to: qiming.yang@intel.com, wenjun1.wu@intel.com, yux.jiang@intel.com, xiaoyun.li@intel.com, aman.deep.singh@intel.com, yuying.zhang@intel.com, dev@dpdk.org, david.marchand@redhat.com, qi.z.zhang@intel.com Received: from [10.71.119.54] (port=52035) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o3Mh0-00078m-9a; Mon, 20 Jun 2022 20:04:10 +0100 Message-ID: <7a95dafe-bf55-1e2d-9c63-f1fe04de6f4b@xilinx.com> Date: Mon, 20 Jun 2022 20:04:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 3/3] net/ixgbe: move bypass init in a testpmd command Content-Language: en-US To: Qiming Yang , Wenjun Wu , "Jiang, YuX" CC: Xiaoyun Li , Aman Singh , Yuying Zhang , , David Marchand , Qi Z Zhang References: <20220523071031.1868862-6-david.marchand@redhat.com> <20220617050753.1273320-1-david.marchand@redhat.com> <20220617050753.1273320-3-david.marchand@redhat.com> From: Ferruh Yigit In-Reply-To: <20220617050753.1273320-3-david.marchand@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 353c0802-a79d-445f-4eac-08da52efa9a5 X-MS-TrafficTypeDiagnostic: DM6PR02MB3932:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HdOYBtlh0IipPdzVmOCmLN4lezXke4/aOM3A70/suZK6rWOVmlYyEXlbO0s5rumoBTABWFqbSN4yTldYMjLOWGpOgzGgpYvu008s5Jd4zjF3B3yliYQHaA6Zm69iwAm4IoS+5JIsAmd4SYCtVXcxLhA3qJ9cDZh+pHkBiT7V6FJK6lsaN+g17x5r9uwQ3qLhOkjZGG7+RjWnllfzu/GPdW26OdO8zpkyzDIaTpzH3/T5XZoQjkjrDNF0RPOOnA7B+VKGWJLoDGVPxTlXESL9CgByhYNKBWKD8nF183mZDwyAngNPVMP1A08BWlgQ5WlnJe4Sa9NUE//0MRnipcXbXtj9VrxG408tvvwckZ0q5eCo/WB5Fboq2zPiifZY6IddVhwm8mDTfGhEiKZYpE55eCVosTDuUzoZexuz2pdrgHbDj3MJbfbs6ZRQKRObQ+a6HnuLl0mG9x2XjlMF9/grLbfAX7tH/KPdp1CYHvfAe/D6wiOZUie4Tb4I3G13Vq6euaZC5rdIF3yjLCnzrf7axK4gZlEvs+hhXd6fUTw/fHe6uxuIWY/TJo2aqPPAKYMIh+CSVeMKyHa9IggMS3m1+1SteGdxL9Em+Ix3A7QkgwYUDIJhZR3I7m1O10tzP0Jy4qhN0k/2MDlhU0V/N/Y9KB3455tcejFo84EFxCvN3a/FBy4tASGSXgn6Tq+n1JEQ/afzH74LqIonNyl2Hi3a+ILXXO1tXYgaDedxqRjIudIM02h0YXeHNYJPm2pF/bUhGp5aviEEmNsFndDnXkzeVw== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(376002)(396003)(39860400002)(136003)(346002)(36840700001)(46966006)(40470700004)(82740400003)(36756003)(356005)(82310400005)(31686004)(36860700001)(7636003)(44832011)(40480700001)(110136005)(54906003)(316002)(53546011)(336012)(2906002)(186003)(70206006)(26005)(426003)(70586007)(83380400001)(47076005)(8676002)(4326008)(8936002)(9786002)(5660300002)(41300700001)(478600001)(2616005)(40460700003)(31696002)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 19:04:12.0534 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 353c0802-a79d-445f-4eac-08da52efa9a5 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0028.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB3932 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/17/2022 6:07 AM, David Marchand wrote: > Introduce a new command and remove the last part of specific port init > from testpmd. > > Signed-off-by: David Marchand > --- > app/test-pmd/meson.build | 1 - > app/test-pmd/testpmd.c | 4 -- > doc/guides/nics/ixgbe.rst | 7 +++ > drivers/net/ixgbe/ixgbe_testpmd.c | 82 +++++++++++++++++++++++++++++++ > 4 files changed, 89 insertions(+), 5 deletions(-) > > diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build > index 69c7595a45..d13e98125e 100644 > --- a/app/test-pmd/meson.build > +++ b/app/test-pmd/meson.build > @@ -68,7 +68,6 @@ if dpdk_conf.has('RTE_NET_I40E') > deps += 'net_i40e' > endif > if dpdk_conf.has('RTE_NET_IXGBE') > - cflags += ['-DRTE_LIBRTE_IXGBE_BYPASS'] > deps += 'net_ixgbe' > endif > if dpdk_conf.has('RTE_NET_DPAA') > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 4e8523f961..e11e2e2cb8 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3949,10 +3949,6 @@ init_port_config(void) > if (ret != 0) > return; > > -#if defined RTE_NET_IXGBE && defined RTE_LIBRTE_IXGBE_BYPASS > - rte_pmd_ixgbe_bypass_init(pid); > -#endif > - > if (lsc_interrupt && (*port->dev_info.dev_flags & RTE_ETH_DEV_INTR_LSC)) > port->dev_conf.intr_conf.lsc = 1; > if (rmv_interrupt && (*port->dev_info.dev_flags & RTE_ETH_DEV_INTR_RMV)) > diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst > index ea4684c2dc..d450fc1ca0 100644 > --- a/doc/guides/nics/ixgbe.rst > +++ b/doc/guides/nics/ixgbe.rst > @@ -418,6 +418,13 @@ Set all TCs' TX min relative bandwidth (%) globally for all PF and VFs:: > > testpmd> set tc tx min-bandwidth (port_id) (bw1, bw2, ...) > > +port config bypass > +~~~~~~~~~~~~~~~~~~ > + > +Enable/disable bypass feature:: > + > + port config bypass (port_id) (on|off) > + Hi Qiming, Wenjun, Yu, For me changes looks good but this set changes ixgbe bypass configuration in testpmd, instead of it being enabled by default, now an explicit command needs to be issued. This also can affect bypass testing. Can you please test/comment on the set for the ixgbe bypass? For both functional and dts testing perspective? Thanks, ferruh