From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE7DDA0C43; Thu, 30 Sep 2021 18:51:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F33C410E5; Thu, 30 Sep 2021 18:51:23 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id D4C1240DDA for ; Thu, 30 Sep 2021 18:51:21 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10123"; a="212492044" X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="212492044" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 09:48:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="539549107" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga004.fm.intel.com with ESMTP; 30 Sep 2021 09:48:27 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 09:48:26 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 09:48:26 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 30 Sep 2021 09:48:26 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 30 Sep 2021 09:48:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BfRg7Trx99m8OtuI7x3B5bLhLhsMfBwSap9BFEUzV/FLbEvjlb2eQJfQD7HCt6bP8fKkM5jnuVyiEWsJ8cqVm37WGmO8/uirv6sq2OcdGjRm0rGI3iRx0n1uzDPawOD/eIOv25SDaoPKO3gKYD3z8M94vj97Aw+7kbJPy/UdsgLsaaJ6Cz2WTQ9bBNw87S47NPhuJ655WWurZWPN9YT2ID3RJLsRa0VHBE7r5BrbspDiBsMDBlhGSHR9yUr6sNBbzTzhK/ty3B4f/6HXYcLbuU5C/kZbE6SqtXNVfY8xBh4Xntx36NAUcBpE2N/Uys7QIMGn4zMq/LPBtnYFwXiW8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/Q1uX7un8FCEWXR2iXDoMHGj0B93vZ6Yw20ySx7Dbms=; b=ch2YK88Epq5hldRko8vax6hxTVqnVZeYV2pmvswGCBnsui5uJBRhT9LT2Bmg+DfFKypTtcP4v/bkz1mxDkODUWml6QmPerSgBWXIIdc5CVq10KEhzKqw1GqqwX5fch+7GTEoNg76FOMzN9e/gx8HuC65Ai6KfY4g/+M5tOKFGoeytChvHHbFgWIBiju8nxwQAenkpVuz1RrJK/8MPjsIZLEaH4+maw0tIQ27NqqGP0sMiI80MnPTGQ6HHJhBF7+0428+HUAVjlhloX0gdJHqwQ1pXkiRACM1ZIbOMF1M9mwFYEUQhBB/XtIKlpE4NsPVtv48Dybf3nyfcl6hM+tSBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Q1uX7un8FCEWXR2iXDoMHGj0B93vZ6Yw20ySx7Dbms=; b=jRxJpvPpJWfL2iqvEfwy4D/atT9PwT+D+ge6/k81sGBMG0TqXWMav+ukfOrN+19SGiqrsUwD5sgkDajgeT08AN1SJ9YAiBdgxqThxIuVs1wxCWRoc/h6UNyPaFwNUuGWCFkhUh9VbkKJcOF/W/xReWRlxCwblpyF1nU7yGczjqk= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4998.namprd11.prod.outlook.com (2603:10b6:510:32::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Thu, 30 Sep 2021 16:48:11 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4544.021; Thu, 30 Sep 2021 16:48:11 +0000 To: Andrew Rybchenko , Igor Russkikh , Somalapuram Amaranath , "Rasesh Mody" , Shahed Shaikh , "Ajit Khaparde" , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Gaetan Rivet , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , Beilei Xing , "Jingjing Wu" , Qiming Yang , Andrew Boyer , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , "Viacheslav Ovsiienko" , Liron Himi , Stephen Hemminger , Long Li , Jerin Jacob , Devendra Singh Rawat , Jiawen Wu , Jian Wang , Maxime Coquelin , Chenbo Xia , Yong Wang , "Thomas Monjalon" CC: References: <20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru> <20210930160527.962319-1-andrew.rybchenko@oktetlabs.ru> <20210930160527.962319-5-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy Message-ID: <7a9a3257-3c7d-555a-7610-5ac3e9c2f177@intel.com> Date: Thu, 30 Sep 2021 17:47:58 +0100 In-Reply-To: <20210930160527.962319-5-andrew.rybchenko@oktetlabs.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0501CA0021.eurprd05.prod.outlook.com (2603:10a6:4:8f::31) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0501CA0021.eurprd05.prod.outlook.com (2603:10a6:4:8f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend Transport; Thu, 30 Sep 2021 16:48:03 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 056df9cf-5713-49c1-fce2-08d9843216a6 X-MS-TrafficTypeDiagnostic: PH0PR11MB4998: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XhwDcle1/BJCoUfpA3GlFIq/wpsufirkiT7lqNDHyGooZGGvUbJ6XRRp7MbD6uDEpjCmgcIm8mjNfaCz6+6EuOUaKKvQcFjB3xF/5LgHAGq8qiFY03ip4wOVyvRQ+h2wLjtpzXBRbh9BLPpW1D5/9JqJRjHDENa6k3BA7YUjIV1OsX2jOH95v8eBPfnCgOXPHjJ4qjSuQhb8ZtwRWtsMUwQW80UeSQDc44zdn18fyyujGmHOPZ0UfJ8tvISjozcamuqH77wMZ+2Q0E8MmkS8E+AHedaiZnyEALGABXCeu8lGnck3F0fC+5dOBUz5m6vljk+cvTyxDRj3jyPDbKCrMUii82rFtp+VDSVCHkXNHevZW3zSU/FqdjvhFKJJMSZ4unfifCpq9ekCe78EC4/ebeCwdkDdK7h4cg93KbqLycXnuCYBKlhn3iM5xr1I8+D0qfHxY0Cx6ZG2tecVMJvisd0Tj5oqz2QqfYDE3H1/sFYUOAHclHgzzLkdLXQYfcjmuk8iWYR6TiwDuAOh36PelbY6lcGsMyUFnqJbTGm4ziuwW0KaCr9Ol+HFm3fEsd717yKy6SVFP49lUDZqLtvZoXE9zYq38nY9Sf8+PChsYQu4ea7cqYaRCd8cpfMbmJ7C8UYX3DhNPnUn1O3a0nVvcW0yojVtQmoERVnSL4XMR30p5oM2y+g2ACwmOk7QNdCeqeG4+8w+tfODI2T/pRHlHOjlgG5DBjCwup6HwcQzjKs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(36756003)(921005)(316002)(7416002)(7406005)(2616005)(16576012)(8676002)(2906002)(110136005)(26005)(4326008)(5660300002)(53546011)(83380400001)(956004)(6486002)(66476007)(8936002)(86362001)(6666004)(38100700002)(186003)(66946007)(31686004)(31696002)(44832011)(4744005)(66556008)(508600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHRYL2wrY3d4VDlYaFdlOER3eGVVRU10NWdmMm9FRlNwUzRuazBxOEdrZWNs?= =?utf-8?B?cGMzSksvT3lsalJJUDUxSjFUSVR1QlBKQ0tpQjhUOCtDTTdzK09tRHlJWnNZ?= =?utf-8?B?NC82QmtnMldWRGRJMUhSTHF1ZHhSbnVVS05OMTM1TGQwbi8wbGVuRmdpVmVm?= =?utf-8?B?cHNoeEdkQVdLdDlsTWNsVTBHeDAzb1ZIRE9SelVpUnBETmgwWWdOMUVKRmgy?= =?utf-8?B?bkpaOVpUYXJ4VTUybktNWXYyL2xXK2J1Rm4vVCtZV0F0UUpaeHYzaHBzNkZH?= =?utf-8?B?L3kzRVJzTUZFb2xTNDQzZXh5Wi9hbzY5R1B0RU1PSWNWWWVtQkhmMlNTa0hW?= =?utf-8?B?SGZNZ1BRZnF3aVlQNzRheFJQajlEQklyWHhhRHFRSVpDa2FFeVR4TVdIa2FY?= =?utf-8?B?VTVVVnFoS2pvV053ZmVOdVAxbWZXdmtZSjFEQmJiYzFhZHF0U2NMNThNQ2pK?= =?utf-8?B?Wm9DZ2dZSlRySHN6WGZ6c3E3SW0zeXF1TGtETmhNQ2xFMWZ2MHRHS0lLWXAv?= =?utf-8?B?cHlmcTUwdUdpeWpmYUxyZHRvZEZGYjJ4SUNMd1ZQdjBxTHhvWVkyakJHTnFs?= =?utf-8?B?eGNFL01YT3RDZTB1OHZsY2FHMXhCU09TS3hjKzErNXlGeHdIYXB4SjRIYUhO?= =?utf-8?B?UWpxekdlUFdzWHZ2QlVyUVdMcDFadHhsUWZFUGc3N2diUysyYjkvMWpIRFNm?= =?utf-8?B?WEhqSFRmM0pZNE1YT1hLYmpDUFNvT1FPYnRtK2pxcWZOZWhyKzRINjlscktJ?= =?utf-8?B?eUdoM01TQytxaC8wSFc5MC9oTmVtSDUwZVRVUGxWVWE5aDRPK25pcXpwOEVW?= =?utf-8?B?aXM0TFNkemtKV2JJWnlFR1hwR2dOTGk3MjdsZDlaTGV1WVdVMkRMNUUxaDNR?= =?utf-8?B?anBpdWlqeDdwQjJnbk11Vm1wSVN1U3h4OHM5RWxEVXZUZUJJNnMzN3lRMm00?= =?utf-8?B?TXovT25GMlA2NTFxQW1Ga2gzb2VIQWRGQkFSQWdLcThkMDBOd0QvMTdlTm1h?= =?utf-8?B?dklXanRLbjd2cU41bjMyWXFpc21ZRVV4dHVXME0yeGNuUXlkVy9OcXFTWFly?= =?utf-8?B?ckdLQkx5b21wMlZpZWZuc0R0amdaOUZLUUV0VU9pV3VSMldkREhXdjlES2du?= =?utf-8?B?OWt1SDV0OWY3Rk1yZXJLZzhqekhDM25BUnYxUkZaZG1Jd2VTYi9YaU9qS3J4?= =?utf-8?B?TXJFS0hnZkhhNWJlN21iQXBJUVJVNXhFUjJNNUs2dThnZmFQTUp0WG5RcUFz?= =?utf-8?B?ZkNvNTNLc2huMENZVWo1d2J3Unp2eXM4UlFVd1JZeXE3SldwQTR0eXpYby9o?= =?utf-8?B?NnllSE9VL1E0TWhaRGFHVGVDQkwvMy84Vk5UaTBhYVluMlprWFZkRm1NKy9L?= =?utf-8?B?Y0lZZ3YzUjM0ZStvdk0zMmtQRmIzSFJYb1B6T2xsU1greXEySVNaNjRCbmxw?= =?utf-8?B?YjJQeGY3ZlljeFBpREE1ak40bzhUanlJcVVkQUhxMkh0TEg1MXJuekhyUnpy?= =?utf-8?B?enZJd3dNTWhPV2pMc1Awc3RrVXhYWlJ0TmFvcWlmU1d0VnNsRWJyN3J2dkdL?= =?utf-8?B?OUg1TTRVRWZpK0dyREJpSnBmY0grMUNSVVkwcDd1aE00V1VEcFBEbWU5RE55?= =?utf-8?B?OVZYbkF6bll6cVF4YjhGeFdoUHNhNHdWclJPcG1QQ2hXZ3ppMkNObWRSTGRh?= =?utf-8?B?YVIyWHNXYU9Yd1JtL1pLdDBVSGJ5WkpZeFltYnpsUXJDMVB3N0JUcyszdDVS?= =?utf-8?Q?8qml9cF6yAN14cyYfJXqZ7UgtZMmf1RUSZTep2/?= X-MS-Exchange-CrossTenant-Network-Message-Id: 056df9cf-5713-49c1-fce2-08d9843216a6 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 16:48:11.6085 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xhzzYxlYJgTOz4IiriZoP9RVziQgVMSuUiaZpNoOKhEwp6IJKvtnru+D/RNOmzd5WEqyashcpgcI0czKkPPC5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4998 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v8 5/5] ethdev: merge driver ops to get all xstats names and by ID X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/30/2021 5:05 PM, Andrew Rybchenko wrote: > All xstats names may be retrieved passing NULL ids. > > If a driver does not support getting names by IDs, the callback should > return -ENOTSUP on attempt to use it. If so, the request is handled > on ethdev layer by getting all names and filtering out requested only. > Since '-ENOTSUP' has special meaning (request ethdev layer fallback), I think it would be good to explicitly document this in the dev_ops comment. > Signed-off-by: Andrew Rybchenko