From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2142EA04B5; Wed, 30 Sep 2020 17:30:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2A5641DB65; Wed, 30 Sep 2020 17:30:25 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 69CAF1D62E for ; Wed, 30 Sep 2020 17:30:23 +0200 (CEST) IronPort-SDR: ER6A48iRLaSi9RmTcuMBbCX/0vfvvh/Jmat5ePhffqsWaQXiM75gZxoX/ixS4tCTR3fuu92oHb QfqRcMwVbDWw== X-IronPort-AV: E=McAfee;i="6000,8403,9759"; a="224069259" X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="224069259" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 08:30:20 -0700 IronPort-SDR: 8fvTu+ZsqL49kVqEzl18Dr5sGFsnItOuRP2EQJgj/HntPBpoflCc6cCd8jgiPD5gOGkaakJ2dT tvL347UZWLpg== X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="312626452" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.229.39]) ([10.213.229.39]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 08:30:17 -0700 From: Ferruh Yigit To: Li Zhang , dekelp@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com, matan@nvidia.com Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com References: <20200908100636.4575-1-lizh@nvidia.com> <20200909033434.31059-1-lizh@nvidia.com> <6de9d63f-f4ba-9cac-0f00-24cdf609f9b6@intel.com> Message-ID: <7aa3da2e-7cf1-8291-dac0-a52ff9716b29@intel.com> Date: Wed, 30 Sep 2020 16:30:13 +0100 MIME-Version: 1.0 In-Reply-To: <6de9d63f-f4ba-9cac-0f00-24cdf609f9b6@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC v2 1/1] app/testpmd: distinguish ICMP identifier fields in packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/23/2020 10:04 AM, Ferruh Yigit wrote: > On 9/9/2020 4:34 AM, Li Zhang wrote: >> From: lizh >> >> Ability to distinguish ICMP identifier fields in packets. >> Dstinguish ICMP sequence number field too. >> Already supports ICMP code and type fields in current version. >> Existing fields in ICMP header contain the required information. >> ICMP header already is supported and no code change in RTE FLOW. >> Extend testpmd CLI to include the fields of ident and sequence number. >> One example: >> flow create 0 ingress pattern eth / ipv4 / >>   icmp code is 1 ident is 5 seq is 6 / >>   end actions count / queue index 0 / end >> The ICMP packet with code 1, identifier 5 and >> sequence number 6 will be matched. >> It will implement action counter and forward to queue 0. >> >> Signed-off-by: Li Zhang > > > Reviewed-by: Ferruh Yigit > Applied to dpdk-next-net/main, thanks.