From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93830A0577; Mon, 13 Apr 2020 19:01:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B8EF31C067; Mon, 13 Apr 2020 19:01:40 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id ABF861C044 for ; Mon, 13 Apr 2020 19:01:39 +0200 (CEST) IronPort-SDR: p9RyINAMIRrHUzH8fO2DhxyYG4IWTOcrYlphHAvoWsWzGvJex8Gkjdb0iDUBhC9BHeZ1HIjc3E twiXcTBONu1A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2020 10:01:38 -0700 IronPort-SDR: +3wKwp2DzgHHQY/w7Cb1Tcc0JO4/fYmBIZMpinvQyzXJqtPial89JoC1AD9vHiiOdXuYEzyfEL ZPS/Z9KMkTAg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,378,1580803200"; d="scan'208";a="256235269" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga006.jf.intel.com with ESMTP; 13 Apr 2020 10:01:38 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Apr 2020 10:01:38 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 14 Apr 2020 01:01:35 +0800 Received: from shsmsx603.ccr.corp.intel.com ([10.109.6.143]) by SHSMSX603.ccr.corp.intel.com ([10.109.6.143]) with mapi id 15.01.1713.004; Tue, 14 Apr 2020 01:01:35 +0800 From: "Wang, Haiyue" To: Thomas Monjalon CC: "dev@dpdk.org" , "vattunuru@marvell.com" , "jerinj@marvell.com" , "alex.williamson@redhat.com" , "david.marchand@redhat.com" Thread-Topic: [PATCH v4] eal: add VFIO-PCI SR-IOV support Thread-Index: AQHWEW7TGVSo7x234U64DiMjtXd2p6h2ckiAgADUPgA= Date: Mon, 13 Apr 2020 17:01:35 +0000 Message-ID: <7abe509607064ff2a164d681dfb17d9c@intel.com> References: <20200305043311.17065-1-vattunuru@marvell.com> <20200413082930.84050-1-haiyue.wang@intel.com> <3639790.NG923GbCHz@thomas> In-Reply-To: <3639790.NG923GbCHz@thomas> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] eal: add VFIO-PCI SR-IOV support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, April 13, 2020 20:18 > To: Wang, Haiyue > Cc: dev@dpdk.org; vattunuru@marvell.com; jerinj@marvell.com; alex.william= son@redhat.com; > david.marchand@redhat.com > Subject: Re: [PATCH v4] eal: add VFIO-PCI SR-IOV support >=20 > Hi, >=20 > About the title, I think it does not convey what is new here. > VFIO is not new, SR-IOV is already supported. > The title should mention the new VFIO feature in few simple words. > Is it only about using VFIO for PF? >=20 For Both. Align with Alex's : vfio-pci: QEMU support for vfio-pci VF tokens How about: 'eal: support for VFIO-PCI VF tokens' ? >=20 > 13/04/2020 10:29, Haiyue Wang: > > v4: 1. Ignore rte_vfio_setup_device ABI check since it is > > for Linux driver use. > [...] > > +; Ignore this function which is only relevant to linux for driver > > +[suppress_type] > > + name =3D rte_vfio_setup_device >=20 > Adding such exception for all internal "driver interface" functions > is not scaling. Please use __rte_internal. > I am waiting for the patchset about rte_internal to be reviewed or comple= ted. > As it is not progressing, the decision is to block any patch having > ABI issue because of internal false positive. > Please help, thanks. >=20 I will drop this patch ABI workaround, and try to catch the '__rte_internal= ' design.