From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id CC7301B1A0 for ; Tue, 19 Sep 2017 15:33:48 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2017 06:33:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,418,1500966000"; d="scan'208";a="901833839" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 19 Sep 2017 06:33:22 -0700 To: Shreyansh Jain Cc: dev@dpdk.org, hemant.agrawal@nxp.com References: <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170909112132.13936-1-shreyansh.jain@nxp.com> <20170909112132.13936-3-shreyansh.jain@nxp.com> <2392e7d0-4790-9f1f-27b1-62b8fe775a87@nxp.com> From: Ferruh Yigit Message-ID: <7ac1a6dd-8fdc-9ee0-2376-b37e2247945a@intel.com> Date: Tue, 19 Sep 2017 14:33:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <2392e7d0-4790-9f1f-27b1-62b8fe775a87@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 02/41] bus/dpaa: introduce NXP DPAA Bus driver skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2017 13:33:49 -0000 On 9/19/2017 2:14 PM, Shreyansh Jain wrote: > Hello Ferruh, > > On Monday 18 September 2017 08:17 PM, Ferruh Yigit wrote: >> On 9/9/2017 12:20 PM, Shreyansh Jain wrote: >>> Signed-off-by: Shreyansh Jain >>> Signed-off-by: Hemant Agrawal <...> >>> +struct rte_dpaa_device { >>> + TAILQ_ENTRY(rte_dpaa_device) next; >>> + struct rte_device device; >>> + union { >>> + struct rte_eth_dev *eth_dev; >>> + struct rte_cryptodev *crypto_dev; >>> + }; >> >> Bus struct should be independt from functionality, this has been done in >> PCI, can same thing be done for dpaa bus too? > > Sorry, I didn't get your point. This is the rte_dpaa_bus structure: > > struct rte_dpaa_bus { > struct rte_bus bus; > struct rte_dpaa_device_list device_list; > struct rte_dpaa_driver_list driver_list; > int device_count; > }; > > If you are referring to unlinking eth/crypto functionality from > rte_dpaa_device - that is something which needs investigation. I have > seen patches on PCI from Gaetan. Can that be an incremental change over > this? Yes, I was refereeing this. I am OK doing this incremental. <...>