From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DD6EA058A; Wed, 1 Apr 2020 13:33:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D17451BE8D; Wed, 1 Apr 2020 13:33:21 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 56C7C1BE0C for ; Wed, 1 Apr 2020 13:33:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585740799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7NFq/9ktM+u2OJjwG5cROMNugjEOps8O6J5lpq4z+cQ=; b=CNsk4GuqfWxck0oM4VwZRJJ8QJqbK+4iTjpKclhlbEI7Mm2hS0ynMQehyZDdQC++fDA/gw YfbmQ42X8ciwSYLxPFF6+R+2/98FWzUwM8L889m1Qx0oPkvoKTMGKydvP04A3w+eMKERc9 jsZCZO/8CWvN0iH1gNnnhfy98nsXkDQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-328-jJAgDvKxMsO5Nb7Ni3rBsg-1; Wed, 01 Apr 2020 07:33:17 -0400 X-MC-Unique: jJAgDvKxMsO5Nb7Ni3rBsg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 76B4D1406; Wed, 1 Apr 2020 11:33:14 +0000 (UTC) Received: from [10.33.36.227] (unknown [10.33.36.227]) by smtp.corp.redhat.com (Postfix) with ESMTP id E8B0EA63AA; Wed, 1 Apr 2020 11:33:09 +0000 (UTC) To: Stephen Hemminger Cc: Thomas Monjalon , dev@dpdk.org, bruce.richardson@intel.com, ravi1.kumar@amd.com, g.singh@nxp.com, hemant.agrawal@nxp.com, akhil.goyal@nxp.com, johndale@cisco.com, hyonkim@cisco.com, jingjing.wu@intel.com, wenzhuo.lu@intel.com, rmody@marvell.com, shshaikh@marvell.com, matan@mellanox.com, shahafs@mellanox.com, declan.doherty@intel.com, cristian.dumitrescu@intel.com References: <20200325141137.7088-1-ktraynor@redhat.com> <11831469.VsHLxoZxqI@xps> <4613d437-5a0c-b664-8435-699c43b63f94@redhat.com> <20200331075337.222cc047@hermes.lan> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: <7ac287d7-b6fc-fc24-545e-24631c961e0a@redhat.com> Date: Wed, 1 Apr 2020 12:33:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200331075337.222cc047@hermes.lan> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [RFC 0/2] gcc 10 disable stringop-overflow warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 31/03/2020 15:53, Stephen Hemminger wrote: > On Tue, 31 Mar 2020 15:08:26 +0100 > Kevin Traynor wrote: >=20 >> struct virtchnl_rss_key { >> u16 vsi_id; >> u16 key_len; >> u8 key[1]; /* RSS hash key, packed bytes */ >> ^^^^^^^^^ >> }; >> >> Then in iavf_configure_rss_key() >> >> =09len =3D sizeof(*rss_key) + vf->vf_res->rss_key_size - 1; >> ^^^^^^^^^^^^ >> =09rss_key =3D rte_zmalloc("rss_key", len, 0); >> ^^^ extra space beyond key[1] allocated here >> >> >> =09rte_memcpy(rss_key->key, vf->rss_key, vf->vf_res->rss_key_size); >> =09 ^^^ ^^^^^^^^^^^^ >> >> At runtime we have allocated extra space at the end of the struct for >> key, and the same size used in the malloc is also considered when >> finding the right branches in the memcpy fns. But the compiler does not >> know value of size and it simply sees there can be casts of a 1 byte key >> to 16 or 32 bytes in some branches of the memcpy fns, so gives a warning= . >=20 > The standard way to do such a thing is to use an empty > array. The Linux kernel has just gone through cleaning up > all these zero length (and it this case one) array at > end of function. >=20 Thanks for the tip. There is only one occurrence of a zero-length array in these warning (sess_data[0] in ice) and changing to [] does indeed remove the warning for that. For the others they have a defined length so it cannot just be removed, some don't have any dynamic allocation at all, sizes are checked etc. I don't think adding dynamic allocation for those structs just to get around this warning is the right way to go. Crypto/iavf/ip_pipeline maintainers - any comment? ../drivers/crypto/caam_jr/caam_jr_pvt.h:187:10: note: at offset 0 to object =E2=80=98digest=E2=80=99 with size 32 declared here ../drivers/crypto/ccp/ccp_crypto.h:272:11: note: at offset 0 to object =E2=80=98key=E2=80=99 with size 32 declared here ../drivers/crypto/dpaa_sec/dpaa_sec.h:217:10: note: at offset 0 to object =E2=80=98digest=E2=80=99 with size 32 declared here ../drivers/crypto/virtio/virtio_cryptodev.h:36:10: note: at offset 0 to object =E2=80=98iv=E2=80=99 with size 16 declared here ../drivers/net/iavf/../../common/iavf/virtchnl.h:508:5: note: at offset 0 to object =E2=80=98key=E2=80=99 with size 1 declared here ../drivers/net/iavf/../../common/iavf/virtchnl.h:516:5: note: at offset 0 to object =E2=80=98lut=E2=80=99 with size 1 declared here ../lib/librte_pipeline/rte_table_action.c:1648:12: note: at offset 0 to object =E2=80=98cipher_iv=E2=80=99 with size 16 declared here ../lib/librte_pipeline/rte_table_action.c:1650:12: note: at offset 0 to object =E2=80=98auth_iv=E2=80=99 with size 16 declared here ../lib/librte_pipeline/rte_table_action.c:1655:12: note: at offset 0 to object =E2=80=98iv=E2=80=99 with size 16 declared here ../lib/librte_pipeline/rte_table_action.c:1656:12: note: at offset 0 to object =E2=80=98aad=E2=80=99 with size 16 declared here ../lib/librte_pipeline/rte_table_action.c:1728:10: note: at offset 0 to object =E2=80=98iv_aad_data=E2=80=99 with size 32 declared here