DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>, dev@dpdk.org
Cc: satishr@chelsio.com, indranil@chelsio.com
Subject: Re: [dpdk-dev] [PATCH 2/4] net/cxgbe: fix macros related to logs for Windows
Date: Tue, 18 Dec 2018 18:25:26 +0000	[thread overview]
Message-ID: <7aca347c-b551-f092-ba3b-e31e83eeed26@intel.com> (raw)
In-Reply-To: <1544713333-32239-3-git-send-email-rahul.lakkireddy@chelsio.com>

On 12/13/2018 3:02 PM, Rahul Lakkireddy wrote:
> Replace "args..." with "fmt, ..." and directly use __VA_ARGS__.

What do you mean exactly by "for Windows"? Which compiler? Is there a specific C
standard version you target? What is the issue with existing macros?

Since we don't have a Windows support in DPDK, yet, it is not clear what you are
targeting.

> 
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
<...>

  reply	other threads:[~2018-12-18 18:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13 15:02 [dpdk-dev] [PATCH 0/4] net/cxgbe: fix build for Microsoft Windows OS support Rahul Lakkireddy
2018-12-13 15:02 ` [dpdk-dev] [PATCH 1/4] net/cxgbe: use relative paths for including header files Rahul Lakkireddy
2018-12-18 18:23   ` Ferruh Yigit
2018-12-19 12:42     ` Rahul Lakkireddy
2018-12-13 15:02 ` [dpdk-dev] [PATCH 2/4] net/cxgbe: fix macros related to logs for Windows Rahul Lakkireddy
2018-12-18 18:25   ` Ferruh Yigit [this message]
2018-12-19 12:39     ` Rahul Lakkireddy
2018-12-19 13:45       ` Ferruh Yigit
2018-12-19 14:11         ` Rahul Lakkireddy
2018-12-13 15:02 ` [dpdk-dev] [PATCH 3/4] net/cxgbe: only redefine symbols when not available " Rahul Lakkireddy
2018-12-18 18:26   ` Ferruh Yigit
2018-12-19 12:41     ` Rahul Lakkireddy
2018-12-13 15:02 ` [dpdk-dev] [PATCH 4/4] net/cxgbe: fix other misc build issues " Rahul Lakkireddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7aca347c-b551-f092-ba3b-e31e83eeed26@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=indranil@chelsio.com \
    --cc=rahul.lakkireddy@chelsio.com \
    --cc=satishr@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).