From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C9D7345CB3;
	Fri,  8 Nov 2024 15:36:55 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9C3CE43348;
	Fri,  8 Nov 2024 15:36:55 +0100 (CET)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id 19BF24025C
 for <dev@dpdk.org>; Fri,  8 Nov 2024 15:36:54 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2BD5F339;
 Fri,  8 Nov 2024 06:37:23 -0800 (PST)
Received: from [10.57.59.19] (unknown [10.57.59.19])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 81CE33F528;
 Fri,  8 Nov 2024 06:36:52 -0800 (PST)
Message-ID: <7addc28d-2ad7-4b7b-9448-f2f94b2c783a@arm.com>
Date: Fri, 8 Nov 2024 14:36:50 +0000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] dts: add blocked ports to EalParams
Content-Language: en-GB
To: Nicholas Pratte <npratte@iol.unh.edu>
Cc: dev@dpdk.org, Paul Szczepanek <paul.szczepanek@arm.com>,
 Patrick Robb <probb@iol.unh.edu>
References: <20240625123611.1474204-1-luca.vizzarro@arm.com>
 <20241107135654.4121761-1-luca.vizzarro@arm.com>
 <20241107135654.4121761-2-luca.vizzarro@arm.com>
 <CAKXZ7ejSwHJ4rEugXHCQRZG+MVjHwA4rU_Uhh5OaTEw55KoRHg@mail.gmail.com>
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
In-Reply-To: <CAKXZ7ejSwHJ4rEugXHCQRZG+MVjHwA4rU_Uhh5OaTEw55KoRHg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 07/11/2024 19:04, Nicholas Pratte wrote:
> Hi Luca, this looks good to me! The only thing that needs to be fixed
> is the attributes component of the docstring for EalParams in eal.py.
> Aside from that:
> 
> Reviewed-by: Nicholas Pratte <npratte@iol.unh.edu>

Great, catch! Thanks!