Re: [dpdk-dev] [dpdk-stable] 17.11.10 (LTS) patches review and test

[Luca Boccassi <bluca@debian.org>]

On Wed, 2020-01-22 at 15:17 +0100, Kevin Traynor wrote:
> On 22/01/2020 12:37, Luca Boccassi wrote:
> > On Wed, 2020-01-22 at 05:27 +0000, Yu, PingX wrote:
> > > Luca,
> > > Update the regression test result of Intel part. See the details
> > > as
> > > below.
> > > 
> > > * Intel(R) Testing
> > > # Basic Intel(R) NIC testing
> > > * PF(i40e): one compile issue is found and we fix it with
> > > attached
> > > patch to go ahead the test. All passed. 
> > >   1. Bugs:make -j 110 -C test Compile failed
> > > * PF(ixgbe): the same as PF(i40e).
> > > * VF: Pass
> > > * Build or compile: Pass
> > > * Intel NIC single core/NIC performance: Pass 
> > >  
> > > #Basic cryptodev and virtio testing
> > > * vhost/virtio basic loopback, PVP and performance test: Pass.
> > > * cryptodev: 1 bug is found.
> > >   1. [dpdk-stable-17.11.10]Crypto:cryptodev_qat_autotest test
> > > failed.
> > > PS: issue passed on 17.11.9.
> > >   
> > > Regards,
> > > Yu Ping
> > 
> > Hello Yu,
> > 
> > Thanks for the report. For the first issue, you mention the patch
> > is
> > attached, but there were no attachments in your mail?
> > 
> 
> I got the attachment, pasting below as it's straightforward. Didn't
> check but I wonder is that the right Fixes commit, or another commit
> removed path[] being used.
> 
> From bfb6609bc7c8d9d19f74eff6798c9a6931fe0d75 Mon Sep 17 00:00:00
> 2001
> From: Jiang Mao <
> maox.jiang@intel.com
> >
> Date: Fri, 17 Jan 2020 12:53:11 -0500
> Subject: [PATCH] test/test: fix test app defining unused variable
> 
> Delete the unused variable to solve compiling error.
> 
> Signed-off-by: Jiang Mao <
> maox.jiang@intel.com
> >
> 
> Fixes: af75078f ("first public release")
> ---
> Note: This patch just fixes v17.11.10-rc1, the other version have no
> compiling error.
>  test/test/process.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/test/test/process.h b/test/test/process.h
> index 505d2f9..1c369e8 100644
> --- a/test/test/process.h
> +++ b/test/test/process.h
> @@ -56,7 +56,6 @@
>  	int num;
>  	char *argv_cpy[numargs + 1];
>  	int i, status;
> -	char path[32];
> 
>  	pid_t pid = fork();
>  	if (pid < 0)
> 

Thanks - the culprit is this botched backport which was adjusted but
not enough and the unused variable was left behind:

Fixes: 0ecbf7984bb0 ("test: optimise fd closing in forks")

Applied with adjusted fixes line

-- 
Kind regards,
Luca Boccassi