From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D209FA0547; Fri, 10 Sep 2021 13:44:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64D00410DA; Fri, 10 Sep 2021 13:44:37 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 3513540DDE for ; Fri, 10 Sep 2021 13:44:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631274275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n9t9isJos98cvMa6zZtxp55kmSSCK/aCfqh/0mvTdbA=; b=eujM8aPJrMY4rT7ERCYE/cQldQHvbE2FJddgQorZsq3jChR550ViDoESTDpZM1PmtNFZVy C0w6ZBpiUDe2qidpvbI56ieuq/8v0a2NVMNuOl7EjaRBfSs/4Nq4QJZt35hPULahs9uUX0 0SRoWDUfaKbZrqA4eLxzS9eyuA+AY2o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-581-cROvJsD0Mo2MzR1ZjK11qw-1; Fri, 10 Sep 2021 07:44:32 -0400 X-MC-Unique: cROvJsD0Mo2MzR1ZjK11qw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D52A018B3120; Fri, 10 Sep 2021 11:44:30 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C9E0418FD2; Fri, 10 Sep 2021 11:44:24 +0000 (UTC) To: Andrew Rybchenko , dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com, david.marchand@redhat.com, ferruh.yigit@intel.com, michaelba@nvidia.com, viacheslavo@nvidia.com Cc: stable@dpdk.org, nelio.laranjeiro@6wind.com References: <20210910091734.7023-1-maxime.coquelin@redhat.com> <20210910091734.7023-2-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <7b22e721-c091-6529-88f0-50169e7ab1ba@redhat.com> Date: Fri, 10 Sep 2021 13:44:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/3] net/virtio: add initial RSS support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks for the review! On 9/10/21 12:06 PM, Andrew Rybchenko wrote: > On 9/10/21 12:17 PM, Maxime Coquelin wrote: >> This patch adds RSS support to the Virtio PMD. It provides > > I'd drop the first sentence since summary already says so and > suggest to start the second from "Provide ..." > >> the capability to update the hash key, hash types and reta > > reta -> RETA (see devtools/words-case.txt) > >> table on the fly (without needing to stop/start the >> device). However, the key length and the number of reta > > reta -> RETA Got it, I'll fix it here and everywhere else. >> entries are fixed to 40B and 128 entries respectively. This >> is done in order to simplify the design, but may be >> revisited later as the Virtio spec provides this >> flexibility. > > I've failed to find F_RSS definion in virtio spec. > Could you share the reference, please. > > Without the sepc it is almost impossible to review the code. Sorry, I forgot to add the link, you can find it on the Virtio-spec github master branch: https://github.com/oasis-tcs/virtio-spec/blob/master/content.tex For readability, I would suggest you to clone it and build the HTML or PDF versions. >> >> Note that only VIRTIO_NET_F_RSS support is implemented, >> VIRTIO_NET_F_HASH_REPORT, which would enable reporting the >> packet RSS hash calculated by the device into mbuf.rss, is >> not yet supported. >> >> Regarding the default RSS configuration, it has been >> chosen to use the default Intel ixgbe key as default key, >> and default reta is a simple modulo between the hash and > > reta -> RETA > >> the number of Rx queues. >> >> Signed-off-by: Maxime Coquelin >> --- >> doc/guides/nics/features/virtio.ini | 2 + >> doc/guides/nics/virtio.rst | 3 + >> doc/guides/rel_notes/release_21_11.rst | 5 + >> drivers/net/virtio/virtio.h | 31 ++- >> drivers/net/virtio/virtio_ethdev.c | 367 ++++++++++++++++++++++++- >> drivers/net/virtio/virtio_ethdev.h | 3 +- >> drivers/net/virtio/virtqueue.h | 21 ++ >> 7 files changed, 426 insertions(+), 6 deletions(-) >> >> diff --git a/doc/guides/nics/features/virtio.ini b/doc/guides/nics/features/virtio.ini >> index 48f6f393b1..883dd1426c 100644 >> --- a/doc/guides/nics/features/virtio.ini >> +++ b/doc/guides/nics/features/virtio.ini >> @@ -14,6 +14,8 @@ Promiscuous mode = Y >> Allmulticast mode = Y >> Unicast MAC filter = Y >> Multicast MAC filter = Y > > I'd say that > RSS has = P > should be added here. OK, as I mentionned in the cover letter, I was not sure becasue the doc says "RSS hash" uses DEV_RX_OFFLOAD_RSS_HASH and provides mbuf.rss, which this patch does not since it does not support (yet) VIRTIO_NET_F_HASH_REPORT. http://doc.dpdk.org/guides/nics/features.html#rss-hash I can try to add VIRTIO_NET_F_HASH_REPORT in v2, so that we can set RSS hash = Y without any doubts :) Regards, Maxime