From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE3D742413; Thu, 19 Jan 2023 06:21:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B464F410DD; Thu, 19 Jan 2023 06:21:31 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mails.dpdk.org (Postfix) with ESMTP id 118AE4068E for ; Thu, 19 Jan 2023 06:21:30 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 42C1C61B10; Thu, 19 Jan 2023 05:21:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F08DC433F0; Thu, 19 Jan 2023 05:21:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674105688; bh=hnridnnpCAaLv/U9ck/J3iOn7wHNmz0dmj8mzAE/z48=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=nOEV+gTYtevHVHE89IJKrm2xG1zGbrVH8CogPHoCMdra1scT9VfwlzOPul/KXmbFu Oi2CbX6EfmEofWxrpfU/I6wEsdgHztqkxTjmMLgkhNHGcl9ZmMpDj+FIFHFoIQfHVD iJ7yrL+HVZZJtc8M2BMcWnYXYKuiwuHMLijPqgIYxeOGnneWaxRUpp3Z34MeCPGZiN hotKzOXNuvdK5q3pkLuLNf+XZLtPmIGqUqLuWnLmP/4Ed8JTOHxLjQ8GdB1T2L8JTa Jry0gEZii67TnHzib3PgiX4Vl69w/52ZbEM79im6T6owOUL+I12CLgisquQGony4Cg gA7DG2IvchXBA== Message-ID: <7b2aa25f9b4513f61004affe0d4aa9d6c3e15386.camel@kernel.org> Subject: Re: [PATCH RESEND v2 02/11] net/tap: check if name is null From: Sinan Kaya To: Ferruh Yigit Cc: dev@dpdk.org Date: Thu, 19 Jan 2023 00:21:26 -0500 In-Reply-To: References: <20221122153053.1172434-1-okaya@kernel.org> <20221122153053.1172434-3-okaya@kernel.org> Content-Type: multipart/alternative; boundary="=-f/pQk+4gxYEp+m5X1MXT" User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --=-f/pQk+4gxYEp+m5X1MXT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2023-01-18 at 10:57 +0000, Ferruh Yigit wrote: > I assume this is highlighted by a tool but in practice > > 'rte_vdev_device_name()' should not return NULL, and there are many > > other location this check is missing. That's correct. Warning was found by codeql static analysis tool. When I search the codebase, I do see a mixture of null checks and no checks for this function. We can ignore this patch, if you feel strongly against it. --=-f/pQk+4gxYEp+m5X1MXT Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
On Wed, 2023-01-18 at 10:57 +0000, Ferruh Yigit wrote:
I assume this is highlighted by a tool but in practi=
ce

'rte_vdev_device_name()' should not return NULL=
, and there are many

other location this check is =
missing.

That's correct. Warning was = found by codeql static analysis tool. When I search the codebase,
I do see a mixture of null checks and no checks for this function. We can = ignore this patch, if you
feel strongly against it.
<= /html> --=-f/pQk+4gxYEp+m5X1MXT--