From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F745A0503; Thu, 19 May 2022 12:13:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 743F240222; Thu, 19 May 2022 12:13:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3F48340156 for ; Thu, 19 May 2022 12:13:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652955187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NL30vJXnLkvvP9ksnd75/BPATVpOctHgI4F3TIBVMto=; b=RZ1JX48u7xHTrewrxOsi0szWms1+iRpZgbQLNXCRUZieJXtmUDupwdQl8xLFH4oWA43XZ9 9O2Mrbd71jH3T5j+GkNPSROkb0pkarS4wposPrtXZYHFi5/a67o7jYkz/x5EM2mtOj8CQr cC2qceuid9VZGkzdGZog/CoAypPSgQE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-557-uBBYysKTP96z3O8I6DTLrg-1; Thu, 19 May 2022 06:13:06 -0400 X-MC-Unique: uBBYysKTP96z3O8I6DTLrg-1 Received: by mail-wr1-f72.google.com with SMTP id t9-20020a5d5349000000b0020d02cd51fbso1390900wrv.13 for ; Thu, 19 May 2022 03:13:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=NL30vJXnLkvvP9ksnd75/BPATVpOctHgI4F3TIBVMto=; b=Ps+ZObXyGDOYPsmubrdBhkrvdKaTW8aM+zNjJByiwK8gQLBpGr9vVlX9QnWqAZBxSj xD53HN/dXFiWbxwE4w8QiA0JQxJcYzELNPEVsmFXEh0GOiFB0hBUQXM4Tu4rMOcNj6MH azt/r3KPzHhbcQBVlJiFHntW82Kac9b8JYAol3JFHx32Tt2QxMBuu+OM31ZKPjuc8QcJ FF7I7jreF2VnMJlB6c95HyMqjgs50rFR7jAD3GcnmnDoD6bTsNf8HDwKPIkvlAqZxxuI 39UBZd952JMlF/jwPkd1K/2KKQfq7Me+GMzfgq90tJxoyJtCAhTg3BO5EOPLgLFUpOyA ZtEw== X-Gm-Message-State: AOAM530SGvmhaSNBkE5+XFgnaQCiUl8mhRlj04TIqr0dbg5ffwIy9IX8 KQbekFKrfHjwflcOohFVXTTAIdJ4IK7VDxa6SBuBXBlNcqAAZkaBOS9ut87yrADnTWyQSa8DIVI IXkw= X-Received: by 2002:adf:d1cf:0:b0:20c:a6c4:98f5 with SMTP id b15-20020adfd1cf000000b0020ca6c498f5mr3331627wrd.501.1652955185504; Thu, 19 May 2022 03:13:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAexjlP6qHNWKWuehQtqmPuhNyBXMiq0lQZlo2xRZSbv3E0z3jxjAxR2fNPjg+OJZIAhalKQ== X-Received: by 2002:adf:d1cf:0:b0:20c:a6c4:98f5 with SMTP id b15-20020adfd1cf000000b0020ca6c498f5mr3331605wrd.501.1652955185299; Thu, 19 May 2022 03:13:05 -0700 (PDT) Received: from [192.168.0.36] ([78.19.99.101]) by smtp.gmail.com with ESMTPSA id p24-20020a1c7418000000b0039729309a84sm2228846wmc.20.2022.05.19.03.13.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 03:13:04 -0700 (PDT) Message-ID: <7b3616db-d06b-e838-a9b0-20ef5ec374c2@redhat.com> Date: Thu, 19 May 2022 11:13:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 To: Ferruh Yigit , Ed Czeck , dev@dpdk.org Cc: Shepard Siegel , John Miller , Luca Boccassi References: <20220502212232.1283-1-ed.czeck@atomicrules.com> <20220506212732.28504-1-ed.czeck@atomicrules.com> <4fbed18d-794a-dc11-ae98-20ab4f345e44@xilinx.com> From: Kevin Traynor Subject: Re: [PATCH v1 1/5] net/ark: update mpu code to match current hardware version In-Reply-To: <4fbed18d-794a-dc11-ae98-20ab4f345e44@xilinx.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 18/05/2022 13:54, Ferruh Yigit wrote: > On 5/6/2022 10:27 PM, Ed Czeck wrote: >> new version code >> remove device-level global operations >> remove ark_mpu_reset_stats function >> > > Hi Ed, please find a few comments inline. > > Also I assume 'mpu' is an abbreviation, can you please document what it > stands for in the commit log, like MPU (M.. P.. U..)? > And can you please make it uppercase in the commit title, also if you > can add them to 'devtools/words-case.txt' (in a separate patch), it will > be checked next time by './devtools/check-git-log.sh' script. > Same for all patches. > >> Signed-off-by: Ed Czeck >> --- >> drivers/net/ark/ark_ethdev.c | 2 -- >> drivers/net/ark/ark_ethdev_rx.c | 4 ---- >> drivers/net/ark/ark_mpu.c | 21 ++++----------------- >> drivers/net/ark/ark_mpu.h | 29 ++--------------------------- >> 4 files changed, 6 insertions(+), 50 deletions(-) >> > > <...> > >> @@ -24,10 +24,10 @@ ark_mpu_verify(struct ark_mpu_t *mpu, uint32_t obj_size) >> { >> uint32_t version; >> >> - version = mpu->id.vernum & 0x0000fF00; >> - if ((mpu->id.idnum != 0x2055504d) || >> - (mpu->hw.obj_size != obj_size) || >> - (version != 0x00003100)) { >> + version = mpu->id.vernum; >> + if (mpu->id.idnum != ARK_MPU_MODID || >> + version != ARK_MPU_MODVER || >> + mpu->hw.obj_size != obj_size) { > > The driver will work with a specific version of the 'MPU'. So a device > previously working with previous version of the driver, won't work > anymore after this patch, and will be forced to a (FW/bitstream/?) update. > I am not sure how problematic is this from the stable release > perspective. cc'ed maintainers. > While it is nice-to-have, stable releases are not guaranteed to work with future HW/FW/3rd party software etc. More importantly, a user should not *have* to make updates outside DPDK when moving along a single DPDK LTS stream. e.g. 21.11.1 -> 21.11.2. > But at least won't it be good to document this in release notes, and > perhaps having a table in the driver documentation to list which DPDK > version requires which HW version can be good, what do you think? > I agree documenting the matching versions is good for usability. e.g. http://doc.dpdk.org/guides/nics/ice.html#recommended-matching-list