From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7D8BA41B98;
	Thu,  9 Feb 2023 07:48:16 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 170BC40EDC;
	Thu,  9 Feb 2023 07:48:16 +0100 (CET)
Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])
 by mails.dpdk.org (Postfix) with ESMTP id 304554067B
 for <dev@dpdk.org>; Thu,  9 Feb 2023 07:48:14 +0100 (CET)
Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.57])
 by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4PC6lB4QS6zJr0b;
 Thu,  9 Feb 2023 14:43:34 +0800 (CST)
Received: from [10.67.100.224] (10.67.100.224) by
 dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.34; Thu, 9 Feb 2023 14:48:12 +0800
Subject: Re: [PATCH v13 1/6] memarea: introduce memarea library
To: Stephen Hemminger <stephen@networkplumber.org>
CC: <david.marchand@redhat.com>, <mb@smartsharesystems.com>,
 <anatoly.burakov@intel.com>, <dmitry.kozliuk@gmail.com>,
 <jerinjacobk@gmail.com>, <hofors@lysator.liu.se>, <thomas@monjalon.net>,
 <dev@dpdk.org>
References: <20220721044648.6817-1-fengchengwen@huawei.com>
 <20230208082452.43883-1-fengchengwen@huawei.com>
 <20230208082452.43883-2-fengchengwen@huawei.com>
 <20230208160421.05ba646c@hermes.local>
From: fengchengwen <fengchengwen@huawei.com>
Message-ID: <7b5a30ba-a199-340a-524f-f588faabec14@huawei.com>
Date: Thu, 9 Feb 2023 14:48:11 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20230208160421.05ba646c@hermes.local>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.100.224]
X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To
 dggpeml500024.china.huawei.com (7.185.36.10)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2023/2/9 8:04, Stephen Hemminger wrote:
> On Wed, 8 Feb 2023 08:24:47 +0000
> Chengwen Feng <fengchengwen@huawei.com> wrote:
> 
>> +RTE_LOG_REGISTER_DEFAULT(rte_memarea_logtype, INFO);
>> +#define RTE_MEMAREA_LOG(level, ...) \
>> +	rte_log(RTE_LOG_ ## level, rte_memarea_logtype, RTE_FMT("memarea: " \
>> +		RTE_FMT_HEAD(__VA_ARGS__,) "\n", RTE_FMT_TAIL(__VA_ARGS__,)))
>> +
> 
> For me it is easier to read as:
> #define RTE_MEMAREA_LOG(level, fmt, args...) \
> 	rte_log(RTE_LOG_ ## level, rte_memarea_logtype, \
> 		"memarea: " fmt "\n", ## args)
> 
> 
> A common convention is to use "%s: " and __func__.

All fix in v14, thanks.

> .
>