From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 456341B29B for ; Fri, 20 Oct 2017 21:39:31 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Oct 2017 12:39:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,408,1503385200"; d="scan'208";a="912035359" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.220]) ([10.241.224.220]) by FMSMGA003.fm.intel.com with ESMTP; 20 Oct 2017 12:39:30 -0700 To: Ajit Khaparde , dev@dpdk.org References: <20171012173521.54626-1-ajit.khaparde@broadcom.com> <20171012173521.54626-4-ajit.khaparde@broadcom.com> From: Ferruh Yigit Message-ID: <7b5c8ca8-7523-add0-0cca-826278496a19@intel.com> Date: Fri, 20 Oct 2017 12:39:30 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171012173521.54626-4-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 3/3] net/bnxt: update HWRM API to 1.8.2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Oct 2017 19:39:33 -0000 On 10/12/2017 10:35 AM, Ajit Khaparde wrote: > This patch updates the HWRM APi to version 1.8.2 > This patch is based on an autogenerated file. > Almost all the changes in the PMD are macro name changes. > > Signed-off-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt.h | 2 - > drivers/net/bnxt/bnxt_ethdev.c | 2 +- > drivers/net/bnxt/bnxt_hwrm.c | 2 +- > drivers/net/bnxt/bnxt_hwrm.h | 2 + > drivers/net/bnxt/bnxt_irq.c | 2 +- > drivers/net/bnxt/bnxt_rxr.c | 4 +- > drivers/net/bnxt/bnxt_txr.c | 2 +- > drivers/net/bnxt/hsi_struct_def_dpdk.h | 30829 ++++++++++++++++++++++++------- Only 30K lines of code :) > 8 files changed, 24374 insertions(+), 6471 deletions(-) There are some replacement in hsi_struct_def_dpdk.h, but also there are lots of new additions. Are those new additions really used within the driver? What do you think adding structures that are only used by driver? I am aware code is auto-generated, but it may be possible to add some #ifdefs to the parts DPDK uses and auto-generate file specific for DPDK? Thanks, ferruh