From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C102343BDF; Fri, 8 Mar 2024 09:49:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABA78402E2; Fri, 8 Mar 2024 09:49:19 +0100 (CET) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by mails.dpdk.org (Postfix) with ESMTP id 997EB402E2 for ; Fri, 8 Mar 2024 09:49:17 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Trft514WNz1Z1Kb for ; Fri, 8 Mar 2024 16:46:53 +0800 (CST) Received: from kwepemm600004.china.huawei.com (unknown [7.193.23.242]) by mail.maildlp.com (Postfix) with ESMTPS id 4B42B1404F1 for ; Fri, 8 Mar 2024 16:49:16 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 8 Mar 2024 16:49:15 +0800 Message-ID: <7b6428ca-6303-bcaf-7d8d-56c8a5087995@huawei.com> Date: Fri, 8 Mar 2024 16:49:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v5 3/7] net/hns3: fix dump counter of registers To: Jie Hai , , Yisen Zhuang , Chengchang Tang , Lijun Ou , Chunsong Feng , "Wei Hu (Xavier)" , "Min Hu (Connor)" , Ferruh Yigit CC: References: <20231214015650.3738578-1-haijie1@huawei.com> <20240307030247.599394-1-haijie1@huawei.com> <20240307030247.599394-4-haijie1@huawei.com> From: "lihuisong (C)" In-Reply-To: <20240307030247.599394-4-haijie1@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600004.china.huawei.com (7.193.23.242) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Huisong Li 在 2024/3/7 11:02, Jie Hai 写道: > Since the driver dumps the queue interrupt registers according > to the intr_tqps_num, the counter should be the same. > > Fixes: acb3260fac5c ("net/hns3: fix dump register out of range") > Fixes: 936eda25e8da ("net/hns3: support dump register") > > Signed-off-by: Jie Hai > Cc: stable@dpdk.org > --- > drivers/net/hns3/hns3_regs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/hns3/hns3_regs.c b/drivers/net/hns3/hns3_regs.c > index be1be6a89c94..d77170481a3d 100644 > --- a/drivers/net/hns3/hns3_regs.c > +++ b/drivers/net/hns3/hns3_regs.c > @@ -135,7 +135,7 @@ hns3_get_regs_length(struct hns3_hw *hw, uint32_t *length) > tqp_intr_lines = sizeof(tqp_intr_reg_addrs) / REG_LEN_PER_LINE + 1; > > len = (cmdq_lines + common_lines + ring_lines * hw->tqps_num + > - tqp_intr_lines * hw->num_msi) * REG_NUM_PER_LINE; > + tqp_intr_lines * hw->intr_tqps_num) * REG_NUM_PER_LINE; > > if (!hns->is_vf) { > ret = hns3_get_regs_num(hw, ®s_num_32_bit, ®s_num_64_bit);