From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67EE6A04BB; Tue, 6 Oct 2020 12:16:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 528FBF64; Tue, 6 Oct 2020 12:16:22 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 0BC34F3E for ; Tue, 6 Oct 2020 12:16:19 +0200 (CEST) IronPort-SDR: sSq3OveiCJTbqc+5o/eAZUh61E5xN5Y5Sdpw1X4e77hpxJ00UfmsZsRTT3FHx++xY96iin+lS/ S5bHpGjiyZ4Q== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="144342696" X-IronPort-AV: E=Sophos;i="5.77,342,1596524400"; d="scan'208";a="144342696" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 03:16:17 -0700 IronPort-SDR: aZW9KkA1ORgQMUn94cA4J+IsEpbMQIXQ7L0oFEAp+dZVu+y+dNfp9ami6qw21NwxirackXxt1p YErolu4u7XWA== X-IronPort-AV: E=Sophos;i="5.77,342,1596524400"; d="scan'208";a="342180213" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.102]) ([10.213.241.102]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 03:16:14 -0700 To: Thomas Monjalon , dev@dpdk.org Cc: david.marchand@redhat.com, jerinj@marvell.com, stephen@networkplumber.org, Nicolas Chautru , Somalapuram Amaranath , John Griffin , Fiona Trahe , Deepak Kumar Jain , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Ray Kinsella , Neil Horman , Anatoly Burakov References: <20200907225049.547832-1-thomas@monjalon.net> <20201005094300.590912-1-thomas@monjalon.net> From: Ferruh Yigit Message-ID: <7b7c60ef-8b11-ca20-bf09-5f43132cbe3b@intel.com> Date: Tue, 6 Oct 2020 11:16:11 +0100 MIME-Version: 1.0 In-Reply-To: <20201005094300.590912-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4] kernel/linux: remove igb_uio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/5/2020 10:42 AM, Thomas Monjalon wrote: > As decided in the Technical Board in November 2019, > the kernel module igb_uio is moved to the dpdk-kmods repository > in the /linux/igb_uio/ directory. > > Minutes of Technical Board meeting: > https://mails.dpdk.org/archives/dev/2019-November/151763.html > > Signed-off-by: Thomas Monjalon > Acked-by: Stephen Hemminger > --- > v4: Cc more maintainers > v3: update more docs and provide a link to the new repo > v2: update few docs (including release notes) > --- > MAINTAINERS | 1 - > doc/guides/bbdevs/fpga_5gnr_fec.rst | 3 +- > doc/guides/bbdevs/fpga_lte_fec.rst | 3 +- > doc/guides/cryptodevs/ccp.rst | 3 +- > doc/guides/cryptodevs/qat.rst | 3 +- > doc/guides/howto/lm_bond_virtio_sriov.rst | 2 +- > doc/guides/howto/lm_virtio_vhost_user.rst | 2 +- > doc/guides/howto/openwrt.rst | 5 - > doc/guides/linux_gsg/enable_func.rst | 3 +- > doc/guides/linux_gsg/linux_drivers.rst | 23 +- > doc/guides/nics/build_and_test.rst | 2 +- > doc/guides/nics/ena.rst | 4 +- > doc/guides/rel_notes/deprecation.rst | 7 - > doc/guides/rel_notes/release_20_11.rst | 4 +- > doc/guides/sample_app_ug/multi_process.rst | 2 - > drivers/bus/pci/bsd/pci.c | 2 +- > kernel/linux/igb_uio/Kbuild | 2 - > kernel/linux/igb_uio/compat.h | 154 ----- > kernel/linux/igb_uio/igb_uio.c | 660 --------------------- > kernel/linux/igb_uio/meson.build | 20 - > kernel/linux/meson.build | 2 +- > 21 files changed, 21 insertions(+), 886 deletions(-) > delete mode 100644 kernel/linux/igb_uio/Kbuild > delete mode 100644 kernel/linux/igb_uio/compat.h > delete mode 100644 kernel/linux/igb_uio/igb_uio.c > delete mode 100644 kernel/linux/igb_uio/meson.build > Patch doesn't apply cleanly, not sure why, CI seems having same problem: http://mails.dpdk.org/archives/test-report/2020-October/156378.html <...> > index 7789c572bb..080b44955a 100644 > --- a/doc/guides/linux_gsg/linux_drivers.rst > +++ b/doc/guides/linux_gsg/linux_drivers.rst > @@ -27,33 +27,20 @@ can provide the uio capability. This module can be loaded using the command: > > ``uio_pci_generic`` module doesn't support the creation of virtual functions. > > -As an alternative to the ``uio_pci_generic``, the DPDK also includes the igb_uio > -module which can be found in the kernel/linux subdirectory referred to above. It can > -be loaded as shown below: > +As an alternative to the ``uio_pci_generic``, there is the ``igb_uio`` module > +which can be found in the repository `dpdk-kmods `_. > +It can be loaded as shown below: > > .. code-block:: console > > sudo modprobe uio > - sudo insmod /kernel/linux/igb_uio/igb_uio.ko > - > -.. note:: > - > - Building DPDK Linux kernel modules is disabled by default starting from DPDK 20.02. > - To enable them again, the config option "enable_kmods" needs to be set > - in the meson build configuration. > - See :ref:`adjusting_build_options` for details on how to set/clear build options. > - It is planned to move ``igb_uio`` module to a different git repository. > - > -.. note:: > - > - For some devices which lack support for legacy interrupts, e.g. virtual function > - (VF) devices, the ``igb_uio`` module may be needed in place of ``uio_pci_generic``. > + sudo insmod igb_uio.ko > > .. note:: > > If UEFI secure boot is enabled, the Linux kernel may disallow the use of > UIO on the system. Therefore, devices for use by DPDK should be bound to the > - ``vfio-pci`` kernel module rather than ``igb_uio`` or ``uio_pci_generic``. > + ``vfio-pci`` kernel module rather than any UIO-based module. > For more details see :ref:`linux_gsg_binding_kernel` below. Should we change the order of the kernel drivers, currently first section is "UIO" and second section is "VFIO". Since we encoruage vfio and move igb_uio out of the repo, should we list the "VfIO" first? <...> > index 4e61431c6c..243bd940a4 100644 > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -122,9 +122,11 @@ Removed Items > > * vhost: Dequeue zero-copy support has been removed. > > +* kernel: The module ``igb_uio`` has been moved to the git repository > +``dpdk-kmods`` in a new directory ``linux/igb_uio``. > + Doc build giving warning on this: WARNING: Bullet list ends without a blank line; unexpected unindent. Except from above minor comments looks good to me, Reviewed-by: Ferruh Yigit