From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Gaëtan Rivet" <grive@u256.net>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC] ethdev: unify prefix for static function and variables
Date: Fri, 16 Oct 2020 23:47:51 +0100 [thread overview]
Message-ID: <7ba48da1-a179-a627-d9d2-5b56c99270ab@intel.com> (raw)
In-Reply-To: <20201014075949.xsddguwur4tibu3h@u256.net>
On 10/14/2020 8:59 AM, Gaëtan Rivet wrote:
> On 14/10/20 09:25 +0300, Andrew Rybchenko wrote:
>> On 10/13/20 7:56 PM, Ferruh Yigit wrote:
>>> Prefix static function and variables with 'eth_dev'.
>>>
>>> For some 'rte_' prefix dropped, and for others 'eth_dev' added.
>>> This is useful to differentiate public and static function/variables.
>>>
>>> The cleanup is good to for having consistent naming to help new
>>> additions naming.
>>>
>>> No functional change, only naming.
>>>
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> ---
>>> I think this renaming is good idea but not sure if it worth the noise
>>> it creates in the git history, since the change is mostly cosmetic.
>>
>> I like the idea and say yes. Noise on git history is not
>> the main problem here. Fixes backporting will be a problem.
>> Anyway we should do it one day and I see no single reason
>> why not now.
>>
>> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
> Same for me: I think this is a real improvement that trumps issues with
> git noise and backporting problems. As it should happen at some point
> anyway, maybe it would be better to try and have it in 20.11 release?
> That way future bug fixes will at least be based on this naming and
> should be easier to backport.
>
> Acked-by: Gaetan Rivet <grive@u256.net>
>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2020-10-16 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 16:56 Ferruh Yigit
2020-10-14 6:25 ` Andrew Rybchenko
2020-10-14 7:59 ` Gaëtan Rivet
2020-10-16 22:47 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ba48da1-a179-a627-d9d2-5b56c99270ab@intel.com \
--to=ferruh.yigit@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=grive@u256.net \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).