From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC27CA04DB; Sat, 17 Oct 2020 00:48:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 404B0E26F; Sat, 17 Oct 2020 00:48:06 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C75ABE26E for ; Sat, 17 Oct 2020 00:48:03 +0200 (CEST) IronPort-SDR: /9FvNWzHy8eI70bVwS03Qio3SJjI64UE+MlzvqM9f+hJT8WObezs4WQKlE4IeKtKAUeS22HzdL EJnSGML9JkMg== X-IronPort-AV: E=McAfee;i="6000,8403,9776"; a="166782126" X-IronPort-AV: E=Sophos;i="5.77,384,1596524400"; d="scan'208";a="166782126" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 15:47:56 -0700 IronPort-SDR: tlWnoo7yAStejHiIUGLuDAKCcFy7R07gIYGE1/PbMMmGPR9LSeCblHlMJGp17dluXkxUP0mC8Y LAO4UwiRtYQg== X-IronPort-AV: E=Sophos;i="5.77,384,1596524400"; d="scan'208";a="531904056" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.19.66]) ([10.252.19.66]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 15:47:55 -0700 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= , Andrew Rybchenko Cc: Thomas Monjalon , dev@dpdk.org References: <20201013165658.638760-1-ferruh.yigit@intel.com> <8933daaf-b285-3f91-d087-c92d576626a4@oktetlabs.ru> <20201014075949.xsddguwur4tibu3h@u256.net> From: Ferruh Yigit Message-ID: <7ba48da1-a179-a627-d9d2-5b56c99270ab@intel.com> Date: Fri, 16 Oct 2020 23:47:51 +0100 MIME-Version: 1.0 In-Reply-To: <20201014075949.xsddguwur4tibu3h@u256.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC] ethdev: unify prefix for static function and variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/14/2020 8:59 AM, Gaëtan Rivet wrote: > On 14/10/20 09:25 +0300, Andrew Rybchenko wrote: >> On 10/13/20 7:56 PM, Ferruh Yigit wrote: >>> Prefix static function and variables with 'eth_dev'. >>> >>> For some 'rte_' prefix dropped, and for others 'eth_dev' added. >>> This is useful to differentiate public and static function/variables. >>> >>> The cleanup is good to for having consistent naming to help new >>> additions naming. >>> >>> No functional change, only naming. >>> >>> Signed-off-by: Ferruh Yigit >>> --- >>> I think this renaming is good idea but not sure if it worth the noise >>> it creates in the git history, since the change is mostly cosmetic. >> >> I like the idea and say yes. Noise on git history is not >> the main problem here. Fixes backporting will be a problem. >> Anyway we should do it one day and I see no single reason >> why not now. >> >> Acked-by: Andrew Rybchenko > > Same for me: I think this is a real improvement that trumps issues with > git noise and backporting problems. As it should happen at some point > anyway, maybe it would be better to try and have it in 20.11 release? > That way future bug fixes will at least be based on this naming and > should be easier to backport. > > Acked-by: Gaetan Rivet > Applied to dpdk-next-net/main, thanks.